Hey @0xPhaze ! Good stuff!
I ran a deploy script without the US_DRY_RUN=true option, but also without the --broadcast, which gave a simulation of the transactions. However it did create a deployment json file, even though no contracts were actually deployed. If I wanted to go ahead and make a deployment, I'd need to delete some json files before going ahead.
This seems like an in-between step between dry-run and actual execution. Some questions:
- Should this "simulation" be the actual dry run? I.e. Remove the
US_DRY_RUN flag and just rely on whether the broadcast flag is present?
- Regardless whether we keep the
US_DRY_RUN flag, is it possible to detect the absence of the --broadcast flag and not output the deployments .json file?
If you're busy but have an opinion, I/we could make the change.
Hey @0xPhaze ! Good stuff!
I ran a deploy script without the
US_DRY_RUN=trueoption, but also without the--broadcast, which gave a simulation of the transactions. However it did create a deploymentjsonfile, even though no contracts were actually deployed. If I wanted to go ahead and make a deployment, I'd need to delete some json files before going ahead.This seems like an in-between step between dry-run and actual execution. Some questions:
US_DRY_RUNflag and just rely on whether the broadcast flag is present?US_DRY_RUNflag, is it possible to detect the absence of the--broadcastflag and not output the deployments .json file?If you're busy but have an opinion, I/we could make the change.