Update ERC-8180: rename message-ID field author → sender#2
Open
0xrcinus wants to merge 1 commit into
Open
Conversation
Consistency fix: the Message struct, message-hash formula, and signing prose already use `sender` for the same field. Only the message-ID formula, the MessageExposed event topic, and surrounding prose used `author`. Hashed bytes and test-case results are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Naming-consistency fix on ERC-8180. The
Messagestruct inIERC_BAM_Decoder, the message-hash formula, and most surrounding prose already usesenderfor the message-sender's address. Only the message-ID formula, theMessageExposedevent's third indexed topic, and a handful of prose references still usedauthor. This PR renames those tosender.keccak256(abi.encodePacked(author, …))→keccak256(abi.encodePacked(sender, …))MessageExposedevent:address indexed author→address indexed senderWhy this is zero-risk
abi.encodePackeddoesn't see Solidity variable names — only the byte layout. The hashed bytes are identical before and after this rename, so:This is a documentation-only fix that eliminates a long-standing inconsistency between the
Messagestruct field (sender) and the consumers of that field (formerlyauthor).What this PR preserves
author:field (lists EIP authors — unrelated)Test plan
author→senderin the right placesauthor:field preservedsender)MessageExposedis renamedSequencing
This is PR 1 of a planned series of amendments to ERC-8180. PR 2 (
contentTagpromotion) will stack on top of this branch.🤖 Generated with Claude Code