Bug: WALL-E generates multiple "working on it" comments

[kol3x]

This started happening a few days ago with WALL-E sometimes posting two "working on it" comments for a single command, only modifying the last one after generation completion and leaving the other one as "working on it" (here and here)
Today it got really bad - generating 5 comments. 4 of which were left as "working on it" before finally generating the code

Before it happened for the first time I called WALL-E two times at once (to test different models results). First call, second call. The problem appeared in the next generation after these two, but I am not sure if these events are connected at all.

[Lavriz]

The same for me: https://github.com/1712n/dni-code-generation-research/pull/37#issuecomment-2327125275

[evgenydmitriev]

https://github.com/1712n/wall-e/blob/main/src/index.ts

The message.ack() is called at the very end of the queue handler within a finally block. However, there are many asynchronous operations (e.g., github.postComment, sendPrompt, github.fetchFileContents) happening before this point. If any of these asynchronous operations take longer than the maximum execution time of the queue batch, the message might be processed again, leading to duplicate code generation, comments, and potential race conditions.

Possible Solution

Careful ack() Placement: A more robust approach would be to ack() the message only after all the critical asynchronous operations that must complete successfully for a single message are finished. You need to identify the point where you are certain that a retry is no longer desirable and ack() the message there.

I'll get to it when we merge #163

[Lavriz]

@jalmonter fyi: 1712n/dedup-service#3 (comment)