-
-
Notifications
You must be signed in to change notification settings - Fork 8
[Connector] Env var validation (NaN on undefined), CPU parsing, symlink race, typo #411
Copy link
Copy link
Open
Labels
P2-mediumCode quality & robustnessCode quality & robustnessaudit-2026-03From March 2026 codebase auditFrom March 2026 codebase auditconfigConfiguration or environment issueConfiguration or environment issueservice:connector5stackgg/game-server-node-connector service5stackgg/game-server-node-connector service
Description
Summary
Minor configuration and code quality issues.
Findings
- configs/api.ts — parseInt(process.env.X as string) returns NaN if undefined.
- system.service.ts — CPU governor path parsing returns NaN if format changes.
- network.service.ts — NIC name interpolated into bash command (safe now but dangerous pattern).
- network.service.ts — typo: Error running processs (triple s).
- file-operations.service.ts — path validation does not follow symlinks.
Impact
NaN values cause silent failures. Potential future risks.
Suggested Fix
Add fallbacks to parseInt. Fix typo. Use Node.js APIs. Add fs.realpathSync after normalization.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2-mediumCode quality & robustnessCode quality & robustnessaudit-2026-03From March 2026 codebase auditFrom March 2026 codebase auditconfigConfiguration or environment issueConfiguration or environment issueservice:connector5stackgg/game-server-node-connector service5stackgg/game-server-node-connector service
Type
Projects
Status
Backlog