-
-
Notifications
You must be signed in to change notification settings - Fork 8
[Infrastructure] Shell scripts: no error handling in install.sh, unvalidated input, unsafe sed #417
Copy link
Copy link
Open
Labels
P1-highStability & reliabilityStability & reliabilityaudit-2026-03From March 2026 codebase auditFrom March 2026 codebase auditreliabilityReliability or availability concernReliability or availability concernservice:infrastructure5stackgg/5stack-panel infrastructure5stackgg/5stack-panel infrastructure
Description
Summary
Shell scripts lack error handling and input validation.
Findings
- install.sh — no set -e, no error checking. Commands continue on failure.
- setup-env.sh — domain names from read with no format validation. Used in sed.
- replace_rand32_in_env_files.sh — random string can contain sed special chars. No escaping.
Impact
Partial installations in broken state. Invalid domains or malformed .env files.
Suggested Fix
Add set -euo pipefail and trap to all scripts. Validate domain input. Escape sed values or use envsubst.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1-highStability & reliabilityStability & reliabilityaudit-2026-03From March 2026 codebase auditFrom March 2026 codebase auditreliabilityReliability or availability concernReliability or availability concernservice:infrastructure5stackgg/5stack-panel infrastructure5stackgg/5stack-panel infrastructure
Type
Projects
Status
Backlog