Description
In rooms/settings.py, get_default_personas() returns shipped Elena/Viktor/Nyx configs when settings.personas is empty, even if use_shipped_personas is false. Both branches after the empty personas check call _shipped_persona_dicts_to_configs(), so the flag has no effect unless custom personas are listed.
Users who set use_shipped_personas: false expecting an empty roster or a YAML-only custom list get the built-in personas anyway.
Reproduction Steps
- Create
rooms.settings.yaml with use_shipped_personas: false and no personas: key (or personas: []).
- Run
python cli.py (or load settings in a test calling get_default_personas()).
- Observe the wizard still offers Elena, Viktor, and Nyx as default personas.
Expected Behavior
- If
use_shipped_personas: false and personas is non-empty → use YAML personas only.
- If
use_shipped_personas: false and personas is empty → no shipped personas (empty list), and the CLI should error clearly if the user would end up with zero agents, OR document that they must define at least one persona in YAML.
Priority
Medium 🟡
Context
Python 3.x, rooms/settings.py on main after PR #28. Fix should include a unit test in tests/test_settings.py. Small, well-scoped bug; good candidate for good-first-issue.
Description
In
rooms/settings.py,get_default_personas()returns shipped Elena/Viktor/Nyx configs whensettings.personasis empty, even ifuse_shipped_personasisfalse. Both branches after the emptypersonascheck call_shipped_persona_dicts_to_configs(), so the flag has no effect unless custompersonasare listed.Users who set
use_shipped_personas: falseexpecting an empty roster or a YAML-only custom list get the built-in personas anyway.Reproduction Steps
rooms.settings.yamlwithuse_shipped_personas: falseand nopersonas:key (orpersonas: []).python cli.py(or load settings in a test callingget_default_personas()).Expected Behavior
use_shipped_personas: falseandpersonasis non-empty → use YAML personas only.use_shipped_personas: falseandpersonasis empty → no shipped personas (empty list), and the CLI should error clearly if the user would end up with zero agents, OR document that they must define at least one persona in YAML.Priority
Medium 🟡
Context
Python 3.x,
rooms/settings.pyonmainafter PR #28. Fix should include a unit test intests/test_settings.py. Small, well-scoped bug; good candidate forgood-first-issue.