Commit f612dc7
committed
test(clam): address Codex P2 — drop the auc<0.85 upper-bound tripwire
Codex correctly flagged that asserting auc < 0.85 in a library unit test
turns a future quality improvement into a failing test: once a multi-method
CHAODA ensemble lifts the signal past the 0.85 probe bar, cargo test -p
ndarray would fail until an external lance-graph doc is updated. A library
test must never fail because the code got better, and ndarray CI should not
be coupled to a lance-graph note.
Fix: remove the upper-bound assertion. The test now asserts only lower-bound,
forward-compatible invariants — valid range, bit-exact determinism, correct
polarity (outliers >= cluster mean), and better-than-chance (auc > 0.5). The
measured AUC (~ 0.62 today) is surfaced via the existing eprintln diagnostic,
not enforced. Refreshing the PROBE-CHAODA-1000G FINDING in lance-graph when
the ensemble lands is a documentation step, not a gate enforced from this
library's test suite. Doc comment updated to match.
Re-run: test green, ROC_AUC=0.6240 still printed.
https://claude.ai/code/session_01VysoWJ6vsyg3wEGc5v7T5v1 parent f5f7e76 commit f612dc7
1 file changed
Lines changed: 16 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2590 | 2590 | | |
2591 | 2591 | | |
2592 | 2592 | | |
2593 | | - | |
2594 | | - | |
2595 | | - | |
2596 | | - | |
2597 | | - | |
2598 | | - | |
2599 | | - | |
2600 | | - | |
2601 | | - | |
| 2593 | + | |
| 2594 | + | |
| 2595 | + | |
| 2596 | + | |
| 2597 | + | |
| 2598 | + | |
| 2599 | + | |
| 2600 | + | |
| 2601 | + | |
2602 | 2602 | | |
2603 | 2603 | | |
2604 | 2604 | | |
| |||
2663 | 2663 | | |
2664 | 2664 | | |
2665 | 2665 | | |
2666 | | - | |
2667 | | - | |
| 2666 | + | |
| 2667 | + | |
| 2668 | + | |
| 2669 | + | |
| 2670 | + | |
| 2671 | + | |
2668 | 2672 | | |
2669 | 2673 | | |
2670 | 2674 | | |
2671 | 2675 | | |
2672 | 2676 | | |
2673 | 2677 | | |
2674 | | - | |
2675 | | - | |
2676 | | - | |
2677 | | - | |
2678 | | - | |
2679 | | - | |
2680 | | - | |
2681 | | - | |
2682 | | - | |
| 2678 | + | |
2683 | 2679 | | |
2684 | 2680 | | |
2685 | 2681 | | |
| |||
0 commit comments