Skip to content

Refactor weapon visual data declarations to reduce duplication #879

Description

@coderabbitai

Description

The weapon visual data declarations in scripts/scr_culture_visuals/scr_culture_visuals.gml contain repetitive boilerplate code. Each weapon entry repeats the same base.weapon_data structure with display_type and new_weapon_draw: true.

Location

  • File: scripts/scr_culture_visuals/scr_culture_visuals.gml
  • Approximate lines: 1256-1352 (and potentially other weapon declarations)

Impact

  • Increases maintenance friction when patterns change
  • Violates DRY principle
  • Creates unnecessary code duplication

Context

This issue was identified during code review of PR #878 where new 30k weapons were added, highlighting the repetitive pattern.

References

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions