The line_list() function is not working properly

[hugobuddel]

Joshua Jost helped us identify two problems with the line_list() function.

ScopeSim_Templates/scopesim_templates/micado/spectral_calibrations.py

Lines 18 to 26 in d60f37a

	def line_list(unit_flux=1*PHOTLAM,
	dwave=0.001,
	smoothing_fwhm=0.003,
	width=15.,
	height=1.,
	filename="masterlinelist_2.1.txt",
	):
	"""
	Make a ScopeSim.Source object for the calibration lamp line list

• The slanted lines show jagged edges.
• The lines have a Gaussian profile in both directions.

There is a workaround code by Wolfgang that creates an FITS image as Source object that shows the correct behaviour.

[oczoske]

I'm seeing some weird behaviour when I change the width parameter. This is supposed to be in arcseconds, so the default value of 15 should cover the slit. However, this value actually results in the shortest image in the image plane. Here, I have switched off the sky lines - when they are turned on, they are of the correct length and actually longer than any of the lines here.

I'm afraid (nay, scared) that this will throw us into the FieldOfView abyss...

[oczoske]

The problem described in my previous post should be fixed now (AstarVienna/ScopeSim#238) . The question remains how to make this function user-friendly and applicable to all instruments. For a single instrument, we can set smoothing_fwhm and dwave to appropriate values so the user doesn't have to worry about them. This is fine if this function remains in a micado-specific module (we should check whether one set of parameters is good for both IJ and HK). However, the function is obviously useful for METIS (with vastly different parameters for the LSS and IFU modes) and any other spectroscopic instrument. How about moving the function to scopesim.source.source_templates and giving it a parameter for a UserCommands or OpticalTrain object from which the smoothing parameter can be determined automatically?