Skip to content

Remove disabled test files for azure-mgmt-communication#45767

Merged
msyyc merged 1 commit intomainfrom
remove-disabled-communication-tests
Mar 18, 2026
Merged

Remove disabled test files for azure-mgmt-communication#45767
msyyc merged 1 commit intomainfrom
remove-disabled-communication-tests

Conversation

@msyyc
Copy link
Member

@msyyc msyyc commented Mar 18, 2026

Remove disabled test files from sdk/communication/azure-mgmt-communication/tests/:

  • disable_test_mgmt_communication.py
  • disable_test_mgmt_communication_list_resources.py
  • disable_test_mgmt_communication_notification_hub.py

These test files were prefixed with disable_ and are no longer needed.

@msyyc msyyc marked this pull request as ready for review March 18, 2026 06:53
@msyyc msyyc requested a review from ChenxiJiang333 as a code owner March 18, 2026 06:53
Copilot AI review requested due to automatic review settings March 18, 2026 06:53
@msyyc
Copy link
Member Author

msyyc commented Mar 18, 2026

/check-enforcer override

@msyyc msyyc merged commit a0376db into main Mar 18, 2026
9 of 14 checks passed
@msyyc msyyc deleted the remove-disabled-communication-tests branch March 18, 2026 06:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes three previously disabled management-plane test modules from sdk/communication/azure-mgmt-communication/tests/ now that they’re no longer needed, reducing dead/unused test code in the package.

Changes:

  • Deleted disable_test_mgmt_communication.py
  • Deleted disable_test_mgmt_communication_list_resources.py
  • Deleted disable_test_mgmt_communication_notification_hub.py

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk/communication/azure-mgmt-communication/tests/disable_test_mgmt_communication.py Removes a skipped CRUD-style mgmt test module that was explicitly disabled.
sdk/communication/azure-mgmt-communication/tests/disable_test_mgmt_communication_list_resources.py Removes a skipped list-by-subscription / list-by-RG mgmt test module that was explicitly disabled.
sdk/communication/azure-mgmt-communication/tests/disable_test_mgmt_communication_notification_hub.py Removes a skipped notification hub linking mgmt test module that was explicitly disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants