New Crowdin updates#57
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull Request Overview
Sync Crowdin localization updates across English, Spanish, and Russian .po files for new approval/confirmation UI copy and housekeeping.
- Add new i18n keys for approval/confirmation flows; update and reactivate some existing keys.
- Mark some previously used keys as obsolete in non-English locales; update revision timestamps.
- Minor reshuffling of keys in en-US to match current source usage.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| apps/cowswap-frontend/src/locales/ru-RU.po | Added new msgids for approval/confirmation flows, but several msgstr are empty; some keys were marked obsolete. |
| apps/cowswap-frontend/src/locales/es-ES.po | Added new msgids for approval/confirmation flows, but several msgstr are empty; some keys were marked obsolete. |
| apps/cowswap-frontend/src/locales/en-US.po | Reactivated some approval-related keys and adjusted others; removed some previously present composite strings. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| #: apps/cowswap-frontend/src/modules/erc20Approve/hooks/usePendingApprovalModal.tsx | ||
| msgid "Approving <0/> <1><2/></1> for trading" | ||
| msgstr "" |
There was a problem hiding this comment.
Empty msgstr will render nothing at runtime. Provide a Russian translation preserving the placeholders, e.g., msgstr "Одобрение <0/> <1><2/></1> для торговли" (adjust wording as per your style guide). If translation isn't ready, copy the msgid into msgstr to avoid a blank label.
| msgstr "" | |
| msgstr "Одобрение <0/> <1><2/></1> для торговли" |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx | ||
| msgid "Waiting for confirmation." | ||
| msgstr "" |
There was a problem hiding this comment.
Empty msgstr results in missing UI text. Suggested translation: msgstr "Ожидание подтверждения."
| msgstr "" | |
| msgstr "Ожидание подтверждения." |
|
|
||
| #: apps/cowswap-frontend/src/modules/erc20Approve/hooks/usePendingApprovalModal.tsx | ||
| msgid "Approving <0>{currencySymbolOrContext}</0> for trading" | ||
| msgstr "" |
There was a problem hiding this comment.
Empty msgstr will display nothing. Provide a translation and keep the placeholder intact: msgstr "Одобрение <0>{currencySymbolOrContext}</0> для торговли"
| msgstr "" | |
| msgstr "Одобрение <0>{currencySymbolOrContext}</0> для торговли" |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx | ||
| msgid "Follow these steps:" | ||
| msgstr "" |
There was a problem hiding this comment.
This string is untranslated (empty) and will render blank. Suggested translation: msgstr "Выполните следующие шаги:" Also note en-US has msgid "Follow these steps" (without colon); please align msgid usage across locales to ensure the translation is picked up.
| msgstr "" | |
| msgstr "Выполните следующие шаги:" |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx | ||
| msgid "The {operationLabel} is signed." | ||
| msgstr "" |
There was a problem hiding this comment.
Untranslated string will appear empty. Suggested translation: msgstr "{operationLabel} подписана." or "Операция {operationLabel} подписана." Keep the {operationLabel} placeholder unchanged.
| msgstr "" | |
| msgstr "Операция {operationLabel} подписана." |
|
|
||
| #: apps/cowswap-frontend/src/modules/erc20Approve/hooks/usePendingApprovalModal.tsx | ||
| msgid "Approving <0>{currencySymbolOrContext}</0> for trading" | ||
| msgstr "" |
There was a problem hiding this comment.
Empty msgstr results in blank UI. Suggested translation: msgstr "Aprobando <0>{currencySymbolOrContext}</0> para operar" (keep {currencySymbolOrContext} intact).
| msgstr "" | |
| msgstr "Aprobando <0>{currencySymbolOrContext}</0> para operar" |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx | ||
| msgid "Follow these steps:" | ||
| msgstr "" |
There was a problem hiding this comment.
Untranslated string will render empty. Suggested translation: msgstr "Siga estos pasos:" Also, en-US uses msgid "Follow these steps" (without colon); please align msgid across locales to ensure the correct key is translated.
| msgstr "" | |
| msgstr "Siga estos pasos:" |
|
|
||
| #: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx | ||
| msgid "The {operationLabel} is signed." | ||
| msgstr "" |
There was a problem hiding this comment.
Leaving msgstr empty will hide the message. Suggested translation: msgstr "La {operationLabel} está firmada." Keep {operationLabel} unchanged.
| msgstr "" | |
| msgstr "La {operationLabel} está firmada." |
| #~ msgid "Approving" | ||
| #~ msgstr "Approving" |
There was a problem hiding this comment.
These keys are obsolete in es-ES but active in en-US. If the UI now builds the phrase from separate parts, Spanish will fall back to English. Re-add active entries with translations, e.g., msgstr "Aprobando" and msgstr "para operar".
| #~ msgid "Approving" | |
| #~ msgstr "Approving" | |
| msgid "Approving" | |
| msgstr "Aprobando" |
| #~ msgid "for trading" | ||
| #~ msgstr "for trading" |
There was a problem hiding this comment.
These keys are obsolete in es-ES but active in en-US. If the UI now builds the phrase from separate parts, Spanish will fall back to English. Re-add active entries with translations, e.g., msgstr "Aprobando" and msgstr "para operar".
| #~ msgid "for trading" | |
| #~ msgstr "for trading" | |
| msgid "for trading" | |
| msgstr "para operar" |
No description provided.