Skip to content

New Crowdin updates#57

Closed
gabitoesmiapodo wants to merge 3 commits into
feat/internationalization-setup-for-swap-cow-fifrom
l10n_feat/internationalization-setup-for-swap-cow-fi
Closed

New Crowdin updates#57
gabitoesmiapodo wants to merge 3 commits into
feat/internationalization-setup-for-swap-cow-fifrom
l10n_feat/internationalization-setup-for-swap-cow-fi

Conversation

@gabitoesmiapodo
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Canceled Canceled Oct 16, 2025 2:41pm

@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch October 16, 2025 14:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Sync Crowdin localization updates across English, Spanish, and Russian .po files for new approval/confirmation UI copy and housekeeping.

  • Add new i18n keys for approval/confirmation flows; update and reactivate some existing keys.
  • Mark some previously used keys as obsolete in non-English locales; update revision timestamps.
  • Minor reshuffling of keys in en-US to match current source usage.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Added new msgids for approval/confirmation flows, but several msgstr are empty; some keys were marked obsolete.
apps/cowswap-frontend/src/locales/es-ES.po Added new msgids for approval/confirmation flows, but several msgstr are empty; some keys were marked obsolete.
apps/cowswap-frontend/src/locales/en-US.po Reactivated some approval-related keys and adjusted others; removed some previously present composite strings.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


#: apps/cowswap-frontend/src/modules/erc20Approve/hooks/usePendingApprovalModal.tsx
msgid "Approving <0/> <1><2/></1> for trading"
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty msgstr will render nothing at runtime. Provide a Russian translation preserving the placeholders, e.g., msgstr "Одобрение <0/> <1><2/></1> для торговли" (adjust wording as per your style guide). If translation isn't ready, copy the msgid into msgstr to avoid a blank label.

Suggested change
msgstr ""
msgstr "Одобрение <0/> <1><2/></1> для торговли"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx
msgid "Waiting for confirmation."
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty msgstr results in missing UI text. Suggested translation: msgstr "Ожидание подтверждения."

Suggested change
msgstr ""
msgstr "Ожидание подтверждения."

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/modules/erc20Approve/hooks/usePendingApprovalModal.tsx
msgid "Approving <0>{currencySymbolOrContext}</0> for trading"
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty msgstr will display nothing. Provide a translation and keep the placeholder intact: msgstr "Одобрение <0>{currencySymbolOrContext}</0> для торговли"

Suggested change
msgstr ""
msgstr "Одобрение <0>{currencySymbolOrContext}</0> для торговли"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx
msgid "Follow these steps:"
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is untranslated (empty) and will render blank. Suggested translation: msgstr "Выполните следующие шаги:" Also note en-US has msgid "Follow these steps" (without colon); please align msgid usage across locales to ensure the translation is picked up.

Suggested change
msgstr ""
msgstr "Выполните следующие шаги:"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx
msgid "The {operationLabel} is signed."
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untranslated string will appear empty. Suggested translation: msgstr "{operationLabel} подписана." or "Операция {operationLabel} подписана." Keep the {operationLabel} placeholder unchanged.

Suggested change
msgstr ""
msgstr "Операция {operationLabel} подписана."

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/modules/erc20Approve/hooks/usePendingApprovalModal.tsx
msgid "Approving <0>{currencySymbolOrContext}</0> for trading"
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty msgstr results in blank UI. Suggested translation: msgstr "Aprobando <0>{currencySymbolOrContext}</0> para operar" (keep {currencySymbolOrContext} intact).

Suggested change
msgstr ""
msgstr "Aprobando <0>{currencySymbolOrContext}</0> para operar"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx
msgid "Follow these steps:"
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untranslated string will render empty. Suggested translation: msgstr "Siga estos pasos:" Also, en-US uses msgid "Follow these steps" (without colon); please align msgid across locales to ensure the correct key is translated.

Suggested change
msgstr ""
msgstr "Siga estos pasos:"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/common/pure/ConfirmationPendingContent/ConfirmationPendingContent.tsx
msgid "The {operationLabel} is signed."
msgstr ""
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving msgstr empty will hide the message. Suggested translation: msgstr "La {operationLabel} está firmada." Keep {operationLabel} unchanged.

Suggested change
msgstr ""
msgstr "La {operationLabel} está firmada."

Copilot uses AI. Check for mistakes.
Comment on lines +4402 to +4403
#~ msgid "Approving"
#~ msgstr "Approving"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These keys are obsolete in es-ES but active in en-US. If the UI now builds the phrase from separate parts, Spanish will fall back to English. Re-add active entries with translations, e.g., msgstr "Aprobando" and msgstr "para operar".

Suggested change
#~ msgid "Approving"
#~ msgstr "Approving"
msgid "Approving"
msgstr "Aprobando"

Copilot uses AI. Check for mistakes.
Comment on lines +4441 to +4442
#~ msgid "for trading"
#~ msgstr "for trading"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These keys are obsolete in es-ES but active in en-US. If the UI now builds the phrase from separate parts, Spanish will fall back to English. Re-add active entries with translations, e.g., msgstr "Aprobando" and msgstr "para operar".

Suggested change
#~ msgid "for trading"
#~ msgstr "for trading"
msgid "for trading"
msgstr "para operar"

Copilot uses AI. Check for mistakes.
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2025
@gabitoesmiapodo gabitoesmiapodo review requested due to automatic review settings March 23, 2026 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants