From cb00693d0eedca50c767cfbbfcb79fe75dc4a47c Mon Sep 17 00:00:00 2001 From: Yaroslav Lapin Date: Fri, 26 Jul 2024 14:17:12 -0600 Subject: [PATCH 1/2] do not use raw url in srcset --- packages/sdks/src/blocks/image/image.helpers.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sdks/src/blocks/image/image.helpers.ts b/packages/sdks/src/blocks/image/image.helpers.ts index fecc1c9543d..f2ded8e8eb1 100644 --- a/packages/sdks/src/blocks/image/image.helpers.ts +++ b/packages/sdks/src/blocks/image/image.helpers.ts @@ -58,7 +58,7 @@ export function getSrcSet(url: string): string { return sizes .filter((size) => size !== widthInSrc) .map((size) => `${updateQueryParam(url, 'width', size)} ${size}w`) - .concat([srcUrl]) + .concat([`${srcUrl} 9999w`]) .join(', '); } From 82473d486ba05cfed2019805098dd3d3ae959881 Mon Sep 17 00:00:00 2001 From: Yaroslav Lapin Date: Wed, 31 Jul 2024 15:57:29 -0600 Subject: [PATCH 2/2] update per samijaber's suggestion --- packages/sdks/src/blocks/image/image.helpers.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/sdks/src/blocks/image/image.helpers.ts b/packages/sdks/src/blocks/image/image.helpers.ts index f2ded8e8eb1..68faf4fa82c 100644 --- a/packages/sdks/src/blocks/image/image.helpers.ts +++ b/packages/sdks/src/blocks/image/image.helpers.ts @@ -53,12 +53,14 @@ export function getSrcSet(url: string): string { const widthInSrc = Number(url.split('?width=')[1]); if (!isNaN(widthInSrc)) { srcUrl = `${srcUrl} ${widthInSrc}w`; + } else { + srcUrl = `${srcUrl} 9999w`; // #3448 every srcset element has to have "w" or "x", otherwise browsers might ignore srcset } return sizes .filter((size) => size !== widthInSrc) .map((size) => `${updateQueryParam(url, 'width', size)} ${size}w`) - .concat([`${srcUrl} 9999w`]) + .concat([srcUrl]) .join(', '); }