Skip to content

Design Docs Review #3 #3

@jliversi

Description

@jliversi

Great work on your final docs, here are my notes:
BACKEND ROUTES

  • Make sure to include a colon on your wildcards
  • You should have a show route for users (/api/users/:user_id). This will be useful for grabbing the current user but also for grabbing friends.
  • Your POST, PATCH, and DELETE bill routes don't need to be nested under users. For the POST, this will always be current_user (which you have on the backend), and on the others, if you have the :id of the bill, you don't need the author_id
  • Comment routes only need to be nested under bills, not also under users. (And the PATCH and the DELETE don't have to be nested at all, for the same reasons as above).
  • Your PATCH and DELETE group routes also don't need to be nested.

FRONTEND ROUTES AND COMPONENTS

  • The signup form and login form are pretty different on splitwise, so you'll want separate components (LoginForm and SignupForm). We use a shared SessionForm when they're very similar.
  • Currently it's hard to tell what is a route and what is a component. Clean this up so routes are always at the top with components rendered at that route (and their subcomponents) are below.
  • While addressing the previous point, make sure to fill in the components for groups and friends.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions