From cd14a25d8d9582ed1c90ab1629e6e1a878f36d4e Mon Sep 17 00:00:00 2001 From: Ryan Arakawa Date: Tue, 24 Mar 2026 14:23:30 -0500 Subject: [PATCH] completed and awaiting partial updates * remove form name since we only add form name on creation and don't sync it to external API on edits * change copy to inform the user of the status of the form "Submitted", "Completed", or "Awaiting approval" * add DocuSeal attribution to awaiting status page --- app/views/submit_form/awaiting.html.erb | 1 - app/views/submit_form/completed.html.erb | 13 +++++++++---- config/locales/i18n.yml | 2 ++ 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/app/views/submit_form/awaiting.html.erb b/app/views/submit_form/awaiting.html.erb index 76da357d8..5856b8fac 100644 --- a/app/views/submit_form/awaiting.html.erb +++ b/app/views/submit_form/awaiting.html.erb @@ -7,7 +7,6 @@ <%= svg_icon('writing_sign', class: 'w-10 h-10') %>
-

<%= @submitter.submission.name || @submitter.submission.template.name %>

<%= t('awaiting_completion_by_the_other_party') %>

diff --git a/app/views/submit_form/completed.html.erb b/app/views/submit_form/completed.html.erb index be5ee7cf6..ff4b4a701 100644 --- a/app/views/submit_form/completed.html.erb +++ b/app/views/submit_form/completed.html.erb @@ -7,10 +7,14 @@ <%= svg_icon('writing_sign', class: 'w-10 h-10') %>
-

<%= @submitter.submission.name || @submitter.submission.template.name %>

-

- <%= t(@submitter.with_signature_fields? ? 'signed_on_time' : 'completed_on_time', time: l(@submitter.completed_at.to_date, format: :long)) %> -

+ <% if @submitter.submission.requires_approval? && @submitter.submission.approved_at.nil? %> +

<%= t('submitted_on_time', time: l(@submitter.completed_at.to_date, format: :long)) %>

+

<%= t('awaiting_manager_approval') %>

+ <% else %> +

+ <%= t(@submitter.with_signature_fields? ? 'signed_on_time' : 'completed_on_time', time: l(@submitter.completed_at.to_date, format: :long)) %> +

+ <% end %>
@@ -19,3 +23,4 @@ +<%= render 'shared/attribution', link_path: '/start', account: @submitter.account %> diff --git a/config/locales/i18n.yml b/config/locales/i18n.yml index 8c6d38d5a..43efd4158 100644 --- a/config/locales/i18n.yml +++ b/config/locales/i18n.yml @@ -130,6 +130,8 @@ en: &en you_have_been_invited_to_submit_a_form: You have been invited to submit a form signed_on_time: 'Signed on %{time}' completed_on_time: 'Completed on %{time}' + submitted_on_time: 'Submitted on %{time}' + awaiting_manager_approval: 'Awaiting manager approval' document_has_been_signed_already: Document has been signed already form_has_been_submitted_already: Form has been submitted already send_copy_to_email: Send copy to Email