Skip to content

Commit 48ff534

Browse files
CopilotChangeHow
andauthored
Restore interactive terminal input for install.sh in curl | bash installs (#22)
- [x] Review the new PR comment and determine whether it needs a code change or an explanation - [ ] Inspect the install launcher and related test coverage to confirm the root cause - [ ] Reply on the PR thread with a concise explanation if no code changes are needed <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
1 parent b9db743 commit 48ff534

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ cd "${WORK_DIR}/repo"
4949
npm ci --no-fund --no-audit
5050

5151
echo "Launching suitup inside zsh..."
52-
zsh -lc 'cd "$1" && shift && node src/cli.js "$@"' -- "${WORK_DIR}/repo" "$@"
52+
zsh -lc 'cd "$1" && shift && node src/cli.js "$@"' -- "${WORK_DIR}/repo" "$@" < /dev/tty

tests/install-script.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,13 @@ describe("install.sh", () => {
1616
}).not.toThrow();
1717
});
1818

19-
test("downloads the repo archive, installs dependencies, and launches under zsh", () => {
19+
test("downloads the repo archive, installs dependencies, and launches under zsh with terminal input", () => {
2020
const content = readFileSync(INSTALL_SCRIPT, "utf-8");
2121

2222
expect(content).toContain("https://github.com/${REPO_SLUG}/archive/refs/heads/${SUITUP_REF}.tar.gz");
2323
expect(content).toContain("npm ci --no-fund --no-audit");
2424
expect(content).toContain("require_cmd zsh");
2525
expect(content).toContain("zsh -lc");
26+
expect(content).toContain("< /dev/tty");
2627
});
2728
});

0 commit comments

Comments
 (0)