refactor(pdf-adapter): change converter#46
Draft
Alexnortung wants to merge 2 commits into
Draft
Conversation
|
@Alexnortung is attempting to deploy a commit to the Chipili's projects Team on Vercel. A member of the Team first needs to authorize it. |
Alexnortung
force-pushed
the
refactor/pdf-adapter
branch
from
204591c to
4dee3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the converter to use
pdfkit.The current problem is that the pdf converter uses either a canvas based approach, which just results in an image or a poorly formatted pdf document or it uses libreoffice-convert, which may not be available in all environments and would require more setup.