feat: handles border-style hidden on tables and table cells#88
Draft
lasserb-oak wants to merge 2 commits into
Draft
feat: handles border-style hidden on tables and table cells#88lasserb-oak wants to merge 2 commits into
lasserb-oak wants to merge 2 commits into
Conversation
|
@lasserb-oak is attempting to deploy a commit to the Chipili's projects Team on Vercel. A member of the Team first needs to authorize it. |
Alexnortung
reviewed
May 12, 2026
Comment on lines
+2054
to
+2056
| expect(visibleCellBorders['w:right']?.['@_w:val']).toBe('single'); | ||
| expect(visibleCellBorders['w:top']?.['@_w:val']).toBe('single'); | ||
| expect(visibleCellBorders['w:bottom']?.['@_w:val']).toBe('single'); |
Collaborator
There was a problem hiding this comment.
In HTML tables do not have borders by default. so maybe the test could add a stylesheet where th/th has border: 1px solid #000000 and then explicitly setting border style hidden as you already do?
Collaborator
There was a problem hiding this comment.
Are these changes really necessary?
Contributor
Author
There was a problem hiding this comment.
Perhaps they are overkill. But without this, the border-styling did not get reflected in export to PDF, only docX.
wip wip wip wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes support for
border-style: hiddenon tables and table cells when exported to DocX and PDF, plus adds regression tests.