Add a History feature to the questbook by Aedial · Pull Request #156 · CleanroomMC/BetterQuesting

Aedial · 2026-05-28T21:31:22Z

The History is a list of quest entries (similar to Search, which it was adapted from), sorted by finish time in descending order. Only finished quests are indexed, and clicking on an entry opens the quest. The intent is allowing people to find/understand what they just unlocked in a big quest book and claim the rewards individually.
As it relies on already present data, all state is transient, re-indexed when the tab is opened. The position in the list (scroll bar) is restored when going back to the history (e.g., via the Back button), but this information only lasts as long as the client session.

The button to access it currently sits just above the search button, which may affect the muscle memory of people used to the edit button being at the same position, but it seemed weird to put it above edit if edit was on.

Sorted in descending order, from most recent. Adding time ranges, later, may be a good addition

WaitingIdly

how should repeatable quests be stored? currently, they go to the top of the list as soon as they completed and then are reset to the bottom with - when they reset. this seems suboptimal.

for the most part, bqu tends to combine something like

GuiTransform bgTransform = new GuiTransform(GuiAlign.FULL_BOX, new GuiPadding(0, 0, 0, 0), 0);
CanvasTextured cvBackground = new CanvasTextured(bgTransform, PresetTexture.PANEL_MAIN.getTexture());

into just

CanvasTextured cvBackground = new CanvasTextured(new GuiTransform(GuiAlign.FULL_BOX, new GuiPadding(0, 0, 0, 0), 0), PresetTexture.PANEL_MAIN.getTexture());

should change your code to match.

An additional key has been added for completion date (defaults to timestamp if missing). The History now has a setting to decide how to show repeatables.

Aedial

Yes, the separation of GuiTransform was to make things more readable, but I guess consistency trumps columns count.

The requested changes have been applied. Additionally, I tackled the Repeatable Quests issue by moving from "using the timestamp" to "adding a complete-at key to quests" (defaults to timestamp if missing).
The visibility of repeatable quests now depends on a cycling button (show all, show claimable, hide all) with a hidden, persistent config backing it up.
During the implementation, I also fixed a rendering issue with PresetTexture.BTN_ALT_*, which was producing a dark line (part of the border, I think) in the middle of the button. Looking at the texture, BTN_CLEAN_* suffers from the same issue, but I haven't touched it.

WaitingIdly · 2026-05-30T00:51:13Z

+    public enum RepeatableFilter {
+        HIDE("betterquesting.gui.history.repeatable_filter.hide"),
+        SHOW_PENDING_REWARDS("betterquesting.gui.history.repeatable_filter.pending_rewards"),
+        SHOW_ALL("betterquesting.gui.history.repeatable_filter.all");


what about expanding this to filter everything - mainly, i would like to filter by "pending rewards" for all quests.

So 2 buttons or drop hiding repeatables altogether?

i think i would be fine with either, but would prefer two buttons

WaitingIdly · 2026-05-30T01:09:45Z

+    private void createRepeatableFilterButton(CanvasEmpty cvInner) {
+        repeatableFilterButton = new PanelButton(new GuiTransform(GuiAlign.TOP_EDGE, new GuiPadding(0, 16, 8, -32), 0), 1, "");
+        repeatableFilterButton.setClickAction(button -> cycleRepeatableFilter());
+        repeatableFilterButton.setTextures(PresetTexture.BTN_ALT_0.getTexture(), PresetTexture.BTN_ALT_1.getTexture(), PresetTexture.BTN_ALT_2.getTexture());


i dont think i like BTN_ALT_\d here. feels odd.

What do you have in mind? I started with the same background as the quest entries, but it was awful for visibility, hence the button skin.

shrinking the size and offsetting it by a bit? perhaps converting the button into just an icon and having the mode be a tooltip.

WaitingIdly · 2026-05-30T01:24:01Z

+        this.addPanel(buttonContainer);
+
+        GuiRectangle questButtonRect = new GuiRectangle(2, 2, 28, 28);
+        PanelButtonQuest questButton = new PanelButtonQuest(questButtonRect, 0, "", entry.getQuest());


need to update this regularly to have the correct color - test a quest that resets, have it be completed when the gui opens and then reset while the gui remains open. color will not change, but should.

Yes, I avoided refreshing in real time, as it an be kinda expensive on big quest books. I guess I can updates every X seconds, with X configurable, but the user can just as much close and reopen.

WaitingIdly · 2026-06-06T04:44:10Z

+     *         For quests completed before this was added, it will return the timestamp value (may be inaccurate for repeatable quests).
+     *         For quests not completed, it will return 0.
+     */
+    default long getLastCompletedAt(UUID uuid) {


move this to QuestInstance

WaitingIdly · 2026-06-06T04:50:29Z

    }

+    private void ensureLastCompletedAt(NBTTagCompound entry, long fallbackTimestamp) {
+        if (entry.hasKey(IQuest.LAST_COMPLETED_AT_TAG, Constants.NBT.TAG_LONG)) {


checking if its been set already seems to make this a "first completed at" instead of a "last completed at" whenever this gets called. is there something im missing here?

This function is meant as a fallback if the normal path is not respected, see the comment at line 218. The "completed at" should reflect the completion time, not claiming, but I haven't found any clean way to ensure the key is updated here without also updating "completion time" to "claim time".

WaitingIdly · 2026-06-06T04:51:16Z

 import java.util.UUID;

 public interface IQuest extends INBTSaveLoad<NBTTagCompound>, INBTProgress<NBTTagCompound>, IPropertyContainer {
+    String LAST_COMPLETED_AT_TAG = "last_completed_at";


as much as it would be beneficial to do this, we currently dont, and so shouldnt store the name in a field.

Aedial added 2 commits May 28, 2026 20:50

Add a History button, showing finished quest

5c20429

Sorted in descending order, from most recent. Adding time ranges, later, may be a good addition

Restore scroll bar position when using the Back button

2e535d1

WaitingIdly requested changes May 28, 2026

View reviewed changes

Handle repeatable quests edge case

8c2aa7c

An additional key has been added for completion date (defaults to timestamp if missing). The History now has a setting to decide how to show repeatables.

Aedial commented May 29, 2026

View reviewed changes

WaitingIdly reviewed Jun 6, 2026

View reviewed changes

Conversation

Aedial commented May 28, 2026

Uh oh!

WaitingIdly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aedial left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Aedial left a comment •

edited

Loading