refactor: change fetch type to EAGER for relationships in entities and enable async processing in EmailService

Author: PedroVidalDev

src/main/java/com/pedro/sphynx/SphynxApplication.java

@@ -4,8 +4,10 @@
 
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.scheduling.annotation.EnableAsync;
 
 @SpringBootApplication
+@EnableAsync
 public class SphynxApplication {
 
 	public static void main(String[] args) {

src/main/java/com/pedro/sphynx/entities/Access.java

@@ -19,15 +19,15 @@ public class Access {
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "user_id")
     private User user;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "local_id")
     private Local local;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "unit_id")
     private Unit unit;
 

src/main/java/com/pedro/sphynx/entities/Group.java

@@ -29,15 +29,15 @@ public class Group {
     @JoinTable(name = "locals_groups", joinColumns = @JoinColumn(name = "group_id"), inverseJoinColumns = @JoinColumn(name = "local_id"))
     private Set<Local> locals;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "user_id")
     private User user;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "unit_id")
     private Unit unit;
 
-    @ManyToMany
+    @ManyToMany(fetch = FetchType.EAGER)
     @JoinTable(name = "week_days_groups", joinColumns = @JoinColumn(name = "group_id"), inverseJoinColumns = @JoinColumn(name = "week_day_id"))
     private Set<WeekDay> weekDays;
 

src/main/java/com/pedro/sphynx/entities/Unit.java

@@ -26,16 +26,16 @@ public class Unit {
     private LocalDateTime dtcreate;
     private LocalDateTime dtupdate;
 
-    @OneToMany(mappedBy = "unit", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "unit", fetch = FetchType.EAGER)
     private List<User> users;
 
-    @OneToMany(mappedBy = "unit", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "unit", fetch = FetchType.EAGER)
     private List<Local> locals;
 
-    @OneToMany(mappedBy = "unit", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "unit", fetch = FetchType.EAGER)
     private List<Group> groups;
 
-    @OneToMany(mappedBy = "unit", fetch = FetchType.LAZY)
+    @OneToMany(mappedBy = "unit", fetch = FetchType.EAGER)
     private List<Access> accesses;
 
     public Unit(UnitDataInput data){

src/main/java/com/pedro/sphynx/entities/User.java

@@ -39,19 +39,19 @@ public class User implements UserDetails {
 
     private String password;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "unit_id")
     private Unit unit;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "group_id")
     private Group group;
 
-    @ManyToOne(fetch = FetchType.LAZY)
+    @ManyToOne(fetch = FetchType.EAGER)
     @JoinColumn(name = "user_id")
     private User userCreator;
 
-    @ManyToMany(fetch = FetchType.LAZY)
+    @ManyToMany(fetch = FetchType.EAGER)
     @JoinTable(name = "permission_menus_users", joinColumns = @JoinColumn(name = "user_id"), inverseJoinColumns = @JoinColumn(name = "permission_menu_id"))
     private List<PermissionMenu> permissionMenus;
 

src/main/java/com/pedro/sphynx/services/EmailService.java

@@ -3,6 +3,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.mail.SimpleMailMessage;
 import org.springframework.mail.javamail.JavaMailSender;
+import org.springframework.scheduling.annotation.Async;
 import org.springframework.stereotype.Service;
 
 @Service
@@ -11,6 +12,7 @@ public class EmailService {
     @Autowired
     private JavaMailSender emailSender;
 
+    @Async
     public void sendSimpleMessage(String to, String subject, String text) {
         SimpleMailMessage message = new SimpleMailMessage();
         message.setFrom("pedrohvidals@gmail.com");

src/main/java/com/pedro/sphynx/services/UserService.java

@@ -8,6 +8,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 import com.pedro.sphynx.dtos.auth.UserDataComplete;
 import com.pedro.sphynx.dtos.auth.UserDataRegisterInput;
@@ -44,6 +45,7 @@ public class UserService {
 
     private BCryptPasswordEncoder passwordEncoder = new BCryptPasswordEncoder(12);
 
+    @Transactional
     public UserDataComplete create(UserDataRegisterInput data, User loggedUser) {
         if (userRepository.existsByUser(data.user())) {
             throw new EntityExistsException("User already exists");
@@ -129,12 +131,14 @@ public UserDataComplete create(UserDataRegisterInput data, User loggedUser) {
         return new UserDataComplete(userCreated);
     }
 
+    @Transactional
     public UserDataComplete getById(Long id) {
         User userEntity = userRepository.findById(id)
             .orElseThrow(() -> new EntityExistsException("User not found"));
         return new UserDataComplete(userEntity);
     }
 
+    @Transactional
     public List<UserDataComplete> getAll(User loggedUser) {
         List<UserDataComplete> listUsers;
 
@@ -156,6 +160,7 @@ public List<UserDataComplete> getAll(User loggedUser) {
         return listUsers;
     }
 
+    @Transactional
     public void delete(Long id) {
         if (!userRepository.existsById(id)) {
             throw new EntityExistsException("User not found");
@@ -164,6 +169,7 @@ public void delete(Long id) {
         userRepository.deleteById(id);
     }
 
+    @Transactional
     public UserDataComplete update(UserDataRegisterInput data, Long id){
         if(!userRepository.existsById(id)) {
             throw new EntityNotFoundException(messages.getString("error.idDontExists"));