Switch development from SQLite, or patch as no-op?

[mrj]

Now that SQLite support has been removed, what is the best way to develop an app that needs advisory locks: Change development to another database, or patch with_advisory_lock to do nothing on SQLite rather than give the error

NoMethodError: undefined method 'with_advisory_lock_if_needed' for an instance of ActiveRecord::ConnectionAdapters::SQLite3Adapter (NoMethodError)

?

The former has the burden of having a database server set up and running, but the latter doesn't exercise the locking code in development, even though a lock will never wait with single-threaded access.

I'd like the option of a no-op to simplify initial development, changing the dev database closer to first deployment.

Is it easy to make everything a no-op on SQLite?

[seuros]

We could add opt-in no-op support sqlite.

The previous implementation was just a hack, at high frequency, you get thousands of lockfiles. Also it caused lot of problem with Async.

By having an opt-in, developer assert that they are aware of the consequences of not mirroring their dev/prod database.

Just for info, advisory lock is not even similar between database engines.. (still can't get MariaDB to work).
So it better to have little friction than to have people debug for hours because the lock was not even engaged in dev/test.

That said, if you like the idea or have other suggestions, you free to open a PR.

[mrj]

Thank you Abdelkader. for your thoughts. I will look at the code to see whether an SQLite no-op is easy to add.

There are so many other differences between production and development that the lack of real locking is no deal-breaker. A staging deployment is the way to avoid surprises.

[mrj]

How would you suggest op-in support be implemented?

In the Gemfile like

group :development do
 gem 'with_advisory_lock', require: 'unsupported_noop'
end

group :production do
 gem 'with_advisory_lock'
end

or with an initialiser

 WithAdvisoryLock.unsupported_noop = Rails.env.development?

?

[seuros]

require 'with_advisory_lock/sqlite3_compact' in application.rb

No condition..

In prod, sqlite3 is not used: the adapter get patches only if get loaded..