Skip to content

Commit 0010c70

Browse files
HardeepAsraniHardeepAsrani
committed
chore: fix qa
1 parent a406e7e commit 0010c70

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

‎classes/Visualizer/Render/Library.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ private function _renderLibrary() {
293293
if ( ! empty( $this->charts ) ) {
294294
if ( $this->_isListView() ) {
295295
echo '<div id="visualizer-library" class="visualizer-clearfix view-list">';
296+
$this->_renderSidebar();
296297
echo '<table class="wp-list-table widefat striped viz-charts-table">';
297298
echo '<thead><tr>';
298299
echo '<th class="col-id">' . esc_html__( 'ID', 'visualizer' ) . '</th>';
@@ -314,7 +315,6 @@ private function _renderLibrary() {
314315
$this->_renderChartBox( $placeholder_id, $chart['id'], $enable_controls );
315316
}
316317
echo '</tbody></table>';
317-
$this->_renderSidebar();
318318
echo '</div>';
319319
} else {
320320
echo '<div id="visualizer-library" class="visualizer-clearfix view-grid">';
@@ -354,7 +354,7 @@ private function _renderLibrary() {
354354
echo '<span class="visualizer-chart-action visualizer-nochart-image"><span class="dashicons dashicons-format-image"></span></span>';
355355
echo '<span class="visualizer-chart-action visualizer-nochart-export"><span class="dashicons dashicons-download"></span></span>';
356356
echo '<span class="visualizer-chart-action visualizer-nochart-clone"><span class="dashicons dashicons-admin-page"></span></span>';
357-
echo '<span class="visualizer-chart-action visualizer-nochart-edit"><span class="dashicons dashicons-admin-generic"></span></span>';
357+
echo '<span class="visualizer-chart-action visualizer-nochart-edit"><span class="dashicons dashicons-edit"></span></span>';
358358
echo '</div>';
359359
echo '</div>';
360360
echo '</div></div>';
@@ -459,7 +459,7 @@ private function _renderChartBox( $placeholder_id, $chart_id, $with_filter = fal
459459
echo '<a class="visualizer-chart-action visualizer-chart-shortcode ' . esc_attr( $pro_class ) . '" href="javascript:;" data-clipboard-text="' . esc_attr( $shortcode ) . '"><span class="dashicons dashicons-shortcode ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Copy Shortcode', 'visualizer' ) . '</span></a>';
460460
echo '<a class="visualizer-chart-action visualizer-chart-export ' . esc_attr( $pro_class ) . '" href="javascript:;" data-chart="' . $export_link . '"><span class="dashicons dashicons-download ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Export CSV', 'visualizer' ) . '</span></a>';
461461
echo '<a class="visualizer-chart-action visualizer-chart-clone ' . esc_attr( $pro_class ) . '" href="' . $clone_url . '"><span class="dashicons dashicons-admin-page ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Duplicate', 'visualizer' ) . '</span></a>';
462-
echo '<a class="visualizer-chart-action visualizer-chart-edit ' . esc_attr( $pro_class ) . '" href="javascript:;" data-chart="' . esc_attr( (string) $chart_id ) . '"><span class="dashicons dashicons-admin-generic ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Edit', 'visualizer' ) . '</span></a>';
462+
echo '<a class="visualizer-chart-action visualizer-chart-edit ' . esc_attr( $pro_class ) . '" href="javascript:;" data-chart="' . esc_attr( (string) $chart_id ) . '"><span class="dashicons dashicons-edit ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Edit', 'visualizer' ) . '</span></a>';
463463
echo '</div></td>';
464464
echo '</tr>';
465465
return;
@@ -487,7 +487,7 @@ private function _renderChartBox( $placeholder_id, $chart_id, $with_filter = fal
487487
}
488488
echo '<a class="visualizer-chart-action visualizer-chart-export ' . esc_attr( $pro_class ) . '" href="javascript:;" data-chart="', $export_link, '"><span class="dashicons dashicons-download ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Export CSV', 'visualizer' ) . '</span></a>';
489489
echo '<a class="visualizer-chart-action visualizer-chart-clone ' . esc_attr( $pro_class ) . '" href="', $clone_url, '"><span class="dashicons dashicons-admin-page ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Duplicate', 'visualizer' ) . '</span></a>';
490-
echo '<a class="visualizer-chart-action visualizer-chart-edit ' . esc_attr( $pro_class ) . '" href="javascript:;" data-chart="', $chart_id, '"><span class="dashicons dashicons-admin-generic ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Edit', 'visualizer' ) . '</span></a>';
490+
echo '<a class="visualizer-chart-action visualizer-chart-edit ' . esc_attr( $pro_class ) . '" href="javascript:;" data-chart="', $chart_id, '"><span class="dashicons dashicons-edit ' . esc_attr( $pro_class ) . '"></span><span class="tooltip-text">' . esc_html__( 'Edit', 'visualizer' ) . '</span></a>';
491491
echo '</div>';
492492
do_action( 'visualizer_chart_languages', $chart_id );
493493
echo '<hr><div class="visualizer-chart-status"><span title="' . __( 'Chart ID', 'visualizer' ) . '">(' . $chart_id . '):</span> <span class="visualizer-date" title="' . __( 'Last Updated', 'visualizer' ) . '">' . $chart_status['date'] . '</span><span class="visualizer-error"><i class="dashicons ' . $chart_status['icon'] . '" data-viz-error="' . esc_attr( str_replace( '"', "'", $chart_status['error'] ) ) . '" title="' . esc_attr( $chart_status['title'] ) . '"></i></span></div>';
@@ -540,7 +540,7 @@ private function _renderSidebar() {
540540
if ( $this->_isListView() ) {
541541
$upgrade_url = tsdk_utmify( Visualizer_Plugin::PRO_TEASER_URL, 'sidebarMenuUpgrade', 'index' );
542542
$chart_types = Visualizer_Module_Admin::proFeaturesLocked() ? __( '6 more chart types', 'visualizer' ) : __( '11 more chart types', 'visualizer' );
543-
echo '<div class="items items--upsell">';
543+
echo '<div class="items--upsell">';
544544
echo '<div class="viz-upsell-banner">';
545545
echo '<span class="dashicons dashicons-star-filled viz-upsell-banner__icon"></span>';
546546
echo '<div class="viz-upsell-banner__text">';

‎css/library.css‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -696,10 +696,8 @@ span.viz-view-toggle-group {
696696
display: flex;
697697
align-items: center;
698698
gap: 12px;
699-
background: #f0f6fc;
700-
border: 1px solid #c3daf9;
699+
background: #fff;
701700
border-left: 4px solid #007CBA;
702-
border-radius: 4px;
703701
padding: 12px 16px;
704702
margin-bottom: 10px;
705703
}

0 commit comments

Comments
 (0)