Skip to content

Commit e41d7d6

Browse files
committed
fix: qa issues
1 parent f56181b commit e41d7d6

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

classes/Visualizer/Render/Layout.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@ class="dashicons dashicons-lock"></span></h2>
10491049
<?php
10501050
$is_wp_source = 'visualizer_source_query_wp' === $source_of_chart;
10511051
$hours = get_post_meta( $chart_id, Visualizer_Plugin::CF_DB_SCHEDULE, true );
1052-
$bttn_label = $is_wp_source ? __( '1. Modify Data Source', 'visualizer' ) : __( '1. Choose Data Source', 'visualizer' );
1052+
$bttn_label = $is_wp_source ? '1. ' . __( 'Modify Data Source', 'visualizer' ) : '1. ' . __( 'Choose Data Source', 'visualizer' );
10531053
?>
10541054

10551055
<!-- Step 1: Choose / modify data source -->
@@ -1058,7 +1058,7 @@ class="dashicons dashicons-lock"></span></h2>
10581058
<!-- Step 2: Sync schedule toggle -->
10591059
<div id="vz-wp-sync-step">
10601060
<button type="button" id="vz-wp-sync-btn" class="vz-import-step-toggle" aria-expanded="<?php echo $is_wp_source ? 'true' : 'false'; ?>">
1061-
<?php _e( '2. Set Sync Schedule', 'visualizer' ); ?>
1061+
<?php echo '2. ' . __( 'Set Sync Schedule', 'visualizer' ); ?>
10621062
<span class="dashicons dashicons-arrow-down-alt2"></span>
10631063
</button>
10641064
<div id="vz-wp-sync-options"<?php echo $is_wp_source ? '' : ' style="display:none"'; ?>>
@@ -1218,7 +1218,7 @@ class="dashicons dashicons-lock"></span></h2>
12181218
<!-- Step 2: Sync schedule toggle -->
12191219
<div id="vz-db-sync-step">
12201220
<button type="button" id="vz-db-sync-btn" class="vz-import-step-toggle" aria-expanded="<?php echo $is_db_source ? 'true' : 'false'; ?>">
1221-
<?php _e( '2. Set Sync Schedule', 'visualizer' ); ?>
1221+
<?php echo '2. ' . __( 'Set Sync Schedule', 'visualizer' ); ?>
12221222
<span class="dashicons dashicons-arrow-down-alt2"></span>
12231223
</button>
12241224
<div id="vz-db-sync-options"<?php echo $is_db_source ? '' : ' style="display:none"'; ?>>

js/frame.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,8 @@
371371
function init_filter_import() {
372372
$( '#db-filter-save-button' ).on( 'click', function(){
373373
$('#vz-filter-wizard').submit();
374+
$( '#vz-wp-sync-options' ).hide();
375+
$( '#vz-wp-sync-btn' ).attr( 'aria-expanded', false );
374376
});
375377
}
376378

@@ -452,11 +454,20 @@
452454
$( this ).attr( 'aria-expanded', ! isOpen );
453455
} );
454456

457+
$( document ).on( 'click', '#vz-wp-sync-btn', function(){
458+
var $options = $( '#vz-wp-sync-options' );
459+
var isOpen = $options.is( ':visible' );
460+
$options.toggle();
461+
$( this ).attr( 'aria-expanded', ! isOpen );
462+
} );
463+
455464
$( '#db-chart-save-button' ).on( 'click', function(){
456465
// submit only if a query has been provided.
457466
if($('#db-query-form .visualizer-db-query').val().length > 0){
458467
$('#viz-db-wizard-params').val($('#db-query-form').serialize());
459468
$('#vz-db-wizard').submit();
469+
$( '#vz-db-sync-options' ).hide();
470+
$( '#vz-db-sync-btn' ).attr( 'aria-expanded', false );
460471
}else{
461472
$('#canvas').unlock();
462473
}

0 commit comments

Comments
 (0)