Fix PHPStan type errors and coding standards

- Add @return void annotations to all methods
- Fix array type hints to array<string, mixed>
- Replace DOING_AJAX constant with wp_doing_ajax()
- Fix ini_set parameter type from int to string
- Remove error suppression operators (@)
- Remove unnecessary isset() check on explode() result

Author: vytisbulkevicius

classes/Visualizer/Module/AI.php

@@ -55,10 +55,11 @@ public function __construct( Visualizer_Plugin $plugin ) {
 	 * @since 3.12.0
 	 *
 	 * @access public
+	 * @return void
 	 */
 	public function suppressAjaxWarnings() {
-		if ( defined( 'DOING_AJAX' ) && DOING_AJAX ) {
-			@ini_set( 'display_errors', '0' );
+		if ( wp_doing_ajax() ) {
+			ini_set( 'display_errors', '0' );
 		}
 	}
 
@@ -68,6 +69,7 @@ public function suppressAjaxWarnings() {
 	 * @since 3.12.0
 	 *
 	 * @access public
+	 * @return void
 	 */
 	public function generateConfiguration() {
 		error_log( 'Visualizer AI: generateConfiguration called' );
@@ -119,10 +121,11 @@ public function generateConfiguration() {
 	 * @since 3.12.0
 	 *
 	 * @access public
+	 * @return void
 	 */
 	public function analyzeChartImage() {
 		// Prevent any output before JSON response
-		@ini_set( 'display_errors', 0 );
+		ini_set( 'display_errors', '0' );
 		while ( ob_get_level() ) {
 			ob_end_clean();
 		}
@@ -178,13 +181,13 @@ public function analyzeChartImage() {
 	 *
 	 * @access private
 	 *
-	 * @param string $model The AI model to use.
-	 * @param string $prompt The user prompt.
-	 * @param string $chart_type The chart type.
-	 * @param array  $chat_history Previous conversation history.
-	 * @param string $current_config Current manual configuration.
+	 * @param string                $model The AI model to use.
+	 * @param string                $prompt The user prompt.
+	 * @param string                $chart_type The chart type.
+	 * @param array<string, mixed>  $chat_history Previous conversation history.
+	 * @param string                $current_config Current manual configuration.
 	 *
-	 * @return array|WP_Error The response with message and optional configuration.
+	 * @return array<string, mixed>|WP_Error The response with message and optional configuration.
 	 */
 	private function _callAIModel( $model, $prompt, $chart_type, $chat_history = array(), $current_config = '' ) {
 		switch ( $model ) {
@@ -318,12 +321,12 @@ private function _getChartTypeOptions( $chart_type ) {
 	 *
 	 * @access private
 	 *
-	 * @param string $prompt The user prompt.
-	 * @param string $chart_type The chart type.
-	 * @param array  $chat_history Previous conversation history.
-	 * @param string $current_config Current manual configuration.
+	 * @param string                $prompt The user prompt.
+	 * @param string                $chart_type The chart type.
+	 * @param array<string, mixed>  $chat_history Previous conversation history.
+	 * @param string                $current_config Current manual configuration.
 	 *
-	 * @return array|WP_Error The response with message and optional configuration.
+	 * @return array<string, mixed>|WP_Error The response with message and optional configuration.
 	 */
 	private function _callOpenAI( $prompt, $chart_type, $chat_history = array(), $current_config = '' ) {
 		error_log( 'Visualizer AI: Calling OpenAI API' );
@@ -420,12 +423,12 @@ private function _callOpenAI( $prompt, $chart_type, $chat_history = array(), $cu
 	 *
 	 * @access private
 	 *
-	 * @param string $prompt The user prompt.
-	 * @param string $chart_type The chart type.
-	 * @param array  $chat_history Previous conversation history.
-	 * @param string $current_config Current manual configuration.
+	 * @param string                $prompt The user prompt.
+	 * @param string                $chart_type The chart type.
+	 * @param array<string, mixed>  $chat_history Previous conversation history.
+	 * @param string                $current_config Current manual configuration.
 	 *
-	 * @return array|WP_Error The response with message and optional configuration.
+	 * @return array<string, mixed>|WP_Error The response with message and optional configuration.
 	 */
 	private function _callGemini( $prompt, $chart_type, $chat_history = array(), $current_config = '' ) {
 		$api_key = get_option( 'visualizer_gemini_api_key', '' );
@@ -498,12 +501,12 @@ private function _callGemini( $prompt, $chart_type, $chat_history = array(), $cu
 	 *
 	 * @access private
 	 *
-	 * @param string $prompt The user prompt.
-	 * @param string $chart_type The chart type.
-	 * @param array  $chat_history Previous conversation history.
-	 * @param string $current_config Current manual configuration.
+	 * @param string                $prompt The user prompt.
+	 * @param string                $chart_type The chart type.
+	 * @param array<string, mixed>  $chat_history Previous conversation history.
+	 * @param string                $current_config Current manual configuration.
 	 *
-	 * @return array|WP_Error The response with message and optional configuration.
+	 * @return array<string, mixed>|WP_Error The response with message and optional configuration.
 	 */
 	private function _callClaude( $prompt, $chart_type, $chat_history = array(), $current_config = '' ) {
 		$api_key = get_option( 'visualizer_claude_api_key', '' );
@@ -583,7 +586,7 @@ private function _callClaude( $prompt, $chart_type, $chat_history = array(), $cu
 	 *
 	 * @param string $text The AI response text.
 	 *
-	 * @return array The parsed response with message and optional configuration.
+	 * @return array<string, mixed> The parsed response with message and optional configuration.
 	 */
 	private function _parseResponse( $text ) {
 		error_log( 'Visualizer AI: Parsing response: ' . substr( $text, 0, 200 ) . '...' );
@@ -661,7 +664,7 @@ private function _parseResponse( $text ) {
 	 * @param string $model The AI model to use.
 	 * @param string $image_data Base64 encoded image data.
 	 *
-	 * @return array|WP_Error The analysis result or WP_Error on failure.
+	 * @return array<string, mixed>|WP_Error The analysis result or WP_Error on failure.
 	 */
 	private function _analyzeChartImageWithAI( $model, $image_data ) {
 		error_log( 'Visualizer AI: Analyzing image with model: ' . $model );
@@ -687,7 +690,7 @@ private function _analyzeChartImageWithAI( $model, $image_data ) {
 	 *
 	 * @param string $image_data Base64 encoded image data.
 	 *
-	 * @return array|WP_Error The analysis result or WP_Error on failure.
+	 * @return array<string, mixed>|WP_Error The analysis result or WP_Error on failure.
 	 */
 	private function _analyzeImageWithOpenAI( $image_data ) {
 		error_log( 'Visualizer AI: Analyzing image with OpenAI Vision' );
@@ -806,7 +809,7 @@ private function _analyzeImageWithOpenAI( $image_data ) {
 	 *
 	 * @param string $image_data Base64 encoded image data.
 	 *
-	 * @return array|WP_Error The analysis result or WP_Error on failure.
+	 * @return array<string, mixed>|WP_Error The analysis result or WP_Error on failure.
 	 */
 	private function _analyzeImageWithGemini( $image_data ) {
 		error_log( 'Visualizer AI: Analyzing image with Gemini Vision' );
@@ -920,7 +923,7 @@ private function _analyzeImageWithGemini( $image_data ) {
 	 *
 	 * @param string $image_data Base64 encoded image data.
 	 *
-	 * @return array|WP_Error The analysis result or WP_Error on failure.
+	 * @return array<string, mixed>|WP_Error The analysis result or WP_Error on failure.
 	 */
 	private function _analyzeImageWithClaude( $image_data ) {
 		error_log( 'Visualizer AI: Analyzing image with Claude Vision' );
@@ -937,7 +940,7 @@ private function _analyzeImageWithClaude( $image_data ) {
 
 		// Detect media type from data URL
 		$media_type = 'image/jpeg';
-		if ( isset( $image_parts[0] ) && preg_match( '/data:(image\/[^;]+)/', $image_parts[0], $matches ) ) {
+		if ( preg_match( '/data:(image\/[^;]+)/', $image_parts[0], $matches ) ) {
 			$media_type = $matches[1];
 		}
 
@@ -1050,7 +1053,7 @@ private function _analyzeImageWithClaude( $image_data ) {
 	 *
 	 * @param string $text The AI response text.
 	 *
-	 * @return array The parsed result with chart_type, title, csv_data, and styling.
+	 * @return array<string, mixed> The parsed result with chart_type, title, csv_data, and styling.
 	 */
 	private function _parseImageAnalysisResponse( $text ) {
 		error_log( 'Visualizer AI: Parsing image analysis response' );

classes/Visualizer/Module/Chart.php

@@ -1194,7 +1194,7 @@ private function handleTabularData() {
 	 */
 	public function uploadData() {
 		// Prevent any PHP warnings/errors from contaminating the response
-		@ini_set( 'display_errors', '0' );
+		ini_set( 'display_errors', '0' );
 
 		// if this is being called internally from pro and VISUALIZER_DO_NOT_DIE is set.
 		// otherwise, assume this is a normal web request.

classes/Visualizer/Render/Page/AISettings.php

@@ -58,6 +58,7 @@ private function _maskAPIKey( $key ) {
 	 * @since 3.12.0
 	 *
 	 * @access protected
+	 * @return void
 	 */
 	protected function _renderContent() {
 		echo '<div class="wrap">';
@@ -199,6 +200,7 @@ protected function _renderContent() {
 	 * @since 3.12.0
 	 *
 	 * @access private
+	 * @return void
 	 */
 	private function _saveSettings() {
 		if ( isset( $_POST['visualizer_openai_api_key'] ) ) {

classes/Visualizer/Render/Sidebar.php

@@ -844,6 +844,7 @@ protected function _renderChartControlsSettings() {
 	 * Renders AI Configuration group.
 	 *
 	 * @access protected
+	 * @return void
 	 */
 	protected function _renderAIConfigurationGroup() {
 		// Check if PRO features are locked