ENH: generalize signature of `cached` functions #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

pre-commit-ci wants to merge 46 commits into main from pre-commit-ci-update-config

.cspell.json

-Original file line number
+Diff line change
@@ Expand Up / @@ -25,6 +25,7 @@ @@
         "*.ico",
         ".editorconfig",
         ".envrc",
+        ".github/dependabot.yml",
         ".gitignore",
         ".pre-commit-config.yaml",
         ".prettierignore",
@@ Expand All / @@ -40,7 +41,6 @@ @@
       "ignoreWords": [
         "Autoupdate",
         "Dalitzplot",
-        "MAINT",
         "Minkowski",
         "PYDEVD",
         "adrs",
@@ Expand All / @@ -53,6 +53,8 @@ @@
         "automodule",
         "axhline",
         "axvline",
+        "backend_nbagg",
+        "bbox",
         "bbox_to_anchor",
         "bdist",
         "bgcolor",
@@ Expand All / @@ -71,7 +73,6 @@ @@
         "compwa",
         "concat",
         "conds",
-        "coolwarm",
         "displaystyle",
         "dlink",
         "docnb",
@@ Expand Down Expand Up / @@ -109,6 +110,7 @@ @@
         "imag",
         "iplt",
         "ipykernel",
+        "ipympl",
         "ipyplot",
         "ipywidgets",
         "isfunction",
@@ Expand Down Expand Up / @@ -171,9 +173,9 @@ @@
         "pylance",
         "pypi",
         "pyproject",
-        "pyright",
         "pytestconfig",
         "rankdir",
+        "relim",
         "repr",
         "richman",
         "rightarrow",
@@ Expand All / @@ -189,10 +191,10 @@ @@
         "sympifiable",
         "sympified",
         "sympify",
-        "symplot",
         "theano",
         "ticklabels",
         "tolist",
+        "tqdm",
         "unparse",
         "unsrt",
         "untracked",
@@ Expand All / @@ -211,6 +213,7 @@ @@
         "xticks",
         "xytext",
         "yaxis",
+        "ydata",
         "ylabel",
         "ylim",
         "yticks"
@@ Expand Down Expand Up / @@ -267,7 +270,6 @@ @@
         "mathbb",
         "matplotlib",
         "Mikhasenko",
-        "mypy",
         "nishijima",
         "numpy",
         "parametrizations",
@@ Expand Down @@

.github/dependabot.yml

-Original file line number
+Diff line change
@@ -0,0 +1,19 @@
+    version: 2
+    multi-ecosystem-groups:
+      lock:
+        assignees: [redeboer]
+        commit-message: { prefix: MAINT }
+        schedule: { interval: quarterly }
+    updates:
+      - package-ecosystem: github-actions
+        directory: "/"
+        labels: [⬆️ Lock]
+        multi-ecosystem-group: lock
+        patterns: ["*"]
+      - package-ecosystem: uv
+        directory: "/"
+        labels: [⬆️ Lock]
+        multi-ecosystem-group: lock
+        patterns: ["*"]

.github/workflows/benchmark.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -12,45 +12,21 @@ on:
  
          - main

          - epic/*

      workflow_dispatch:

        inputs:

          specific-pip-packages:

            description: Run benchmarks with specific pip packages

            required: false

            type: string

    jobs:

      benchmark:

        name: Performance regression

        runs-on: ubuntu-24.04

        steps:

          - uses: actions/checkout@v4

          - uses: actions/checkout@v6

            with:

              fetch-depth: 0

          - uses: actions/setup-python@v5

          - uses: actions/setup-python@v6

            with:

              python-version: "3.13"

          - uses: astral-sh/setup-uv@v5

          - id: with

            if: inputs.specific-pip-packages

            name: Determine additional packages to install

            run: |

              additional_packages=''

              for package in ${{ inputs.specific-pip-packages }}; do

                additional_packages="$additional_packages --with $package"

              done

              echo "packages=$additional_packages" | tee -a $GITHUB_OUTPUT

          - uses: astral-sh/setup-uv@v7

          - name: Run pytest-benchmark

            run: |

              uv run \

                --all-extras \

                --group test \

                --no-dev \

                ${{ steps.with.outputs.packages }} \

                pytest \

                  -k benchmark \

                  --benchmark-json output.json \

                  --durations=0

            working-directory: benchmarks

            run: uvx --from poethepoet poe benchmark

          - name: Warn on performance decrease

            if: github.event_name == 'pull_request'

            uses: benchmark-action/github-action-benchmark@v1

.github/workflows/cd.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -9,9 +9,9 @@ on:
  
    jobs:

      milestone:

        if: startsWith(github.ref, 'refs/tags')

        uses: ComPWA/actions/.github/workflows/close-milestone.yml@v3

        uses: ComPWA/actions/.github/workflows/close-milestone.yml@v4

      package-name:

        uses: ComPWA/actions/.github/workflows/get-pypi-name.yml@v3

        uses: ComPWA/actions/.github/workflows/get-pypi-name.yml@v4

      pypi:

        environment:

          name: PyPI

    @@ -24,9 +24,9 @@ jobs:
  
          id-token: write

        runs-on: ubuntu-24.04

        steps:

          - uses: ComPWA/actions/build-pypi-distribution@v3

          - uses: ComPWA/actions/build-pypi-distribution@v4

          - uses: pypa/gh-action-pypi-publish@release/v1

      push:

        if: startsWith(github.ref, 'refs/tags') && !github.event.release.prerelease

        secrets: inherit

        uses: ComPWA/actions/.github/workflows/push-to-version-branches.yml@v3

        uses: ComPWA/actions/.github/workflows/push-to-version-branches.yml@v4

.github/workflows/ci-qrules-v0.9.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -22,13 +22,13 @@ jobs:
  
        name: Run unit tests

        runs-on: ubuntu-24.04

        steps:

          - uses: actions/checkout@v4

          - uses: actions/checkout@v6

            with:

              fetch-depth: 0

          - uses: actions/setup-python@v5

          - uses: actions/setup-python@v6

            with:

              python-version: "3.13"

          - uses: astral-sh/setup-uv@v5

          - uses: astral-sh/setup-uv@v7

          - name: Run pytest with QRules v0.9

            run: |

              uv run \

.github/workflows/ci.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,31 +17,23 @@ on: @@
           - epic/*
           - "[0-9]+.[0-9]+.x"
       workflow_dispatch:
-        inputs:
-          specific-pip-packages:
-            description: Run CI with specific pip packages
-            required: false
-            type: string
     jobs:
       doc:
-        uses: ComPWA/actions/.github/workflows/ci-docs.yml@v3.0
+        uses: ComPWA/actions/.github/workflows/ci-docs.yml@v4.0
         permissions:
           pages: write
           id-token: write
         with:
           apt-packages: graphviz
-          specific-pip-packages: ${{ inputs.specific-pip-packages }}
-      pytest:
-        uses: ComPWA/actions/.github/workflows/pytest.yml@v3.0
-        with:
-          coverage-target: ampform
-          macos-python-version: "3.10"
-          specific-pip-packages: ${{ inputs.specific-pip-packages }}
-        secrets:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
       style:
-        if: inputs.specific-pip-packages == ''
         secrets:
           token: ${{ secrets.PAT }}
-        uses: ComPWA/actions/.github/workflows/pre-commit.yml@v3.0
+        uses: ComPWA/actions/.github/workflows/style.yml@v4.0
+      test:
+        uses: ComPWA/actions/.github/workflows/test.yml@v4.0
+        secrets:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+        with:
+          coverage-python-version: "3.13"
+          macos-python-version: "3.10"

.github/workflows/clean-caches.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -14,9 +14,9 @@ on:
  
    jobs:

      cleanup:

        name: Remove caches

        runs-on: ubuntu-24.04

        runs-on: ubuntu-slim

        steps:

          - uses: ComPWA/actions/clean-caches@v3

          - uses: ComPWA/actions/clean-caches@v4

            with:

              GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

              ref: ${{ inputs.ref }}

.github/workflows/lock.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,6 +17,6 @@ on: @@
     jobs:
       lock:
-        uses: ComPWA/actions/.github/workflows/lock.yml@v3
+        uses: ComPWA/actions/.github/workflows/lock.yml@v4
         secrets:
           token: ${{ secrets.PAT }}

.github/workflows/pr-linting.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -11,4 +11,4 @@ on: @@
     jobs:
       lint-pr:
-        uses: ComPWA/actions/.github/workflows/pr-linting.yml@v3
+        uses: ComPWA/actions/.github/workflows/pr-linting.yml@v4

.github/workflows/redirect-gh-pages.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -7,7 +7,7 @@ on:
  
    jobs:

      build:

        runs-on: ubuntu-24.04

        runs-on: ubuntu-slim

        steps:

          - name: Build redirect page

            id: build

    @@ -26,7 +26,7 @@ jobs:
  
              </body>

              </html>' > build/index.html

          - id: deployment

            uses: actions/upload-pages-artifact@v3

            uses: actions/upload-pages-artifact@v4

            with:

              path: build/

.github/workflows/release-drafter.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,7 @@ on: @@
     jobs:
       update_release_draft:
-        runs-on: ubuntu-24.04
+        runs-on: ubuntu-slim
         steps:
           - uses: release-drafter/release-drafter@v6
             env:
@@ Expand Down @@

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,6 @@ version.py @@
     .coverage.*
     .ipynb_checkpoints/
     .jupyter_ystore.db
-    .mypy*/
     .pytest_cache/
     .virtual_documents/
     __pycache__/
@@ Expand All / @@ -50,4 +49,3 @@ pyvenv*/ @@
     !.vscode/*.json
     !.zenodo.json
     !codecov.yml
-    !pyrightconfig.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: generalize signature of `cached` functions #485

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

ENH: generalize signature of cached functions #485

Are you sure you want to change the base?

Uh oh!

ENH: generalize signature of cached functions #485

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

ENH: generalize signature of `cached` functions #485

ENH: generalize signature of `cached` functions #485