Skip to content

Including the states check in Machine execution#1

Open
gulshang wants to merge 3 commits into
Coverfox:masterfrom
gulshang:master
Open

Including the states check in Machine execution#1
gulshang wants to merge 3 commits into
Coverfox:masterfrom
gulshang:master

Conversation

@gulshang
Copy link
Copy Markdown

No description provided.

Comment thread transitions/core.py Outdated
class NonTransition(Transition):

def __init__(self, conditions=None, unless=None, before=None, after=None):
def __init__(self, states=[], conditions=None, unless=None, before=None, after=None):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this states=None.

Comment thread transitions/core.py Outdated
event = EventData(self.machine.current_state, self, self.machine,
self.machine.model, args=args, kwargs=kwargs)
for nt in self.non_transitions:
if self.machine.current_state not in nt.states:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, handle this using add_non_transition method.

@gulshang
Copy link
Copy Markdown
Author

gulshang commented Nov 1, 2016

@sanketrathi Changes done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants