fix: refactor thing API to improve endpoint structure and initialization logic

Author: jirhiker

api/thing.py

@@ -299,7 +299,6 @@ async def get_things(
     user: viewer_dependency,
     session: session_dependency,
     # thing_id: int = None,
-    thing_type: str = None,
     within: str = None,
     query: str = None,
     sort: str = None,
@@ -320,7 +319,6 @@ async def get_things(
         session,
         sort,
         within=within,
-        thing_type=thing_type,
     )
 
 

tests/features/steps/api_fixture.py

@@ -37,18 +37,17 @@
     Thing,
     LocationThingAssociation,
     Sensor,
-    LexiconTerm,
     Group,
     GroupThingAssociation,
 )
 from db.engine import session_ctx
 
 with session_ctx() as session:
-    if session.query(LexiconTerm).count() == 0:
-        erase_and_rebuild_db(session)
+    # if session.query(LexiconTerm).count() == 0:
+    erase_and_rebuild_db(session)
 
-        init_lexicon()
-        init_parameter()
+    init_lexicon()
+    init_parameter()
 
 
 def add_location(lid):

tests/features/steps/thing-query.py tests/features/steps/thing-path.pytests/features/steps/thing-query.py renamed to tests/features/steps/thing-path.py

@@ -19,7 +19,7 @@
 
 @when('the user requests things with type "water well"')
 def step_impl(context):
-    context.response = context.client.get("/thing", params={"thing_type": "water well"})
+    context.response = context.client.get("/thing/water-well")
 
 
 @then("the response should include at least one thing")
@@ -37,7 +37,7 @@ def step_impl(context):
 
 @when('the user requests things with type "spring"')
 def step_impl(context):
-    context.response = context.client.get("/thing", params={"thing_type": "spring"})
+    context.response = context.client.get("/thing/spring")
 
 
 @then('the response should only include things of type "spring"')