feat: refactor app initialization to import from main module

Author: jirhiker

core/app.py

@@ -24,10 +24,6 @@
 )
 from fastapi.openapi.utils import get_openapi
 
-from .initializers import (
-    register_routes,
-    erase_and_rebuild_db,
-)
 from .settings import settings
 
 
@@ -41,7 +37,6 @@ async def lifespan(app: FastAPI) -> AsyncGenerator[None, None]:
 
         seed_all(10, skip_if_exists=True)
 
-    register_routes(app)
     yield
 
 

tests/__init__.py

@@ -28,25 +28,10 @@
 os.environ["POSTGRES_DB"] = "ocotilloapi_test"
 
 from fastapi.testclient import TestClient
-from fastapi_pagination import add_pagination
-from starlette.middleware.cors import CORSMiddleware
 
-from core.initializers import register_routes
 from db import Parameter, Base
 from db.engine import session_ctx
-from core.app import app
-
-register_routes(app)
-
-app.add_middleware(
-    CORSMiddleware,
-    allow_origins=["*"],  # Allows all origins, adjust as needed for security
-    allow_credentials=True,
-    allow_methods=["*"],
-    allow_headers=["*"],
-)
-
-add_pagination(app)
+from main import app
 
 client = TestClient(app)
 

tests/features/steps/api_common.py

@@ -21,7 +21,6 @@
     admin_function,
     amp_admin_function,
 )
-from core.initializers import register_routes
 from starlette.testclient import TestClient
 
 
@@ -31,9 +30,7 @@ def step_given_api_is_running(context):
     Ensures the API app is initialized and client is ready.
     Behave will keep 'context' across steps, allowing us to reuse response data.
     """
-    from core.app import app
-
-    register_routes(app)
+    from main import app
 
     def override_authentication(default=True):
         """

tests/features/steps/cli_common.py

@@ -23,7 +23,6 @@
     admin_function,
     amp_admin_function,
 )
-from core.initializers import register_routes
 
 
 @given("a functioning cli")
@@ -32,9 +31,7 @@ def step_given_cli_is_running(context):
     Initializes app/auth context needed by CLI-backed feature tests
     that still perform DB-backed assertions.
     """
-    from core.app import app
-
-    register_routes(app)
+    from main import app
 
     def override_authentication(default=True):
         def closure():

tests/test_asset.py

@@ -19,7 +19,7 @@
 import pytest
 
 from api.asset import get_storage_bucket
-from core.app import app
+from main import app
 from core.dependencies import viewer_function, admin_function, editor_function
 from db import Asset
 from schemas import DT_FMT