fix(well inventory): check for Nones to avoid truthiness traps

jacob-a-brown · jacob-a-brown · commit aac5c9521d4f · 2026-03-18T14:52:00.000-06:00
diff --git a/services/well_inventory_csv.py b/services/well_inventory_csv.py
@@ -837,7 +837,7 @@ def _add_csv_row(session: Session, group: Group, model: WellInventoryRow, user)
         session.add(sample)
         session.flush()
 
-        if model.depth_to_water_ft and not universal_mp_height:
+        if model.depth_to_water_ft is not None and universal_mp_height is None:
             raise ValueError(
                 "measuring_point_height_ft or mp_height is required when depth_to_water_ft is provided for a non-null observation"
             )

Original file line number	Diff line number	Diff line change
`@@ -837,7 +837,7 @@ def _add_csv_row(session: Session, group: Group, model: WellInventoryRow, user)`
`837`	`837`	`session.add(sample)`
`838`	`838`	`session.flush()`
`839`	`839`
`840`		`- if model.depth_to_water_ft and not universal_mp_height:`
	`840`	`+ if model.depth_to_water_ft is not None and universal_mp_height is None:`
`841`	`841`	`raise ValueError(`
`842`	`842`	`"measuring_point_height_ft or mp_height is required when depth_to_water_ft is provided for a non-null observation"`
`843`	`843`	`)`