fix: remove deprecated transducer groundwater level endpoint and update related tests

Author: jirhiker

.github/workflows/tests.yml

@@ -86,7 +86,12 @@ jobs:
         DB_DRIVER: postgres
         BASE_URL: http://localhost:8000
       run: |
-        uv run behave tests/features --tags="@backend and @production" --no-capture
+#        use this when we have consensus on tag nomenclature
+#        uv run behave tests/features --tags="@backend and @production" --no-capture
+#
+         uv run behave tests/features/transducer-data-response.feature \
+             tests/features/thing-type-path-parameters.feature \
+             tests/features/thing-query-parameters.feature
 
     - name: Upload results to Codecov
       uses: codecov/codecov-action@v4

api/observation.py

@@ -122,7 +122,6 @@ async def get_transducer_groundwater_level_observations(
     session: session_dependency,
     user: amp_viewer_dependency,
     thing_id: int,
-    # parameter_id: int | None = None,
     start_time: datetime | None = None,
     end_time: datetime | None = None,
 ) -> CustomPage[TransducerObservationWithBlockResponse]:
@@ -139,24 +138,6 @@ async def get_transducer_groundwater_level_observations(
     )
 
 
-@router.get(
-    "/transducer-groundwater-level",
-    summary="Get transducer groundwater level observations",
-)
-async def get_transducer_groundwater_level_observations(
-    request: Request,
-    session: session_dependency,
-    user: amp_viewer_dependency,
-    thing_id: int | None = None,
-    parameter_id: int | None = None,
-    start_time: datetime | None = None,
-    end_time: datetime | None = None,
-) -> CustomPage[TransducerObservationWithBlockResponse]:
-    return get_transducer_observations(
-        session, thing_id, parameter_id, start_time, end_time
-    )
-
-
 @router.get("/groundwater-level", summary="Get groundwater level observations")
 async def get_groundwater_level_observations(
     request: Request,

tests/features/steps/transducer.py

@@ -84,12 +84,12 @@ def step_impl(context):
     assert isinstance(context.value, (int, float))
 
 
-@then('the status should be one of "Draft", "Corrected"')
+@then('the status should be one of "approved", "not reviewed"')
 def step_impl(context):
     assert context.status in (
-        "Draft",
-        "Corrected",
-    ), f'Unexpected status: {context.status} not in "Draft", "Corrected"'
+        "approved",
+        "not reviewed",
+    ), f'Unexpected status: {context.status} not in "approved", "not reviewed"'
 
 
 # ============= EOF =============================================

tests/test_observation.py

@@ -211,6 +211,7 @@ def test_patch_water_chemistry_observation_404_wrong_activity_type(
 # ============= Get tests =================
 
 
+@pytest.mark.skip(reason="No longer supported")
 def test_get_transducer_observations():
     response = client.get("/observation/transducer-groundwater-level")
     assert response.status_code == 200