Ability to apply custom query

[dayio]

Hi,

Thanks for this plugin, i currently have an issue with multi tenancy and global scopes as the .

For instance in the multi tenant mode i have a middleware that apply a global scope in order to prevent ajax requests to fetch other users in the select.

And when i want to switch to a different user from another entity i get a 404 because i'm still in the current entity

The workaround I've found is to add directly the withoutGlobalScope in src/FilamentDevelopersLogin.php

$model = (new ($plugin->getModelClass()))
    ->withoutGlobalScope('user_team') // <--- here
    ->where($plugin->getColumn(), $credentials)
    ->first();

But maybe some people will have another issue with this.

I don't know if a good way is to allow to add custom query builder clauses alongside the already present where($plugin->getColumn(), $credentials) or to make something that can replace it entirely.

With something like $plugin->getModelQuery() and in the PanelProvider use it like that

FilamentDeveloperLoginsPlugin::make()
  ->users(fn() => User::withoutGlobalScope('user_team')->pluck('email', 'name')->toArray())
  ->getModelQuery(fn(Builder $query) => $query->withoutGlobalScope('user_team')) // <--- here
  ->enabled(app()->environment('local'))

What do you think ?

Thanks,

Alex

[bramr94]

So, if I understand your problem correctly, it is that you cannot log in to certain users because they belong to a different team. And you have a global scope to make sure users cannot retrieve users from another team.

I think it is a good solution to add clauses to the existing query, so not only global scopes can be disabled, but we also tackle other cases. Maybe something like a appendClause method?

$model = (new ($plugin->getModelClass()))
            ->where($plugin->getColumn(), $credentials)
            ->when(! is_null($plugin->getAppendedClauses, function (Builder $query) {
                $query->...
            })
            ->first();

@dododedodonl What do you think?

[dayio]

Exactly, i think there is other ways to do it like not making a global scope and only applying a scope on the select but as we can customize the users and the model it could be great to customise also how the selected user is fetched.

The getAppendedClauses method is good because it keep the original behavior.

So if you have a certain behavior or scope on the user list, you can also apply it on the selected user you want to switch in.

[dododedodonl]

@bramr94 That would be a good solution. Another approach would be to put it all in a customizable closure on the plugin, so everything can be customized, eg. something like

$model = ($plugin->getModelCallback())($plugin, $credentials)->first();

// getModelCallback would be something like this by default
public function getModelCallback(): \Closure
{
    return $this->modelCallback ?? fn ($plugin, $credentials) => (new $plugin->getModelClass())->where($plugin->getColumn(), $credentials);
}