Skip to content

Commit 494354e

Browse files
Fix service unchanged event creation
1 parent b335fc3 commit 494354e

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

hello/discoverer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def _create_event(self, group: Group, matcher: ServiceMatcher, stored: Service |
142142
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UPDATED)
143143
else:
144144
log.debug('Service unchanged', group=group, service=service)
145-
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UPDATED)
145+
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UNCHANGED)
146146
else:
147147
log.info('Service discovered', group=group, service=service)
148148
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.DISCOVERED)

tests/defaultDiscovererTest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from hello import Service, Group, ServiceQuery, DefaultDiscoverer, Sender, Receiver, OnDiscoveryEvent, \
1010
DiscoveryEventType, DiscoveryEvent
1111

12-
1312
GROUP = Group('test-group', 'udp://239.0.0.1:5555')
1413
SERVICE_QUERY = ServiceQuery('test-.*', 'test-.*')
1514
SERVICE = Service(
@@ -185,15 +184,16 @@ def test_does_not_call_handler_when_service_not_changed(self):
185184
discoverer = DefaultDiscoverer(sender, receiver)
186185
discoverer.start(GROUP, SERVICE_QUERY)
187186
handler = MagicMock(spec=OnDiscoveryEvent)
188-
discoverer.register(handler)
187+
discoverer.register(handler, {DiscoveryEventType.DISCOVERED, DiscoveryEventType.UPDATED})
189188
discoverer._handle_message(SERVICE.to_dict())
190189
handler.reset_mock()
191190

192191
# When
193192
discoverer._handle_message(SERVICE.to_dict())
194193

195194
# Then
196-
handler.assert_not_called()
195+
with self.assertRaises(AssertionError):
196+
wait_for_assertion(0.1, lambda: handler.assert_called())
197197

198198
def test_handles_handler_error_gracefully(self):
199199
# Given

0 commit comments

Comments
 (0)