Skip to content
This repository was archived by the owner on Feb 27, 2025. It is now read-only.
This repository was archived by the owner on Feb 27, 2025. It is now read-only.

pass membership to is_valid_cert #3918

@tbro

Description

@tbro

See coment #3867 (comment) and zullip discussion.

  • is_valid_cert should take a type implementing Membershipas input
  • the is_valid_cert impl should directly call the threshold/stake table it needs from Membership (stake_table/success, stake_table/upgrade or da_stake_table/da_success). I think CERT::stake_table and CERT::threshold might be available for this, but maybe these should be on Voteable? haven't fully thought through this
  • the build_cert function in testing looks fine, but worth a double-check
    I might be mixing some things up here, but basically we want to make sure anything directly taking a stake_table or threshold is refactored to only take a Membership, where possible. I think this should be a fairly small refactor but should add a lot of safety

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions