Migrate from pydantic v1 to v2

[max-tet]

Summary

The codebase currently uses pydantic v1 (evidenced by pydantic.error_wrappers.ValidationError and .dict() calls). Pydantic v1 is end-of-life. Migrate to pydantic v2.

Motivation

• Pydantic v1 is no longer maintained
• Prerequisite for Replace gconf with pydantic-settings #41 (replace gconf with pydantic-settings v2)
• Several test failures are related to pydantic v1 incompatibilities (e.g. @property fields causing 'property' object is not iterable in .dict())

Scope

• Update pydantic dependency to v2
• Replace deprecated APIs:
  • .dict() → .model_dump()
  • .json() → .model_dump_json()
  • .parse_obj() → .model_validate()
  • validator → field_validator
  • pydantic.error_wrappers.ValidationError → pydantic.ValidationError
• Fix any model definitions that rely on v1 behavior (e.g. orm_mode → from_attributes)
• Update shard_core/data_model/backend/shard_model.py which has @property fields that break v1's .dict()

🤖 Generated with Claude Code

[ClaydeCode]

Preliminary Plan: Migrate from Pydantic v1 to v2

Overview

The codebase has ~31 files using pydantic v1. Most changes are mechanical API replacements, but a few require care:

Mechanical changes across many files:

• .dict() → .model_dump()
• .json() → .model_dump_json()
• .parse_obj() → .model_validate()
• @validator → @field_validator
• @root_validator → @model_validator
• pydantic.error_wrappers.ValidationError → pydantic.ValidationError
• class Config: orm_mode = True → model_config = ConfigDict(from_attributes=True)

Trickier changes:

• PropertyBaseModel in data_model/util.py — will replace with pydantic v2's native @computed_field decorator on all affected models.
• Update pyproject.toml: pydantic==1.* → pydantic>=2,<3
• Backend models in data_model/backend/ are copied from freeshard_controller and must not be modified. Verified: they only use BaseModel with no v1-specific APIs, so they are already v2-compatible.
• Run uv run pytest to verify currently-passing tests still pass (not required to fix currently-failing tests).

---

This looks like a large issue. React with 👍 to approve this preliminary plan and proceed to a thorough implementation plan.

[max-tet]

Answers:

1. Yes, please replace with @computed_field if equivalent in these cases.
2. Yes, the backend models are copied from the freeshard_controller repo. It depends on pydantic without a version specifier, so I guess it should be v2. Verify that. Keep in mind that the backend models must not be modified.

Also, there are some tests currently failing. If your work fixes some of them, good, but the important thing is that the tests that are currently passing are also passing after the change.

[ClaydeCode]

Plan updated. Incorporated feedback from max-tet:

1. @computed_field for PropertyBaseModel: Confirmed — will replace PropertyBaseModel with pydantic v2's native @computed_field decorator.
2. Backend models (copied from freeshard_controller): Verified — all backend models only use BaseModel with no v1-specific APIs (no .dict(), @validator, orm_mode, etc.), so they are already v2-compatible. No changes needed to these files, and the constraint to not modify them is easy to satisfy.
3. Failing tests: Will leave currently-failing tests as-is; the goal is to not break currently-passing tests.

[ClaydeCode]

Implementation Plan

Migrate from Pydantic v1 to v2

Summary

The codebase pins pydantic==1.* and uses v1-specific APIs throughout. This migration updates the dependency to pydantic>=2,<3 and replaces all deprecated APIs. No functional behavior should change — the goal is compatibility, not refactoring.

---

Affected Files

Dependency: pyproject.toml — update pydantic version pin.

Data models (require most changes):

• shard_core/data_model/util.py — delete PropertyBaseModel entirely; replace with pydantic v2's @computed_field
• shard_core/data_model/identity.py — migrate PropertyBaseModel usage to @computed_field, update @validator, update Config.fields for exclusion
• shard_core/data_model/peer.py — update @validator and @root_validator
• shard_core/data_model/app_meta.py — update @validator, @root_validator, .schema_json(), and Config.fields
• shard_core/data_model/traefik_dyn_config.py — replace 50+ class Config blocks using Extra.forbid/Extra.allow with model_config = ConfigDict(...); replace confloat/conint with Annotated types
• shard_core/data_model/profile.py — replace .parse_obj() and .dict()
• shard_core/data_model/terminal.py — replace .dict()
• shard_core/data_model/backend/shard_model.py — do not modify (already v2-compatible)
• Other backend models — do not modify

Services (mechanical replacements): websocket.py, backup.py, pairing.py, peer.py, telemetry.py, app_lifecycle.py, app_tools.py, app_usage_reporting.py, app_installation/__init__.py, app_installation/util.py, freeshard_controller.py, portal_controller.py, identity.py, traefik_dynamic_config.py — replace .dict(), .json(), .parse_obj(), .validate().

Web endpoints (mechanical replacements): web/protected/apps.py, backup.py, feedback.py, identities.py, help.py, terminals.py, peers.py, web/public/pair.py, web/internal/app_error.py — replace .dict() and .parse_obj().

Tests: tests/test_model.py — update to use @computed_field-based models.

---

Key Design Decisions

PropertyBaseModel → @computed_field: The v1 workaround is unnecessary in v2. Identity and SafeIdentity have @property fields (short_id, public_key, public_key_pem, domain) that should become @computed_field properties. The PropertyBaseModel class in util.py can then be deleted.

Extra.forbid/Extra.allow in traefik_dyn_config.py: Replace from pydantic import Extra with ConfigDict(extra='forbid') or ConfigDict(extra='allow'). The Extra enum is removed in v2.

identity.py Config.fields exclusion: The fields = {"public_key": {"exclude": True}} pattern becomes public_key: ... = Field(exclude=True) on the field definition itself.

AppMeta.migrate() root validator with pre=True: Becomes @model_validator(mode='before').

freeshard_controller.py .validate() call: Replace with .model_validate().

.schema_json(): Replace with json.dumps(AppMeta.model_json_schema(), indent=2).

---

Risks

• traefik_dyn_config.py is large with many Config classes — high volume but mechanical.
• @root_validator with pre=True semantics differ slightly in v2's @model_validator(mode='before') — verify validator logic is preserved.
• exclude_unset=True and exclude={'id'} kwargs still work in .model_dump() — no change needed there.

---

Verification

Run uv run pytest after changes. Currently-passing tests must continue to pass. Newly-passing tests (previously broken by v1 PropertyBaseModel issues) are a bonus.

---

React with 👍 to approve this plan and start implementation.

[ClaydeCode]

Implementation complete — PR opened: #43

[ClaydeCode]

Review addressed. Removed shard_core/data_model/util.py as requested — it was only re-exporting BaseModel from pydantic and had no remaining consumers after the v2 migration. All modules already import directly from pydantic. The 14 test errors in the suite are pre-existing infrastructure failures (docker not available in CI environment) that exist on main as well and are unrelated to the pydantic migration.