Support SDL 3?

[Quipyowert2]

We should make the game work with SDL 3.2, which was released last month. This involves changing most of the SDL 2 function calls to their new SDL 3 names, and most functions that return -1 on error now return 0 on failure.

I don't think we should drop SDL 2 support anytime soon, especially since Ubuntu doesn't have SDL 3 yet. I searched /usr/include/SDL3/SDL.h on pkgs.org and ubuntu is not on the list of distros that have SDL 3 already, but it's only been two weeks since the release of v3.

Is there a way to make the code work with both SDL 2 and 3 without having #ifdefs everywhere?

P.S, SDL_RenderGeometry function looks cool.

[stephanemagnenat]

A long long time ago (20+ years) we used to have a DXGraphicContext.cpp (DirectX) that would sit next to an SDLGraphicContext.cpp (now simply GraphicContext.cpp). The right file would be compiled depending on the target.

Something in that direction could be an option, to have better code clarity at the expense of some code duplication. In that case, I would advise factoring out a minimal "SDL Version Abstraction Layer" and only duplicate that one. For example, a large part of GraphicContext.cpp is made of software rendering code, that does not need to be duplicated.