LAN game connection seems broken

[stephanemagnenat]

In my home, the client connects to the host and is seen by the host, but on the client side, an empty screen is show forever.

I'm using local network (addresses 192.168.178.XX), the problem happens with both the two computer on Ethernet, and with one Ethernet one Wi-Fi. I am using a Fritz router (FRITZ!Box 5490, FRITZ!OS: 07.29).

Connecting through YOG works.

[DeathByDenim]

I came across this too yesterday. The issue seem to be from commit 8974c4e which involves a perhaps overzealous killing of warnings.

In src/LanFindScreen.cpp:136, there is the declaration of Glob2TabScreen, but it's missing the creation of MultiplayerGameScreen* mgs in the next line.

Should be this:

			Glob2TabScreen screen(true);
			MultiplayerGameScreen* mgs = new MultiplayerGameScreen(&screen, game, client);
			
			
			listener.disableListening();
			int rc = screen.execute(globalContainer->gfx, 40);
			listener.enableListening();
			client->setMultiplayerGame(boost::shared_ptr<MultiplayerGame>());
			if(rc == -1)
				endExecute(-1);
			delete mgs;

It does show the player name twice for some reason for someone joining the game though. Not sure why that is.