Skip to content

Certain Patches will Apply but not Verify #953

Description

@BlueFinBima

Describe the Helios Issue

Patches generated by the GeneratePatches tool may fail to verify. The failure is typically seen in patches which patch files with multiple changes on the same line. The problem is observed by using the "DCS Additional Viewports" interface to install patches which results in the interface saying that the patches have been installed, however when the patches are viewed in Interface Status tab, they appear with a warning triangle with the message that the file is "missing some patches".

The affected patches may also cause a failure during Revert Patches.

Expected behavior

The patches should install correctly, and show that they are installed in the Interface Status window.

Screenshots

Image

Please complete the following information:

  • Helios Version [ 1.6.6190.1 (beta)]
  • DCS Version N/A
  • BMS Version N/A

The problem happened while using

(place an 'x' between the square brackets for all that apply)

  • Profile Editor
  • Control Center
  • Keypress Receiver
  • Something else (remember to tell us what it is)

Additional context

The problem happens because the checks to see if an file has a patch applied checks each individual diff in isolation against the patched file, however when there are two diffs for the same line, and they overlap, then the first diff will not match and the verification will conclude that the file does not have the patch applied.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions