Skip to content
This repository was archived by the owner on Jun 12, 2021. It is now read-only.
This repository was archived by the owner on Jun 12, 2021. It is now read-only.

response_info not initialized correctly sometimes #64

@angelakis

Description

@angelakis

In authorization's post_authentication method, there's some error handling before creating response_info and filling the return_uri entry etc., for example here:

response_info, "access_denied", "{}".format(err.args)

The response_info is initialized in line 555 and in 566 the return_uri is filled.

As a result, when do_response is called, there's an exception raised in

resp = _response.request(kwargs["return_uri"], True)

as return_uri is considered to always be there.

We could say that the app using oidcendpoint could fill the return_uri to avoid the error, but I feel it would be better if in post_authentication the response_info was filled at the beginning rather than in the middle of the method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions