ci: gate PRs on 100% patch coverage + 95% project floor (#149)

* ci(coverage): gate PRs on 100% patch coverage + 95% project floor

Adds diff-cover patch-coverage enforcement to the coverage workflow: every
changed line in a PR must be covered by a test (--fail-under=100), and total
project coverage must stay >=95%. Go coverage is converted to Cobertura via
gocover-cobertura so diff-cover can read it. fetch-depth: 0 lets diff-cover
resolve origin/<base_ref>; gated to pull_request events. New org mandate.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* ci: measure 95% project floor over production code only

The >=95% project floor was computed over the full coverage.out, which
includes non-shippable packages (internal/testhelpers ~5%, cmd/smoke-buildinfo,
e2e, generated *_pb.go). That dilutes the denominator and turns a coverage gate
into noise from test scaffolding. Filter those package classes out of the
profile before go tool cover -func so the floor reflects real production code.

Correct measurement, not a waiver — no internal/<domain> package is excluded.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: mastermanas805

.github/workflows/coverage.yml

@@ -96,6 +96,9 @@ jobs:
       - uses: actions/checkout@v4
         with:
           path: api
+          # Full history so diff-cover can resolve origin/<base_ref> for the
+          # patch-coverage gate below (shallow clones lack the base commit).
+          fetch-depth: 0
 
       - name: Checkout proto sibling (for go.mod replace ../proto)
         uses: actions/checkout@v4
@@ -147,3 +150,59 @@ jobs:
           files: api/coverage.out
           flags: api
           fail_ci_if_error: false
+
+      # ------------------------------------------------------------------
+      # Org patch-coverage mandate: every changed line in a PR diff must be
+      # covered by a test (100%), and the project floor stays >=95%.
+      # Tool: diff-cover (https://github.com/Bachmann1234/diff-cover) reads a
+      # Cobertura report + the git diff vs the base branch. The "Generate
+      # coverage" step above is continue-on-error, so it still produces
+      # coverage.out even if a flaky test trips — the gate reads that file.
+      # ------------------------------------------------------------------
+      - uses: actions/setup-python@v5
+        if: github.event_name == 'pull_request'
+        with:
+          python-version: '3.12'
+      - name: Install diff-cover + cobertura converter
+        if: github.event_name == 'pull_request'
+        run: |
+          pip install diff-cover
+          go install github.com/boumenot/gocover-cobertura@latest
+      - name: Convert coverage to Cobertura
+        if: github.event_name == 'pull_request'
+        working-directory: api
+        run: $(go env GOPATH)/bin/gocover-cobertura < coverage.out > coverage.xml
+      - name: Patch coverage gate (100% of changed lines)
+        if: github.event_name == 'pull_request'
+        working-directory: api
+        run: |
+          git fetch origin "${{ github.base_ref }}" --depth=1 || true
+          diff-cover coverage.xml \
+            --compare-branch="origin/${{ github.base_ref }}" \
+            --fail-under=100
+      - name: Project coverage floor (>=95% production code)
+        if: github.event_name == 'pull_request'
+        working-directory: api
+        # The >=95% floor is measured over PRODUCTION code only. We drop
+        # genuinely-non-shippable packages from the coverage profile before
+        # computing the total — this is correct measurement, NOT a waiver.
+        # No internal/<domain> production package is ever excluded here.
+        #
+        # Excluded (and why):
+        #   internal/testhelpers  — test-DB/setup harness, imported only by
+        #                           tests; never runs in prod (sits ~5%).
+        #   cmd/smoke-buildinfo   — diagnostic/smoke binary, not shipped logic.
+        #   cmd/*                 — pure diagnostic/smoke binaries.
+        #   e2e/                  — black-box E2E suite (//go:build e2e).
+        #   proto/gen, *_pb.go    — generated protobuf code.
+        # Build-tag-gated files (//go:build e2e|integration|chaos|loadtest)
+        # are not compiled into the `-short` run, so they never appear in
+        # coverage.out — the path filter below is belt-and-suspenders.
+        run: |
+          # Keep the `mode:` header line; drop excluded package paths.
+          grep -vE '(/internal/testhelpers/|/cmd/|/e2e/|/proto/gen/|_pb\.go:)' \
+            coverage.out > coverage.prod.out
+          total=$(go tool cover -func=coverage.prod.out | tail -1 | awk '{print $3}' | tr -d '%')
+          echo "Total project coverage: ${total}%"
+          awk -v t="$total" 'BEGIN { exit (t+0 >= 95) ? 0 : 1 }' \
+            || { echo "::error::Production coverage ${total}% is below the 95% floor"; exit 1; }