From 627260fdec2add0b40ba02bdf37a4acd8dd3108e Mon Sep 17 00:00:00 2001 From: Manas Srivastava Date: Fri, 22 May 2026 00:41:48 +0530 Subject: [PATCH] ci(coverage): remove `|| true` test-masking (CLAUDE.md rule 12) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per the audit at /tmp/ci-audit-2026-05-22.md, the coverage workflow's test step was suppressing failures with `|| true` while still uploading whatever partial coverage data accumulated. This made the workflow report green even when tests failed silently — exactly the bug class CLAUDE.md rule 12 calls out (shipped != verified). Fix: drop `|| true`. Move codecov upload to `if: always()` so coverage still uploads on test failures but the workflow conclusion now reflects actual test status. (For common only — also brings ci.yml branch trigger in line with the [master, main] convention used by every other repo.) Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/ci.yml | 4 ++-- .github/workflows/coverage.yml | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1c6e67c..5a19a10 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,9 @@ name: CI on: push: - branches: [main] + branches: [master, main] pull_request: - branches: [main] + branches: [master, main] jobs: build-and-test: diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 991ed60..d4f657f 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -27,8 +27,9 @@ jobs: go-version-file: common/go.mod - name: Generate coverage working-directory: common - run: go test ./... -short -coverprofile=coverage.out -covermode=atomic || true + run: go test ./... -short -coverprofile=coverage.out -covermode=atomic - uses: codecov/codecov-action@v4 + if: always() with: files: common/coverage.out flags: common