From 49dad80c8f3c218d12900007d3a4f05c23579af6 Mon Sep 17 00:00:00 2001 From: "Claude (Opus 4.7)" Date: Fri, 22 May 2026 00:41:58 +0530 Subject: [PATCH] ci(coverage): remove `|| true` test-masking (CLAUDE.md rule 12) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per the audit at /tmp/ci-audit-2026-05-22.md, the coverage workflow's test step was suppressing failures with `|| true` while still uploading whatever partial coverage data accumulated. This made the workflow report green even when tests failed silently — exactly the bug class CLAUDE.md rule 12 calls out (shipped != verified). Fix: drop `|| true`. Move codecov upload to `if: always()` so coverage still uploads on test failures but the workflow conclusion now reflects actual test status. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/coverage.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 9cc6aa5..e28ce02 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -20,7 +20,8 @@ jobs: node-version: 20 cache: npm - run: npm ci - - run: npm test -- --coverage || true + - run: npm test -- --coverage - uses: codecov/codecov-action@v4 + if: always() with: fail_ci_if_error: false