From 58953d3b60e0936d4c35ef59966bf0980574ec5e Mon Sep 17 00:00:00 2001
From: "Claude (engine)" <jason@interactor.com>
Date: Thu, 2 Jul 2026 00:07:39 +0000
Subject: [PATCH 1/2] fix(goal-score): align GoalPriorityEntityType enum to
 deployed DB value 'feedback'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes Sentry PRODUCT-MANAGER-R: schema.prisma still declared the
GoalPriorityEntityType member as 'checkpoint', but the production DB enum was
renamed 'checkpoint'->'feedback' by migration 20260513100000_schema_drift_fix.
Every goal-score read/write for a checkpoint-backed entity passed the literal
'checkpoint', hitting Postgres `invalid input value for enum
GoalPriorityEntityType: "checkpoint"`.

Direction A (chosen): align schema + code to the already-deployed DB value
'feedback'. No new DB migration is required (the DB already has 'feedback')
and it matches the shipped /feedbacks API rename.

Rejected Direction B: add a new prod migration reverting the enum to
'checkpoint' — heavier/riskier, must remap existing 'feedback' rows, and fights
the shipped direction. Flag before merging if a reviewer prefers B.

Scope guard: only the GoalPriorityEntityType / GoalPriorityScore.entityType
surface changed. The internal domain discriminator 'checkpoint' (comments,
attachments, mentions, notify-followers resourceType, phase-board item.type,
sow/recommendations, the Checkpoint Prisma model/table, etc.) is untouched.

- schema.prisma: enum member checkpoint -> feedback (+ prisma generate)
- score-goal-priority.ts: fetchEntity/resolveEntityTitle cases -> 'feedback'
  (bodies still query db.checkpoint); normalize legacy 'checkpoint' payloads to
  'feedback' so residual queued BullMQ jobs drain without re-raising the error
- trigger-rescore, goal-scores routes, feedbacks routes, use-goal-score hook,
  goal-priority-badge, phase-board, item-detail-panel: 'checkpoint' -> 'feedback'
  on the goal-score surface only
- tests updated + legacy-normalization case added

No PM Agent config update needed (internal enum value; no tool/workflow change).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 prisma/schema.prisma                          |  2 +-
 .../p/[projectSlug]/phases/phase-board.tsx    |  2 +-
 .../[projectId]/feedbacks/[id]/route.ts       |  4 +--
 .../projects/[projectId]/feedbacks/route.ts   |  4 +--
 .../[entityType]/[entityId]/override/route.ts |  2 +-
 .../[entityType]/[entityId]/route.ts          |  2 +-
 .../projects/[projectId]/goal-scores/route.ts |  2 +-
 src/components/goals/goal-priority-badge.tsx  |  2 +-
 src/components/phases/item-detail-panel.tsx   |  8 ++++-
 src/hooks/use-goal-score.test.ts              |  6 ++--
 src/hooks/use-goal-score.ts                   |  2 +-
 src/lib/goals/trigger-rescore.ts              |  4 +--
 src/worker/jobs/score-goal-priority.ts        | 12 +++++--
 tests/unit/api/feedbacks-route.test.ts        |  2 +-
 .../worker/jobs/score-goal-priority.test.ts   | 35 +++++++++++++++++--
 15 files changed, 66 insertions(+), 23 deletions(-)

diff --git a/prisma/schema.prisma b/prisma/schema.prisma
index 05d5ba2de..4f01110d0 100644
--- a/prisma/schema.prisma
+++ b/prisma/schema.prisma
@@ -133,7 +133,7 @@ enum SyncDirection {
 enum GoalPriorityEntityType {
   task
   deliverable
-  checkpoint
+  feedback
   phase
 }
 
diff --git a/src/app/(app)/o/[orgSlug]/p/[projectSlug]/phases/phase-board.tsx b/src/app/(app)/o/[orgSlug]/p/[projectSlug]/phases/phase-board.tsx
index 700f2db5e..61c80bed0 100644
--- a/src/app/(app)/o/[orgSlug]/p/[projectSlug]/phases/phase-board.tsx
+++ b/src/app/(app)/o/[orgSlug]/p/[projectSlug]/phases/phase-board.tsx
@@ -750,7 +750,7 @@ function CheckpointCard({
                 onDelete={onDelete ? () => onDelete(item) : undefined}
               />
               <span onClick={(e) => e.stopPropagation()}>
-                <GoalPriorityBadge projectId={projectId} entityType="checkpoint" entityId={item.id} />
+                <GoalPriorityBadge projectId={projectId} entityType="feedback" entityId={item.id} />
               </span>
               <button
                 type="button"
diff --git a/src/app/api/v1/projects/[projectId]/feedbacks/[id]/route.ts b/src/app/api/v1/projects/[projectId]/feedbacks/[id]/route.ts
index 8edcd3505..80162ddd1 100644
--- a/src/app/api/v1/projects/[projectId]/feedbacks/[id]/route.ts
+++ b/src/app/api/v1/projects/[projectId]/feedbacks/[id]/route.ts
@@ -86,8 +86,8 @@ export async function PATCH(req: NextRequest, { params }: Params) {
     await enqueue(
       "documents",
       SCORE_GOAL_PRIORITY_JOB,
-      { projectId, entityType: "checkpoint", entityId: id },
-      { idempotencyKey: `goal-score:checkpoint:${id}:update-${window}`, delay: 10_000 }
+      { projectId, entityType: "feedback", entityId: id },
+      { idempotencyKey: `goal-score:feedback:${id}:update-${window}`, delay: 10_000 }
     );
   }
 
diff --git a/src/app/api/v1/projects/[projectId]/feedbacks/route.ts b/src/app/api/v1/projects/[projectId]/feedbacks/route.ts
index d7a997886..2ab0ad732 100644
--- a/src/app/api/v1/projects/[projectId]/feedbacks/route.ts
+++ b/src/app/api/v1/projects/[projectId]/feedbacks/route.ts
@@ -110,8 +110,8 @@ export async function POST(
   await enqueue(
     "documents",
     SCORE_GOAL_PRIORITY_JOB,
-    { projectId, entityType: "checkpoint", entityId: feedback.id },
-    { idempotencyKey: `goal-score:checkpoint:${feedback.id}:created` }
+    { projectId, entityType: "feedback", entityId: feedback.id },
+    { idempotencyKey: `goal-score:feedback:${feedback.id}:created` }
   );
 
   return auditedResponse(feedback, { status: 201 });
diff --git a/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/override/route.ts b/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/override/route.ts
index 4573ff179..f3d7c4186 100644
--- a/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/override/route.ts
+++ b/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/override/route.ts
@@ -9,7 +9,7 @@ import { enqueue } from "@/lib/queue/enqueue";
 import { SCORE_GOAL_PRIORITY_JOB } from "@/worker/jobs/score-goal-priority";
 import type { GoalPriorityEntityType } from "@prisma/client";
 
-const VALID_ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "checkpoint", "phase"];
+const VALID_ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "feedback", "phase"];
 
 const overrideSchema = z.object({
   score: z.number().min(0).max(100),
diff --git a/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/route.ts b/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/route.ts
index 58a53a83d..a042667ea 100644
--- a/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/route.ts
+++ b/src/app/api/v1/projects/[projectId]/goal-scores/[entityType]/[entityId]/route.ts
@@ -5,7 +5,7 @@ import { db } from "@/lib/db";
 import { authorizeProject } from "@/lib/auth/with-project-auth";
 import type { GoalPriorityEntityType } from "@prisma/client";
 
-const VALID_ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "checkpoint", "phase"];
+const VALID_ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "feedback", "phase"];
 
 export async function GET(
   _req: NextRequest,
diff --git a/src/app/api/v1/projects/[projectId]/goal-scores/route.ts b/src/app/api/v1/projects/[projectId]/goal-scores/route.ts
index 43362b501..bf55ad99a 100644
--- a/src/app/api/v1/projects/[projectId]/goal-scores/route.ts
+++ b/src/app/api/v1/projects/[projectId]/goal-scores/route.ts
@@ -5,7 +5,7 @@ import { db } from "@/lib/db";
 import { authorizeProject } from "@/lib/auth/with-project-auth";
 import type { GoalPriorityEntityType } from "@prisma/client";
 
-const VALID_ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "checkpoint", "phase"];
+const VALID_ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "feedback", "phase"];
 
 export async function GET(
   req: NextRequest,
diff --git a/src/components/goals/goal-priority-badge.tsx b/src/components/goals/goal-priority-badge.tsx
index 37d4bbae4..986c8294f 100644
--- a/src/components/goals/goal-priority-badge.tsx
+++ b/src/components/goals/goal-priority-badge.tsx
@@ -18,7 +18,7 @@ function scoreColor(score: number): string {
 
 interface GoalPriorityBadgeProps {
   projectId: string;
-  entityType: "task" | "deliverable" | "checkpoint" | "phase";
+  entityType: "task" | "deliverable" | "feedback" | "phase";
   entityId: string;
   className?: string;
 }
diff --git a/src/components/phases/item-detail-panel.tsx b/src/components/phases/item-detail-panel.tsx
index ca44058d8..a31c6c523 100644
--- a/src/components/phases/item-detail-panel.tsx
+++ b/src/components/phases/item-detail-panel.tsx
@@ -1256,7 +1256,13 @@ function ItemDetailPanelInner({ projectId, orgId, item, currentUserId, onClose,
             <span onClick={(e) => e.stopPropagation()}>
               <GoalPriorityBadge
                 projectId={projectId}
-                entityType={item.type as "task" | "deliverable" | "checkpoint" | "phase"}
+                entityType={
+                  (item.type === "checkpoint" ? "feedback" : item.type) as
+                    | "task"
+                    | "deliverable"
+                    | "feedback"
+                    | "phase"
+                }
                 entityId={item.id}
               />
             </span>
diff --git a/src/hooks/use-goal-score.test.ts b/src/hooks/use-goal-score.test.ts
index 4a65e991c..d347ec13f 100644
--- a/src/hooks/use-goal-score.test.ts
+++ b/src/hooks/use-goal-score.test.ts
@@ -147,11 +147,11 @@ describe("useGoalScore", () => {
     expect(result.current.score?.effectiveScore).toBe(70);
   });
 
-  it("works for 'checkpoint' entityType", async () => {
+  it("works for 'feedback' entityType", async () => {
     mockFetchScore({ data: MOCK_SCORE });
-    renderHook(() => useGoalScore("proj-2", "checkpoint", "chk-1"));
+    renderHook(() => useGoalScore("proj-2", "feedback", "chk-1"));
     await waitFor(() => expect(global.fetch).toHaveBeenCalledWith(
-      "/api/v1/projects/proj-2/goal-scores/checkpoint/chk-1"
+      "/api/v1/projects/proj-2/goal-scores/feedback/chk-1"
     ));
   });
 });
diff --git a/src/hooks/use-goal-score.ts b/src/hooks/use-goal-score.ts
index 584f47d1d..10d9632d0 100644
--- a/src/hooks/use-goal-score.ts
+++ b/src/hooks/use-goal-score.ts
@@ -25,7 +25,7 @@ export type GoalScore = {
 
 export function useGoalScore(
   projectId: string,
-  entityType: "task" | "deliverable" | "checkpoint" | "phase",
+  entityType: "task" | "deliverable" | "feedback" | "phase",
   entityId: string
 ) {
   const [score, setScore] = useState<GoalScore | null>(null);
diff --git a/src/lib/goals/trigger-rescore.ts b/src/lib/goals/trigger-rescore.ts
index 35f6445c4..781af7053 100644
--- a/src/lib/goals/trigger-rescore.ts
+++ b/src/lib/goals/trigger-rescore.ts
@@ -5,7 +5,7 @@ import { enqueue } from "@/lib/queue/enqueue";
 import { SCORE_GOAL_PRIORITY_JOB } from "@/worker/jobs/score-goal-priority";
 import type { GoalPriorityEntityType } from "@prisma/client";
 
-const ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "checkpoint", "phase"];
+const ENTITY_TYPES: GoalPriorityEntityType[] = ["task", "deliverable", "feedback", "phase"];
 const RESCORE_LIMIT = 50;
 
 export async function triggerProjectRescore(projectId: string): Promise<void> {
@@ -18,7 +18,7 @@ export async function triggerProjectRescore(projectId: string): Promise<void> {
       entities = await db.task.findMany({ where: { projectId }, select: { id: true } });
     } else if (entityType === "deliverable") {
       entities = await db.deliverable.findMany({ where: { projectId }, select: { id: true } });
-    } else if (entityType === "checkpoint") {
+    } else if (entityType === "feedback") {
       const phases = await db.phase.findMany({ where: { projectId }, select: { id: true } });
       const phaseIds = phases.map((p) => p.id);
       entities = await db.checkpoint.findMany({
diff --git a/src/worker/jobs/score-goal-priority.ts b/src/worker/jobs/score-goal-priority.ts
index e8ea711a7..8ace109c5 100644
--- a/src/worker/jobs/score-goal-priority.ts
+++ b/src/worker/jobs/score-goal-priority.ts
@@ -30,7 +30,13 @@ const MODEL = process.env.ANTHROPIC_GOAL_SCORE_MODEL ?? "claude-sonnet-4-6";
 export async function processScoreGoalPriority(
   job: Job
 ): Promise<{ entityId: string; score: number }> {
-  const { projectId, entityType, entityId } = job.data as ScoreGoalPriorityPayload;
+  const { projectId, entityId } = job.data as ScoreGoalPriorityPayload;
+  // Legacy tolerance: the GoalPriorityEntityType enum member 'checkpoint' was
+  // renamed to 'feedback' to match the deployed DB enum. Residual BullMQ jobs
+  // queued before the rename still carry entityType='checkpoint'; normalize
+  // them here so any Prisma call uses the valid enum value and drains cleanly.
+  const rawEntityType = (job.data as ScoreGoalPriorityPayload).entityType as string;
+  const entityType = (rawEntityType === "checkpoint" ? "feedback" : rawEntityType) as GoalPriorityEntityType;
 
   log.info({ event: "score_goal_priority_start", projectId, entityType, entityId });
 
@@ -154,7 +160,7 @@ async function fetchEntity(
       });
       return d ? { title: d.name, description: d.description, dueDate: d.dueDate, phase: d.phase } : null;
     }
-    case "checkpoint": {
+    case "feedback": {
       const c = await db.checkpoint.findUnique({
         where: { id },
         select: { name: true, description: true, dueDate: true, phase: { select: { name: true, description: true } } },
@@ -204,7 +210,7 @@ async function resolveEntityTitle(type: GoalPriorityEntityType, id: string): Pro
       const d = await db.deliverable.findUnique({ where: { id }, select: { name: true } });
       return d?.name ?? null;
     }
-    case "checkpoint": {
+    case "feedback": {
       const c = await db.checkpoint.findUnique({ where: { id }, select: { name: true } });
       return c?.name ?? null;
     }
diff --git a/tests/unit/api/feedbacks-route.test.ts b/tests/unit/api/feedbacks-route.test.ts
index d007d53e7..518243acf 100644
--- a/tests/unit/api/feedbacks-route.test.ts
+++ b/tests/unit/api/feedbacks-route.test.ts
@@ -159,7 +159,7 @@ describe("POST /api/v1/projects/[projectId]/feedbacks", () => {
     expect(mockEnqueue).toHaveBeenCalledWith(
       "documents",
       "score-goal-priority",
-      expect.objectContaining({ entityType: "checkpoint" }),
+      expect.objectContaining({ entityType: "feedback" }),
       expect.any(Object)
     );
   });
diff --git a/tests/unit/worker/jobs/score-goal-priority.test.ts b/tests/unit/worker/jobs/score-goal-priority.test.ts
index dee3d2c8d..701084e4c 100644
--- a/tests/unit/worker/jobs/score-goal-priority.test.ts
+++ b/tests/unit/worker/jobs/score-goal-priority.test.ts
@@ -230,7 +230,7 @@ describe("processScoreGoalPriority", () => {
     expect(mocks.deliverableFindUnique).toHaveBeenCalled();
   });
 
-  it("fetches checkpoint entity", async () => {
+  it("fetches feedback entity", async () => {
     mocks.fetchGoalContext.mockResolvedValue([{ id: "g1", title: "G", description: null, successCriteria: null, keyResults: [], targetDate: null, weight: 1, isActive: true, order: 0 }]);
     mocks.checkpointFindUnique.mockResolvedValue({
       name: "Checkpoint B",
@@ -243,8 +243,39 @@ describe("processScoreGoalPriority", () => {
     mocks.callStructured.mockResolvedValue({ data: { score: 40, rationale: "OK", factors: {} }, usage: {} });
     mocks.projectFindUnique.mockResolvedValue({ organizationId: "org-1" });
 
-    const result = await processScoreGoalPriority(makeJob({ ...PAYLOAD, entityType: "checkpoint", entityId: "chk-1" }));
+    const result = await processScoreGoalPriority(makeJob({ ...PAYLOAD, entityType: "feedback", entityId: "chk-1" }));
     expect(result.entityId).toBe("chk-1");
+    expect(mocks.checkpointFindUnique).toHaveBeenCalled();
+  });
+
+  it("normalizes a legacy 'checkpoint' payload to 'feedback' and succeeds", async () => {
+    // Residual BullMQ jobs queued before the enum rename still carry
+    // entityType='checkpoint'; the job must normalize to 'feedback' so it
+    // drains without re-raising the Postgres enum error.
+    mocks.fetchGoalContext.mockResolvedValue([{ id: "g1", title: "G", description: null, successCriteria: null, keyResults: [], targetDate: null, weight: 1, isActive: true, order: 0 }]);
+    mocks.checkpointFindUnique.mockResolvedValue({
+      name: "Legacy Checkpoint",
+      description: null,
+      dueDate: null,
+      phase: null,
+    });
+    mocks.goalPriorityScoreFindUnique.mockResolvedValue(null);
+    mocks.goalPriorityScoreFindMany.mockResolvedValue([]);
+    mocks.callStructured.mockResolvedValue({ data: { score: 42, rationale: "OK", factors: {} }, usage: {} });
+    mocks.projectFindUnique.mockResolvedValue({ organizationId: "org-1" });
+
+    const result = await processScoreGoalPriority(
+      makeJob({ ...PAYLOAD, entityType: "checkpoint", entityId: "chk-legacy" })
+    );
+    expect(result.entityId).toBe("chk-legacy");
+    expect(mocks.checkpointFindUnique).toHaveBeenCalled();
+    // Persisted with the normalized enum value, never the raw 'checkpoint'.
+    expect(mocks.goalPriorityScoreUpsert).toHaveBeenCalledWith(
+      expect.objectContaining({
+        where: { entityType_entityId: { entityType: "feedback", entityId: "chk-legacy" } },
+        create: expect.objectContaining({ entityType: "feedback" }),
+      })
+    );
   });
 
   it("fetches phase entity", async () => {

From 4886666b1fd631b8c78e813df32f78ed5df684ed Mon Sep 17 00:00:00 2001
From: "Claude (engine)" <jason@interactor.com>
Date: Thu, 2 Jul 2026 00:25:20 +0000
Subject: [PATCH 2/2] test(daemon): isolate reconcileRepos from the real
 workspace fs

The reconcileRepos orphan-sweep (repos.ts) reads the workspace root via
readdirSync + statSync, but repos.test.ts mocked node:fs WITHOUT stubbing
those two. So the two reconcileRepos rmSync-assertion tests enumerated the
REAL /workspace and rm-rf'd any sibling directory found there (e.g. other
checked-out repos in a CI/dev container), firing spurious rmSync calls that
broke:
  - 'adopts a valid checkout ... does NOT attempt a clone' (expected 0 rmSync)
  - 'rm-rf's a non-matching dir then re-clones exactly once' (expected 1 rmSync)

These failed deterministically in any container with sibling workspace dirs,
which made the whole 'npm run test' / coverage run exit non-zero and blocked
the goal-score task's review gates (test-suite-failed + coverage-report-not-
found, both fail-closed on a non-green suite).

Fix is test-only: mock readdirSync -> [] and statSync -> {mtimeMs:0} so the
sweep sees an empty workspace and only the intended rmSync calls fire. The
orphan sweep itself remains covered by the pure sweepOrphanWorkspaceDirs
tests (injected deps). No daemon source/runtime behavior changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 docker/agent/daemon/repos.test.ts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/docker/agent/daemon/repos.test.ts b/docker/agent/daemon/repos.test.ts
index db4ff3011..32c72e9dd 100644
--- a/docker/agent/daemon/repos.test.ts
+++ b/docker/agent/daemon/repos.test.ts
@@ -14,6 +14,15 @@ vi.mock("node:fs", async (orig) => ({
   writeFileSync: vi.fn(),
   mkdirSync: vi.fn(),
   rmSync: vi.fn(),
+  // The orphan sweep in reconcileRepos reads the workspace root via readdirSync
+  // (+ statSync for mtimes). Without mocking these, the sweep enumerates the REAL
+  // filesystem — so any sibling dir in /workspace (e.g. other checked-out repos in
+  // a CI/dev container) is treated as an orphan and rm-rf'd, firing spurious rmSync
+  // calls that break the reconcileRepos rmSync assertions below. Default to an empty
+  // workspace so these integration tests only exercise the adopt/clone decisions;
+  // the sweep itself is covered separately by the pure sweepOrphanWorkspaceDirs tests.
+  readdirSync: vi.fn(() => [] as unknown as ReturnType<typeof import("node:fs").readdirSync>),
+  statSync: vi.fn(() => ({ mtimeMs: 0 }) as unknown as ReturnType<typeof import("node:fs").statSync>),
 }));
 
 // Isolate reconcileRepos from the (heavy, fs/exec-driven) E2 setup path — the