Skip to content

Support Symbols on the GPU#888

Merged
vchuravy merged 4 commits intomasterfrom
vc/symbols2
Mar 5, 2026
Merged

Support Symbols on the GPU#888
vchuravy merged 4 commits intomasterfrom
vc/symbols2

Conversation

@vchuravy
Copy link
Member

  • Support Symbols
  • fixup! Support Symbols
  • Support passing Symbols to kernels

Base automatically changed from vc/aligned_sizeof to master March 4, 2026 07:46
vchuravy and others added 3 commits March 4, 2026 10:15
Port of JuliaGPU/CUDA.jl#2624: add `ArgBox` to wrap kernel arguments,
replacing `Base.RefValue`. This supports both isbits types (by value)
and mutable singletons like `Symbol` (by reference via
`pointer_from_objref`). Remove the non-isbits substitution that
previously replaced such arguments with `C_NULL`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vchuravy vchuravy marked this pull request as ready for review March 4, 2026 14:17
@vchuravy
Copy link
Member Author

vchuravy commented Mar 4, 2026

Error During Test at /var/lib/buildkite-agent/builds/amdgpu2-luraess-com/julialang/amdgpu-dot-jl/test/core/rocarray_base.jl:161
  Got exception outside of a @test
  MethodError: no method matching unsafe_wrap(::Type{AMDGPU.ROCArray}, ::Ptr{Symbol}, ::Int64)
  Closest candidates are:
    unsafe_wrap(::Type{<:AMDGPU.ROCArray}, ::Ptr{T}, ::Tuple{Vararg{var"#s85", N}} where var"#s85"<:Integer; own) where {T, N}
     @ AMDGPU /var/lib/buildkite-agent/builds/amdgpu2-luraess-com/julialang/amdgpu-dot-jl/src/array.jl:257
    unsafe_wrap(::Type{AMDGPU.ROCArray{T}}, ::Ptr, ::Any; kwargs...) where T
     @ AMDGPU /var/lib/buildkite-agent/builds/amdgpu2-luraess-com/julialang/amdgpu-dot-jl/src/array.jl:280
    unsafe_wrap(::Union{Type{Array}, Type{Array{T}}, Type{Vector{T}}}, ::Ptr{T}, ::Integer; own) where T
     @ Base pointer.jl:90
    ...

@vchuravy vchuravy merged commit 404370b into master Mar 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant