From 5ad56c59515e135ed2a2d104c3849097a4f9dbfd Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:33:20 -0500
Subject: [PATCH 1/7] chore(feedback): remove mailto feedback widget

The widget routed to feedback@mrbaseballdynasty.com, which is not a
mailbox we own or monitor. Removing the dead destination is cleaner
than wiring a fallback in v1.

- Delete apps/web/src/features/feedback/ (button, form, mailto helper, tests)
- Pull FeedbackButton import + render from SettingsPage About section
- Drop the matching SettingsPage feedback test

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 .../src/features/feedback/FeedbackButton.tsx  |  22 --
 .../src/features/feedback/FeedbackForm.tsx    | 250 ------------------
 .../feedback/__tests__/FeedbackForm.test.tsx  | 190 -------------
 .../src/features/feedback/feedbackSubmit.ts   |  56 ----
 apps/web/src/features/feedback/index.ts       |  14 -
 .../settings/routes/SettingsPage.test.tsx     |  22 --
 .../features/settings/routes/SettingsPage.tsx |   2 -
 7 files changed, 556 deletions(-)
 delete mode 100644 apps/web/src/features/feedback/FeedbackButton.tsx
 delete mode 100644 apps/web/src/features/feedback/FeedbackForm.tsx
 delete mode 100644 apps/web/src/features/feedback/__tests__/FeedbackForm.test.tsx
 delete mode 100644 apps/web/src/features/feedback/feedbackSubmit.ts
 delete mode 100644 apps/web/src/features/feedback/index.ts

diff --git a/apps/web/src/features/feedback/FeedbackButton.tsx b/apps/web/src/features/feedback/FeedbackButton.tsx
deleted file mode 100644
index 044ee44..0000000
--- a/apps/web/src/features/feedback/FeedbackButton.tsx
+++ /dev/null
@@ -1,22 +0,0 @@
-import { useState } from 'react';
-import { MessageSquare } from 'lucide-react';
-import { FeedbackForm } from './FeedbackForm';
-
-export function FeedbackButton() {
-  const [open, setOpen] = useState(false);
-
-  return (
-    <>
-      <button
-        type="button"
-        aria-label="Send feedback about Mr. Baseball Dynasty"
-        onClick={() => setOpen(true)}
-        className="focus-ring inline-flex items-center gap-2 rounded border border-dynasty-border px-3 py-1.5 font-heading text-xs text-dynasty-text transition-colors hover:bg-dynasty-elevated"
-      >
-        <MessageSquare className="h-3.5 w-3.5" aria-hidden="true" />
-        Send Feedback
-      </button>
-      {open ? <FeedbackForm onClose={() => setOpen(false)} /> : null}
-    </>
-  );
-}
diff --git a/apps/web/src/features/feedback/FeedbackForm.tsx b/apps/web/src/features/feedback/FeedbackForm.tsx
deleted file mode 100644
index 7672970..0000000
--- a/apps/web/src/features/feedback/FeedbackForm.tsx
+++ /dev/null
@@ -1,250 +0,0 @@
-import { useEffect, useMemo, useState } from 'react';
-import { Send, X } from 'lucide-react';
-import { useFocusTrap } from '@/shared/hooks/useFocusTrap';
-import {
-  FEEDBACK_BODY_MAX_LENGTH,
-  FEEDBACK_BODY_MIN_LENGTH,
-  formatFeedbackType,
-  submitFeedbackWithFallback,
-  type FeedbackPayload,
-  type FeedbackSubmitter,
-  type FeedbackType,
-} from './feedbackSubmit';
-
-const FEEDBACK_TYPES: FeedbackType[] = ['bug', 'suggestion', 'question'];
-
-interface FeedbackFormProps {
-  onClose: () => void;
-  submitFeedback?: FeedbackSubmitter;
-  autoDismissMs?: number;
-}
-
-interface FeedbackErrors {
-  type?: string;
-  body?: string;
-  submit?: string;
-}
-
-function validateFeedback(type: string, body: string): FeedbackErrors {
-  const errors: FeedbackErrors = {};
-  const trimmedBody = body.trim();
-
-  if (!FEEDBACK_TYPES.includes(type as FeedbackType)) {
-    errors.type = 'Choose a feedback type.';
-  }
-
-  if (
-    trimmedBody.length < FEEDBACK_BODY_MIN_LENGTH
-    || trimmedBody.length > FEEDBACK_BODY_MAX_LENGTH
-  ) {
-    errors.body = 'Write 200-500 characters so the report is actionable.';
-  }
-
-  return errors;
-}
-
-export function FeedbackForm({
-  onClose,
-  submitFeedback = submitFeedbackWithFallback,
-  autoDismissMs = 3000,
-}: FeedbackFormProps) {
-  const [type, setType] = useState('');
-  const [body, setBody] = useState('');
-  const [contact, setContact] = useState('');
-  const [errors, setErrors] = useState<FeedbackErrors>({});
-  const [status, setStatus] = useState<'idle' | 'submitting' | 'sent'>('idle');
-  const trapRef = useFocusTrap<HTMLDivElement>(true);
-
-  const bodyLength = body.trim().length;
-  const canSubmit = status !== 'submitting' && status !== 'sent';
-
-  const payload = useMemo<FeedbackPayload | null>(() => {
-    if (!FEEDBACK_TYPES.includes(type as FeedbackType)) {
-      return null;
-    }
-
-    return {
-      type: type as FeedbackType,
-      body: body.trim(),
-      contact: contact.trim() || undefined,
-    };
-  }, [body, contact, type]);
-
-  useEffect(() => {
-    if (status !== 'sent') {
-      return;
-    }
-
-    const timeout = window.setTimeout(onClose, autoDismissMs);
-    return () => window.clearTimeout(timeout);
-  }, [autoDismissMs, onClose, status]);
-
-  useEffect(() => {
-    const handleKeyDown = (event: KeyboardEvent) => {
-      if (event.key === 'Escape' && canSubmit) {
-        event.preventDefault();
-        onClose();
-      }
-    };
-
-    document.addEventListener('keydown', handleKeyDown);
-    return () => document.removeEventListener('keydown', handleKeyDown);
-  }, [canSubmit, onClose]);
-
-  async function handleSubmit() {
-    if (!canSubmit) {
-      return;
-    }
-
-    const nextErrors = validateFeedback(type, body);
-    if (Object.keys(nextErrors).length > 0 || !payload) {
-      setErrors(nextErrors);
-      return;
-    }
-
-    setStatus('submitting');
-    setErrors({});
-    try {
-      await submitFeedback(payload);
-      setStatus('sent');
-    } catch {
-      setStatus('idle');
-      setErrors({ submit: 'Feedback could not be sent. Try again or use your mail client directly.' });
-    }
-  }
-
-  return (
-    <div
-      className="fixed inset-0 z-50 flex items-center justify-center bg-dynasty-base/85 px-4 py-8 backdrop-blur-sm"
-      role="dialog"
-      aria-modal="true"
-      aria-labelledby="feedback-title"
-    >
-      <div
-        ref={trapRef}
-        tabIndex={-1}
-        className="w-full max-w-2xl rounded-lg border border-dynasty-border bg-dynasty-surface p-6 shadow-2xl"
-      >
-        <div className="flex items-start justify-between gap-4">
-          <div>
-            <div className="font-data text-[11px] uppercase tracking-[0.22em] text-accent-info">
-              Player Feedback
-            </div>
-            <h2 id="feedback-title" className="mt-2 font-heading text-xl font-semibold text-dynasty-textBright">
-              Send feedback
-            </h2>
-            <p className="mt-2 font-heading text-sm leading-6 text-dynasty-muted">
-              Report bugs, questions, or friction from the exact thing you are seeing. Only the fields you type are sent.
-            </p>
-          </div>
-          <button
-            type="button"
-            disabled={status === 'submitting'}
-            onClick={onClose}
-            aria-label="Close feedback form"
-            className="focus-ring rounded border border-dynasty-border p-2 text-dynasty-muted transition-colors hover:bg-dynasty-elevated hover:text-dynasty-text disabled:opacity-50"
-          >
-            <X className="h-4 w-4" aria-hidden="true" />
-          </button>
-        </div>
-
-        {status === 'sent' ? (
-          <div className="mt-6 rounded border border-accent-success/40 bg-accent-success/10 px-4 py-3 font-heading text-sm text-accent-success">
-            Thanks — sent.
-          </div>
-        ) : (
-          <div className="mt-6 space-y-4">
-            <label className="block">
-              <span className="font-heading text-sm font-semibold text-dynasty-textBright">
-                Type
-              </span>
-              <select
-                name="feedback-type"
-                value={type}
-                onChange={(event) => setType(event.target.value)}
-                className="mt-2 w-full rounded border border-dynasty-border bg-dynasty-base px-3 py-2 font-heading text-sm text-dynasty-text"
-                aria-invalid={Boolean(errors.type)}
-              >
-                <option value="">Choose one</option>
-                {FEEDBACK_TYPES.map((candidate) => (
-                  <option key={candidate} value={candidate}>
-                    {formatFeedbackType(candidate)}
-                  </option>
-                ))}
-              </select>
-              {errors.type ? (
-                <span className="mt-2 block font-heading text-xs text-accent-danger">{errors.type}</span>
-              ) : null}
-            </label>
-
-            <label className="block">
-              <span className="font-heading text-sm font-semibold text-dynasty-textBright">
-                Details
-              </span>
-              <textarea
-                name="feedback-body"
-                value={body}
-                onChange={(event) => setBody(event.target.value)}
-                maxLength={FEEDBACK_BODY_MAX_LENGTH}
-                rows={7}
-                className="mt-2 w-full resize-none rounded border border-dynasty-border bg-dynasty-base px-3 py-2 font-heading text-sm leading-6 text-dynasty-text"
-                aria-invalid={Boolean(errors.body)}
-                placeholder="What happened? What did you expect? What save state or screen were you on?"
-              />
-              <div className="mt-2 flex flex-col gap-1 sm:flex-row sm:items-center sm:justify-between">
-                {errors.body ? (
-                  <span className="font-heading text-xs text-accent-danger">{errors.body}</span>
-                ) : (
-                  <span className="font-heading text-xs text-dynasty-muted">
-                    200-500 characters keeps reports actionable.
-                  </span>
-                )}
-                <span className="font-data text-xs text-dynasty-muted">
-                  {bodyLength}/{FEEDBACK_BODY_MAX_LENGTH}
-                </span>
-              </div>
-            </label>
-
-            <label className="block">
-              <span className="font-heading text-sm font-semibold text-dynasty-textBright">
-                How to reach you
-              </span>
-              <input
-                name="feedback-contact"
-                value={contact}
-                onChange={(event) => setContact(event.target.value)}
-                className="mt-2 w-full rounded border border-dynasty-border bg-dynasty-base px-3 py-2 font-heading text-sm text-dynasty-text"
-                placeholder="Optional"
-              />
-            </label>
-
-            {errors.submit ? (
-              <div className="rounded border border-accent-danger/40 bg-accent-danger/10 px-3 py-2 font-heading text-sm text-accent-danger">
-                {errors.submit}
-              </div>
-            ) : null}
-
-            <div className="flex flex-wrap justify-end gap-3">
-              <button
-                type="button"
-                onClick={onClose}
-                className="focus-ring rounded border border-dynasty-border px-4 py-2 font-heading text-sm text-dynasty-text transition-colors hover:bg-dynasty-elevated"
-              >
-                Cancel
-              </button>
-              <button
-                type="button"
-                disabled={!canSubmit}
-                onClick={() => void handleSubmit()}
-                className="focus-ring inline-flex items-center gap-2 rounded bg-accent-primary px-4 py-2 font-heading text-sm font-semibold text-white transition-colors hover:bg-accent-primaryHover disabled:cursor-not-allowed disabled:opacity-50"
-              >
-                <Send className="h-4 w-4" aria-hidden="true" />
-                {status === 'submitting' ? 'Sending' : 'Send Feedback'}
-              </button>
-            </div>
-          </div>
-        )}
-      </div>
-    </div>
-  );
-}
diff --git a/apps/web/src/features/feedback/__tests__/FeedbackForm.test.tsx b/apps/web/src/features/feedback/__tests__/FeedbackForm.test.tsx
deleted file mode 100644
index 39c29ee..0000000
--- a/apps/web/src/features/feedback/__tests__/FeedbackForm.test.tsx
+++ /dev/null
@@ -1,190 +0,0 @@
-import { act } from 'react';
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-import { createRoot, type Root } from 'react-dom/client';
-import { FeedbackForm } from '../FeedbackForm';
-import { createMailtoFeedbackSubmitter } from '../feedbackSubmit';
-
-(
-  globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean }
-).IS_REACT_ACT_ENVIRONMENT = true;
-
-const VALID_BODY = [
-  'The standings panel is clear, but the modal close behavior felt hard to discover on mobile.',
-  'I expected the same escape hatch on every report surface after advancing several weeks.',
-  'This is reproducible from a new save after opening the pennant race panel twice.',
-].join(' ');
-
-function setFieldValue(
-  field: HTMLInputElement | HTMLSelectElement | HTMLTextAreaElement,
-  value: string,
-) {
-  const valueSetter = Object.getOwnPropertyDescriptor(field.constructor.prototype, 'value')?.set;
-  valueSetter?.call(field, value);
-  field.dispatchEvent(new Event('input', { bubbles: true }));
-  field.dispatchEvent(new Event('change', { bubbles: true }));
-}
-
-describe('FeedbackForm', () => {
-  let container: HTMLDivElement;
-  let root: Root;
-
-  beforeEach(() => {
-    container = document.createElement('div');
-    document.body.appendChild(container);
-    root = createRoot(container);
-  });
-
-  afterEach(async () => {
-    vi.useRealTimers();
-    await act(async () => {
-      root.unmount();
-    });
-    container.remove();
-    vi.clearAllMocks();
-  });
-
-  it('validates feedback type and body before submitting', async () => {
-    const submitFeedback = vi.fn().mockResolvedValue(undefined);
-
-    await act(async () => {
-      root.render(
-        <FeedbackForm
-          onClose={vi.fn()}
-          submitFeedback={submitFeedback}
-        />,
-      );
-    });
-
-    const submitButton = Array.from(container.querySelectorAll('button')).find((button) =>
-      button.textContent?.includes('Send Feedback'),
-    );
-
-    await act(async () => {
-      submitButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
-      await Promise.resolve();
-    });
-
-    expect(container.textContent).toContain('Choose a feedback type.');
-    expect(container.textContent).toContain('Write 200-500 characters so the report is actionable.');
-    expect(submitFeedback).not.toHaveBeenCalled();
-  });
-
-  it('opens the mailto fallback with explicit form fields only', async () => {
-    const openMailto = vi.fn();
-    const submitFeedback = createMailtoFeedbackSubmitter({
-      openMailto,
-      to: 'feedback@example.test',
-    });
-
-    await act(async () => {
-      root.render(
-        <FeedbackForm
-          onClose={vi.fn()}
-          submitFeedback={submitFeedback}
-        />,
-      );
-    });
-
-    const typeSelect = container.querySelector('select[name="feedback-type"]') as HTMLSelectElement;
-    const bodyField = container.querySelector('textarea[name="feedback-body"]') as HTMLTextAreaElement;
-
-    await act(async () => {
-      setFieldValue(typeSelect, 'bug');
-      setFieldValue(bodyField, VALID_BODY);
-    });
-
-    const submitButton = Array.from(container.querySelectorAll('button')).find((button) =>
-      button.textContent?.includes('Send Feedback'),
-    );
-
-    await act(async () => {
-      submitButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
-      await Promise.resolve();
-    });
-
-    expect(openMailto).toHaveBeenCalledTimes(1);
-    const href = decodeURIComponent(openMailto.mock.calls[0]?.[0] ?? '');
-    expect(href).toContain('mailto:feedback@example.test');
-    expect(href).toContain('MBD Feedback: bug');
-    expect(href).toContain('Type: bug');
-    expect(href).toContain(VALID_BODY);
-    expect(href).not.toContain('Reach me:');
-    expect(href).not.toContain(window.location.href);
-    expect(href).not.toContain(navigator.userAgent);
-    expect(href).not.toContain('fingerprint');
-  });
-
-  it('includes optional contact only when the user types it', async () => {
-    const openMailto = vi.fn();
-    const submitFeedback = createMailtoFeedbackSubmitter({
-      openMailto,
-      to: 'feedback@example.test',
-    });
-
-    await act(async () => {
-      root.render(
-        <FeedbackForm
-          onClose={vi.fn()}
-          submitFeedback={submitFeedback}
-        />,
-      );
-    });
-
-    await act(async () => {
-      setFieldValue(container.querySelector('select[name="feedback-type"]') as HTMLSelectElement, 'question');
-      setFieldValue(container.querySelector('textarea[name="feedback-body"]') as HTMLTextAreaElement, VALID_BODY);
-      setFieldValue(container.querySelector('input[name="feedback-contact"]') as HTMLInputElement, 'tester@example.test');
-    });
-
-    const submitButton = Array.from(container.querySelectorAll('button')).find((button) =>
-      button.textContent?.includes('Send Feedback'),
-    );
-
-    await act(async () => {
-      submitButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
-      await Promise.resolve();
-    });
-
-    const href = decodeURIComponent(openMailto.mock.calls[0]?.[0] ?? '');
-    expect(href).toContain('Type: question');
-    expect(href).toContain('Reach me: tester@example.test');
-  });
-
-  it('shows success and auto-dismisses after submit', async () => {
-    vi.useFakeTimers();
-    const onClose = vi.fn();
-
-    await act(async () => {
-      root.render(
-        <FeedbackForm
-          autoDismissMs={3000}
-          onClose={onClose}
-          submitFeedback={vi.fn().mockResolvedValue(undefined)}
-        />,
-      );
-    });
-
-    await act(async () => {
-      setFieldValue(container.querySelector('select[name="feedback-type"]') as HTMLSelectElement, 'suggestion');
-      setFieldValue(container.querySelector('textarea[name="feedback-body"]') as HTMLTextAreaElement, VALID_BODY);
-    });
-
-    const submitButton = Array.from(container.querySelectorAll('button')).find((button) =>
-      button.textContent?.includes('Send Feedback'),
-    );
-
-    await act(async () => {
-      submitButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
-      await Promise.resolve();
-    });
-
-    expect(container.textContent).toContain('Thanks — sent.');
-    expect(onClose).not.toHaveBeenCalled();
-
-    await act(async () => {
-      vi.advanceTimersByTime(3000);
-    });
-
-    expect(onClose).toHaveBeenCalledTimes(1);
-  });
-});
diff --git a/apps/web/src/features/feedback/feedbackSubmit.ts b/apps/web/src/features/feedback/feedbackSubmit.ts
deleted file mode 100644
index 68e22d1..0000000
--- a/apps/web/src/features/feedback/feedbackSubmit.ts
+++ /dev/null
@@ -1,56 +0,0 @@
-export type FeedbackType = 'bug' | 'suggestion' | 'question';
-
-export interface FeedbackPayload {
-  type: FeedbackType;
-  body: string;
-  contact?: string;
-}
-
-export type FeedbackSubmitter = (payload: FeedbackPayload) => Promise<void>;
-
-export const FEEDBACK_BODY_MIN_LENGTH = 200;
-export const FEEDBACK_BODY_MAX_LENGTH = 500;
-export const DEFAULT_FEEDBACK_EMAIL = 'feedback@mrbaseballdynasty.com';
-
-export function formatFeedbackType(value: FeedbackType): string {
-  if (value === 'bug') return 'Bug';
-  if (value === 'suggestion') return 'Suggestion';
-  return 'Question';
-}
-
-export function buildMailtoFeedbackHref(
-  payload: FeedbackPayload,
-  to = DEFAULT_FEEDBACK_EMAIL,
-): string {
-  const bodyLines = [
-    `Type: ${payload.type}`,
-    '',
-    'Report:',
-    payload.body.trim(),
-  ];
-
-  const contact = payload.contact?.trim();
-  if (contact) {
-    bodyLines.push('', `Reach me: ${contact}`);
-  }
-
-  const subject = encodeURIComponent(`MBD Feedback: ${payload.type}`);
-  const body = encodeURIComponent(bodyLines.join('\n'));
-
-  return `mailto:${to}?subject=${subject}&body=${body}`;
-}
-
-export function createMailtoFeedbackSubmitter(options: {
-  openMailto: (href: string) => void;
-  to?: string;
-}): FeedbackSubmitter {
-  return async (payload) => {
-    options.openMailto(buildMailtoFeedbackHref(payload, options.to));
-  };
-}
-
-export const submitFeedbackWithFallback: FeedbackSubmitter = createMailtoFeedbackSubmitter({
-  openMailto: (href) => {
-    window.location.href = href;
-  },
-});
diff --git a/apps/web/src/features/feedback/index.ts b/apps/web/src/features/feedback/index.ts
deleted file mode 100644
index aaf3f99..0000000
--- a/apps/web/src/features/feedback/index.ts
+++ /dev/null
@@ -1,14 +0,0 @@
-export { FeedbackButton } from './FeedbackButton';
-export { FeedbackForm } from './FeedbackForm';
-export {
-  buildMailtoFeedbackHref,
-  createMailtoFeedbackSubmitter,
-  DEFAULT_FEEDBACK_EMAIL,
-  FEEDBACK_BODY_MAX_LENGTH,
-  FEEDBACK_BODY_MIN_LENGTH,
-  formatFeedbackType,
-  submitFeedbackWithFallback,
-  type FeedbackPayload,
-  type FeedbackSubmitter,
-  type FeedbackType,
-} from './feedbackSubmit';
diff --git a/apps/web/src/features/settings/routes/SettingsPage.test.tsx b/apps/web/src/features/settings/routes/SettingsPage.test.tsx
index dc02780..d383ad2 100644
--- a/apps/web/src/features/settings/routes/SettingsPage.test.tsx
+++ b/apps/web/src/features/settings/routes/SettingsPage.test.tsx
@@ -231,31 +231,9 @@ describe('SettingsPage', () => {
     expect(container.textContent).toContain('Display');
     expect(container.textContent).toContain('Accessibility');
     expect(container.textContent).toContain('Data / Install');
-    expect(container.textContent).toContain('Send Feedback');
     expect(container.textContent).toContain('Mr. Baseball Dynasty v1.0.0');
   });
 
-  it('opens the feedback form from the settings page', async () => {
-    await act(async () => {
-      root.render(<SettingsPage />);
-      await Promise.resolve();
-    });
-
-    const feedbackButton = Array.from(container.querySelectorAll('button')).find((button) =>
-      button.textContent?.includes('Send Feedback'),
-    );
-
-    await act(async () => {
-      feedbackButton?.dispatchEvent(new MouseEvent('click', { bubbles: true }));
-      await Promise.resolve();
-    });
-
-    expect(container.textContent).toContain('Send feedback');
-    expect(container.textContent).toContain('Bug');
-    expect(container.textContent).toContain('Suggestion');
-    expect(container.textContent).toContain('Question');
-  });
-
   it('updates the mute toggle and volume slider through the page controls', async () => {
     await act(async () => {
       root.render(<SettingsPage />);
diff --git a/apps/web/src/features/settings/routes/SettingsPage.tsx b/apps/web/src/features/settings/routes/SettingsPage.tsx
index 0685494..0aa5a4c 100644
--- a/apps/web/src/features/settings/routes/SettingsPage.tsx
+++ b/apps/web/src/features/settings/routes/SettingsPage.tsx
@@ -6,7 +6,6 @@ import { useAudioPreferencesStore } from '@/shared/hooks/useAudioPreferencesStor
 import { useGameStore } from '@/shared/hooks/useGameStore';
 import { usePreferencesStore } from '@/shared/hooks/usePreferencesStore';
 import { useTour } from '@/shared/components/TourProvider';
-import { FeedbackButton } from '@/features/feedback';
 import { useSaveRecovery } from '@/features/save-recovery';
 import { getAudioEngine } from '@/shared/lib/audio';
 import { logger } from '@/shared/lib/logger';
@@ -1000,7 +999,6 @@ export default function SettingsPage() {
             </div>
             <div className="flex flex-wrap gap-2">
               <TutorialRestartButton />
-              <FeedbackButton />
             </div>
           </div>
         </SettingsSection>

From 3bb2c1992047bbad6e76615b1acd1a2b1062cecb Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:33:29 -0500
Subject: [PATCH 2/7] chore(onboarding): delete orphaned legacy OnboardingPage
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The legacy procedural onboarding wizard at /onboarding was replaced by
RevisedOnboardingPage in the wire-everything-sweep. The legacy route
file still lives in tree but no router entry imports it.

- Delete apps/web/src/features/onboarding/routes/OnboardingPage.tsx
- Delete the only-used-by-it hook apps/web/src/features/onboarding/hooks/useOnboardingState.ts
- Remove the now-empty hooks/ directory

Shared onboarding components (AGMPanel, AssessmentPanel, ChapterProgress,
ChoiceSelector, OnboardingComplete, and the eight chapter views) stay
in tree pending the revised-onboarding canonicalization pass — they
likely get reused or replaced in that sprint.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 .../onboarding/hooks/useOnboardingState.ts    | 120 ------
 .../onboarding/routes/OnboardingPage.tsx      | 346 ------------------
 2 files changed, 466 deletions(-)
 delete mode 100644 apps/web/src/features/onboarding/hooks/useOnboardingState.ts
 delete mode 100644 apps/web/src/features/onboarding/routes/OnboardingPage.tsx

diff --git a/apps/web/src/features/onboarding/hooks/useOnboardingState.ts b/apps/web/src/features/onboarding/hooks/useOnboardingState.ts
deleted file mode 100644
index dda4a40..0000000
--- a/apps/web/src/features/onboarding/hooks/useOnboardingState.ts
+++ /dev/null
@@ -1,120 +0,0 @@
-import { useReducer } from 'react';
-import type {
-  DialogueLine,
-  OnboardingChapter,
-  OnboardingScript,
-  AllChapterData,
-  GMPhilosophy,
-} from '@mbd/sim-core';
-
-// ---------------------------------------------------------------------------
-// State
-// ---------------------------------------------------------------------------
-
-export type WizardPhase = 'loading' | 'greeting' | 'chapter' | 'complete';
-
-export interface OnboardingWizardState {
-  phase: WizardPhase;
-  currentChapter: number; // 0–7 index into CHAPTER_ORDER
-  choices: Record<string, string>; // chapterId → choiceId
-  script: OnboardingScript | null;
-  chapterData: AllChapterData | null;
-  showingReaction: boolean; // true while AGM reaction is animating
-}
-
-const INITIAL_STATE: OnboardingWizardState = {
-  phase: 'loading',
-  currentChapter: 0,
-  choices: {},
-  script: null,
-  chapterData: null,
-  showingReaction: false,
-};
-
-// ---------------------------------------------------------------------------
-// Actions
-// ---------------------------------------------------------------------------
-
-type OnboardingAction =
-  | { type: 'LOADED'; script: OnboardingScript; chapterData: AllChapterData }
-  | { type: 'ADVANCE_TO_CHAPTERS' }
-  | { type: 'SELECT_CHOICE'; chapterId: string; choiceId: string }
-  | { type: 'REACTION_COMPLETE' }
-  | { type: 'NEXT_CHAPTER' }
-  | { type: 'COMPLETE' }
-  | { type: 'SKIP' };
-
-const TOTAL_CHAPTERS = 8;
-
-function reducer(
-  state: OnboardingWizardState,
-  action: OnboardingAction,
-): OnboardingWizardState {
-  switch (action.type) {
-    case 'LOADED':
-      return {
-        ...state,
-        phase: 'greeting',
-        script: action.script,
-        chapterData: action.chapterData,
-      };
-
-    case 'ADVANCE_TO_CHAPTERS':
-      return { ...state, phase: 'chapter', currentChapter: 0 };
-
-    case 'SELECT_CHOICE':
-      return {
-        ...state,
-        choices: { ...state.choices, [action.chapterId]: action.choiceId },
-        showingReaction: true,
-      };
-
-    case 'REACTION_COMPLETE':
-      return { ...state, showingReaction: false };
-
-    case 'NEXT_CHAPTER': {
-      const next = state.currentChapter + 1;
-      if (next >= TOTAL_CHAPTERS) {
-        return { ...state, phase: 'complete' };
-      }
-      return { ...state, currentChapter: next, showingReaction: false };
-    }
-
-    case 'COMPLETE':
-      return { ...state, phase: 'complete' };
-
-    case 'SKIP':
-      return { ...state, phase: 'complete' };
-
-    default:
-      return state;
-  }
-}
-
-// ---------------------------------------------------------------------------
-// Hook
-// ---------------------------------------------------------------------------
-
-export function useOnboardingState() {
-  const [state, dispatch] = useReducer(reducer, INITIAL_STATE);
-
-  return { state, dispatch } as const;
-}
-
-// ---------------------------------------------------------------------------
-// Philosophy extraction
-// ---------------------------------------------------------------------------
-
-/** Derive GMPhilosophy from user choices, falling back to balanced defaults. */
-export function extractPhilosophy(
-  choices: Record<string, string>,
-): GMPhilosophy {
-  return {
-    seasonGoal: (choices['owners_office'] ?? 'compete') as GMPhilosophy['seasonGoal'],
-    developmentStyle: (choices['the_farm'] ?? 'balanced') as GMPhilosophy['developmentStyle'],
-    spendingStyle: (choices['financial_playbook'] ?? 'balanced') as GMPhilosophy['spendingStyle'],
-    scoutingFocus: (choices['scouting_intel'] ?? 'draft') as GMPhilosophy['scoutingFocus'],
-    tradeApproach: (choices['season_strategy'] ?? 'opportunistic') as GMPhilosophy['tradeApproach'],
-    mediaTone: (choices['press_conference'] ?? 'measured') as GMPhilosophy['mediaTone'],
-  };
-}
diff --git a/apps/web/src/features/onboarding/routes/OnboardingPage.tsx b/apps/web/src/features/onboarding/routes/OnboardingPage.tsx
deleted file mode 100644
index 6ee79ff..0000000
--- a/apps/web/src/features/onboarding/routes/OnboardingPage.tsx
+++ /dev/null
@@ -1,346 +0,0 @@
-import { useCallback, useEffect, useMemo, useState } from 'react';
-import { useNavigate } from 'react-router-dom';
-import { ArrowRight, SkipForward } from 'lucide-react';
-import { useWorker } from '@/shared/hooks/useWorker';
-import { AGMPanel } from '../components/AGMPanel';
-import { AssessmentPanel } from '../components/AssessmentPanel';
-import { ChapterProgress } from '../components/ChapterProgress';
-import { ChoiceSelector } from '../components/ChoiceSelector';
-import { OnboardingComplete } from '../components/OnboardingComplete';
-import {
-  useOnboardingState,
-  extractPhilosophy,
-} from '../hooks/useOnboardingState';
-import type { DialogueLine, ChapterScript } from '@mbd/sim-core';
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-/** Chapters that present choices to the user. */
-const CHOICE_CHAPTERS = new Set([
-  'owners_office',
-  'the_farm',
-  'financial_playbook',
-  'scouting_intel',
-  'season_strategy',
-  'press_conference',
-]);
-
-function getChapterChoiceOptions(chapter: ChapterScript): Array<{ id: string; label: string; description: string }> | null {
-  const data = chapter.assessmentData;
-  const id = chapter.chapter.id;
-
-  switch (id) {
-    case 'owners_office':
-      return data.owner?.seasonGoalOptions ?? null;
-    case 'the_farm':
-      return data.farm?.developmentOptions ?? null;
-    case 'financial_playbook':
-      return data.financial?.spendingOptions ?? null;
-    case 'scouting_intel':
-      return data.scouting?.scoutingFocusOptions ?? null;
-    case 'season_strategy':
-      return data.strategy?.strategyOptions ?? null;
-    case 'press_conference':
-      return data.press?.openingStatementOptions.map((o) => ({
-        id: o.id,
-        label: o.label,
-        description: o.statement,
-      })) ?? null;
-    default:
-      return null;
-  }
-}
-
-// ---------------------------------------------------------------------------
-// Component
-// ---------------------------------------------------------------------------
-
-export default function OnboardingPage() {
-  const navigate = useNavigate();
-  const worker = useWorker();
-  const { state: wizard, dispatch } = useOnboardingState();
-  const [greetingDone, setGreetingDone] = useState(false);
-
-  // Load data on mount
-  useEffect(() => {
-    if (!worker.isReady || wizard.phase !== 'loading') return;
-
-    void worker.getOnboardingData()
-      .then((result) => {
-        dispatch({
-          type: 'LOADED',
-          script: result.script,
-          chapterData: result.chapterData,
-        });
-      })
-      .catch((err: unknown) => {
-        // eslint-disable-next-line no-console
-        console.error('[onboarding] Failed to load data:', err);
-      });
-  }, [worker, wizard.phase, dispatch]);
-
-  // Current chapter script
-  const currentChapterScript = useMemo(() => {
-    if (!wizard.script || wizard.phase !== 'chapter') return null;
-    return wizard.script.chapters[wizard.currentChapter] ?? null;
-  }, [wizard.script, wizard.phase, wizard.currentChapter]);
-
-  // Dialogue lines for AGM panel
-  const agmDialogue = useMemo((): DialogueLine[] => {
-    if (!wizard.script) return [];
-
-    if (wizard.phase === 'greeting') {
-      return [{
-        speaker: 'assistant_gm' as const,
-        text: wizard.script.greeting,
-        tone: 'informative' as const,
-        emphasis: null,
-        referencedPlayerName: null,
-        referencedStat: null,
-      }];
-    }
-
-    if (wizard.phase === 'chapter' && currentChapterScript) {
-      return [
-        ...currentChapterScript.intro,
-        ...currentChapterScript.reaction,
-      ];
-    }
-
-    return [];
-  }, [wizard.script, wizard.phase, currentChapterScript]);
-
-  // Choice handling
-  const choiceOptions = currentChapterScript ? getChapterChoiceOptions(currentChapterScript) : null;
-  const selectedChoiceId = currentChapterScript
-    ? wizard.choices[currentChapterScript.chapter.id] ?? null
-    : null;
-  const choiceReaction = selectedChoiceId && currentChapterScript
-    ? currentChapterScript.choiceReactions[selectedChoiceId] ?? null
-    : null;
-
-  const hasChoice = CHOICE_CHAPTERS.has(currentChapterScript?.chapter.id ?? '');
-  const canAdvance = !hasChoice || selectedChoiceId != null;
-
-  const handleSelectChoice = useCallback((choiceId: string) => {
-    if (!currentChapterScript) return;
-    dispatch({ type: 'SELECT_CHOICE', chapterId: currentChapterScript.chapter.id, choiceId });
-  }, [currentChapterScript, dispatch]);
-
-  const handleReactionComplete = useCallback(() => {
-    dispatch({ type: 'REACTION_COMPLETE' });
-  }, [dispatch]);
-
-  const handleNextChapter = useCallback(() => {
-    dispatch({ type: 'NEXT_CHAPTER' });
-  }, [dispatch]);
-
-  const handleSkip = useCallback(() => {
-    const philosophy = extractPhilosophy({});
-    void worker.completeOnboarding(philosophy);
-    navigate('/dashboard');
-  }, [worker, navigate]);
-
-  const handleEnterFrontOffice = useCallback(() => {
-    const philosophy = extractPhilosophy(wizard.choices);
-    void worker.completeOnboarding(philosophy);
-    navigate('/dashboard');
-  }, [worker, wizard.choices, navigate]);
-
-  // Loading
-  if (wizard.phase === 'loading' || !wizard.script) {
-    return (
-      <div className="flex h-screen items-center justify-center bg-dynasty-bg">
-        <div className="text-center">
-          <div className="mb-3 font-brand text-3xl text-accent-primary motion-safe:animate-pulse">
-            MBD
-          </div>
-          <div className="font-data text-sm text-dynasty-muted">Preparing your briefing...</div>
-        </div>
-      </div>
-    );
-  }
-
-  // Completion screen
-  if (wizard.phase === 'complete') {
-    const farewellLines: DialogueLine[] = [{
-      speaker: 'assistant_gm' as const,
-      text: wizard.script.farewell,
-      tone: 'philosophical' as const,
-      emphasis: null,
-      referencedPlayerName: null,
-      referencedStat: null,
-    }];
-
-    return (
-      <div className="flex min-h-screen flex-col bg-dynasty-bg">
-        <Header agmName={wizard.script.assistantProfile.nickname} onSkip={handleSkip} showSkip={false} />
-        <div className="mx-auto w-full max-w-5xl flex-1 px-6 py-8">
-          <div className="flex gap-6">
-            {/* Left: completion content */}
-            <div className="flex-[7] overflow-y-auto">
-              <OnboardingComplete
-                highlights={wizard.script.highlights}
-                quickReference={wizard.script.quickReference}
-                farewellLines={farewellLines}
-                onEnterFrontOffice={handleEnterFrontOffice}
-              />
-            </div>
-            {/* Right: AGM panel */}
-            <div className="flex-[3]">
-              <AGMPanel
-                profile={wizard.script.assistantProfile}
-                dialogueLines={farewellLines}
-              />
-            </div>
-          </div>
-        </div>
-      </div>
-    );
-  }
-
-  // Greeting phase
-  if (wizard.phase === 'greeting') {
-    return (
-      <div className="flex min-h-screen flex-col bg-dynasty-bg">
-        <Header agmName={wizard.script.assistantProfile.nickname} onSkip={handleSkip} />
-        <div className="mx-auto flex w-full max-w-3xl flex-1 flex-col items-center justify-center px-6">
-          <AGMPanel
-            profile={wizard.script.assistantProfile}
-            dialogueLines={agmDialogue}
-            onDialogueComplete={() => setGreetingDone(true)}
-          />
-          {greetingDone && (
-            <button
-              type="button"
-              onClick={() => dispatch({ type: 'ADVANCE_TO_CHAPTERS' })}
-              className="mt-6 flex items-center gap-2 rounded-lg bg-accent-primary px-5 py-2.5 font-heading text-sm font-semibold text-dynasty-bg transition-colors hover:bg-accent-primary/90"
-            >
-              Let&apos;s Get Started
-              <ArrowRight className="h-4 w-4" />
-            </button>
-          )}
-        </div>
-      </div>
-    );
-  }
-
-  // Chapter flow
-  return (
-    <div className="flex min-h-screen flex-col bg-dynasty-bg">
-      <Header agmName={wizard.script.assistantProfile.nickname} onSkip={handleSkip} />
-
-      <div className="mx-auto w-full max-w-6xl flex-1 px-6 py-6">
-        {/* Chapter title */}
-        {currentChapterScript && (
-          <div className="mb-5">
-            <h2 className="font-heading text-xl font-bold text-dynasty-text">
-              {currentChapterScript.chapter.title}
-            </h2>
-            <p className="mt-1 font-data text-xs text-dynasty-muted">
-              {currentChapterScript.chapter.subtitle}
-            </p>
-          </div>
-        )}
-
-        {/* Split layout */}
-        <div className="flex gap-6" style={{ minHeight: 'calc(100vh - 200px)' }}>
-          {/* Left 70%: Assessment data + choices */}
-          <div className="flex-[7] overflow-y-auto pr-2">
-            {currentChapterScript && (
-              <div className="space-y-5">
-                <AssessmentPanel chapter={currentChapterScript} />
-
-                {/* Choices */}
-                {choiceOptions && (
-                  <div className="mt-5">
-                    <h4 className="mb-3 font-heading text-xs font-medium uppercase tracking-wider text-dynasty-muted">
-                      Your Decision
-                    </h4>
-                    <ChoiceSelector
-                      options={choiceOptions}
-                      selectedId={selectedChoiceId}
-                      reaction={choiceReaction}
-                      onSelect={handleSelectChoice}
-                      onReactionComplete={handleReactionComplete}
-                    />
-                  </div>
-                )}
-
-                {/* Next chapter button */}
-                {canAdvance && (
-                  <div className="flex justify-end pt-3">
-                    <button
-                      type="button"
-                      onClick={handleNextChapter}
-                      className="flex items-center gap-2 rounded-lg bg-accent-primary px-5 py-2.5 font-heading text-sm font-semibold text-dynasty-bg transition-colors hover:bg-accent-primary/90"
-                    >
-                      {wizard.currentChapter < 7 ? 'Next Chapter' : 'Finish'}
-                      <ArrowRight className="h-4 w-4" />
-                    </button>
-                  </div>
-                )}
-              </div>
-            )}
-          </div>
-
-          {/* Right 30%: AGM panel */}
-          <div className="flex-[3] border-l border-dynasty-border pl-6">
-            <AGMPanel
-              profile={wizard.script.assistantProfile}
-              dialogueLines={agmDialogue}
-            />
-          </div>
-        </div>
-      </div>
-
-      {/* Progress bar */}
-      <div className="sticky bottom-0 border-t border-dynasty-border bg-dynasty-bg/95 px-6 py-3 backdrop-blur">
-        <div className="mx-auto flex max-w-6xl items-center justify-between">
-          <ChapterProgress currentChapter={wizard.currentChapter} />
-          <span className="font-data text-[11px] text-dynasty-muted">
-            Chapter {wizard.currentChapter + 1} of 8
-          </span>
-        </div>
-      </div>
-    </div>
-  );
-}
-
-// ---------------------------------------------------------------------------
-// Header
-// ---------------------------------------------------------------------------
-
-function Header({
-  agmName,
-  onSkip,
-  showSkip = true,
-}: {
-  agmName: string;
-  onSkip: () => void;
-  showSkip?: boolean;
-}) {
-  return (
-    <div className="sticky top-0 z-10 flex items-center justify-between border-b border-dynasty-border bg-dynasty-bg/95 px-6 py-3 backdrop-blur">
-      <div className="flex items-center gap-3">
-        <span className="font-brand text-lg text-accent-primary">MBD</span>
-        <span className="font-data text-xs text-dynasty-muted">&middot;</span>
-        <span className="font-heading text-sm text-dynasty-text">
-          First 10 Minutes with {agmName}
-        </span>
-      </div>
-      {showSkip && (
-        <button
-          type="button"
-          onClick={onSkip}
-          className="flex items-center gap-1.5 rounded border border-dynasty-border px-3 py-1.5 font-data text-xs text-dynasty-muted transition-colors hover:border-dynasty-text/30 hover:text-dynasty-text"
-        >
-          <SkipForward className="h-3.5 w-3.5" />
-          Skip
-        </button>
-      )}
-    </div>
-  );
-}

From 175a242b489df2dc9704a9daa28610968e00717a Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:33:36 -0500
Subject: [PATCH 3/7] chore(workspace): remove empty @mbd/test-utils package
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

packages/test-utils/src/index.ts was literally `export {};` — the
package contributed nothing and had zero workspace consumers. Dropping
it shrinks the workspace surface area and removes a dead entry from
knip's project map.

- Delete packages/test-utils/
- Remove the test-utils workspace entry from knip.json

The pnpm-workspace.yaml glob is `packages/*`, so removal happens
automatically once the directory is gone.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 knip.json                         |  4 ----
 packages/test-utils/package.json  | 18 ------------------
 packages/test-utils/src/index.ts  |  4 ----
 packages/test-utils/tsconfig.json |  9 ---------
 4 files changed, 35 deletions(-)
 delete mode 100644 packages/test-utils/package.json
 delete mode 100644 packages/test-utils/src/index.ts
 delete mode 100644 packages/test-utils/tsconfig.json

diff --git a/knip.json b/knip.json
index ba18101..d5fb16d 100644
--- a/knip.json
+++ b/knip.json
@@ -31,10 +31,6 @@
       ],
       "project": ["src/**/*.ts"]
     },
-    "packages/test-utils": {
-      "entry": ["src/index.ts"],
-      "project": ["src/**/*.ts"]
-    },
     "packages/ui": {
       "entry": [
         "src/index.ts",
diff --git a/packages/test-utils/package.json b/packages/test-utils/package.json
deleted file mode 100644
index 4aa6ac8..0000000
--- a/packages/test-utils/package.json
+++ /dev/null
@@ -1,18 +0,0 @@
-{
-  "name": "@mbd/test-utils",
-  "version": "0.0.1",
-  "private": true,
-  "type": "module",
-  "main": "src/index.ts",
-  "types": "src/index.ts",
-  "exports": {
-    ".": "./src/index.ts"
-  },
-  "scripts": {
-    "typecheck": "tsc --noEmit",
-    "build": "tsc -b"
-  },
-  "devDependencies": {
-    "typescript": "^5.7.0"
-  }
-}
diff --git a/packages/test-utils/src/index.ts b/packages/test-utils/src/index.ts
deleted file mode 100644
index e9863a6..0000000
--- a/packages/test-utils/src/index.ts
+++ /dev/null
@@ -1,4 +0,0 @@
-// @mbd/test-utils — shared testing utilities
-// Fixtures, mocks, and helpers for MBD test suites
-
-export {};
diff --git a/packages/test-utils/tsconfig.json b/packages/test-utils/tsconfig.json
deleted file mode 100644
index fb8e7bf..0000000
--- a/packages/test-utils/tsconfig.json
+++ /dev/null
@@ -1,9 +0,0 @@
-{
-  "extends": "../../tsconfig.base.json",
-  "compilerOptions": {
-    "rootDir": "src",
-    "lib": ["ES2022", "DOM", "DOM.Iterable"],
-    "jsx": "react-jsx"
-  },
-  "include": ["src/**/*.ts", "src/**/*.tsx"]
-}

From 028f8e40b1152326017b824c175390d25915a52a Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:33:45 -0500
Subject: [PATCH 4/7] test(contracts): add native v33 save fixture and
 round-trip assertions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The save fixture chain previously ended at v32, even though
CURRENT_GAME_SNAPSHOT_VERSION is 33. v32 -> v33 migration was tested
by promoting the v32 fixture, but no fixture exercised v33 directly.

This adds:
- packages/contracts/tests/fixtures/save/v33/core.json
  (the v32 fixture with schemaVersion bumped to 33 — v32 -> v33 is
   an additive enum expansion only, no field changes)
- A test that parsing a v33 fixture preserves the current schema
  without invoking a migration step.
- A test that the parsed snapshot round-trips through JSON without
  drift, defending against future migration regressions.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 .../tests/fixtures/save/v33/core.json         | 314 ++++++++++++++++++
 .../contracts/tests/save.migration.test.ts    |  18 +
 2 files changed, 332 insertions(+)
 create mode 100644 packages/contracts/tests/fixtures/save/v33/core.json

diff --git a/packages/contracts/tests/fixtures/save/v33/core.json b/packages/contracts/tests/fixtures/save/v33/core.json
new file mode 100644
index 0000000..e4ced28
--- /dev/null
+++ b/packages/contracts/tests/fixtures/save/v33/core.json
@@ -0,0 +1,314 @@
+{
+  "schemaVersion": 33,
+  "rng": {
+    "seed": 7,
+    "callCount": 14
+  },
+  "season": 3,
+  "day": 97,
+  "phase": "regular",
+  "userTeamId": "nym",
+  "players": [
+    {
+      "id": "11111111-1111-4111-8111-111111111111",
+      "firstName": "Alex",
+      "lastName": "Ramirez",
+      "age": 27,
+      "position": "SS",
+      "hitterAttributes": {
+        "contact": 330,
+        "power": 285,
+        "eye": 295,
+        "speed": 310,
+        "defense": 300,
+        "durability": 320
+      },
+      "pitcherAttributes": null,
+      "personality": {
+        "workEthic": 68,
+        "mentalToughness": 59,
+        "leadership": 52,
+        "competitiveness": 74
+      },
+      "contract": {
+        "years": 1,
+        "annualSalary": 4.2,
+        "totalValue": 4.2,
+        "noTradeClause": false,
+        "playerOption": false,
+        "teamOption": false
+      },
+      "rosterStatus": "MLB",
+      "developmentPhase": "Prime",
+      "teamId": "nym",
+      "nationality": "latin",
+      "overallRating": 312,
+      "rule5EligibleAfterSeason": 4,
+      "serviceTimeDays": 344,
+      "optionYearsUsed": 1,
+      "isOutOfOptions": false,
+      "minorLeagueLevel": null,
+      "arbitrationHistory": [],
+      "holdoutState": null,
+      "superTwoQualified": false,
+      "personalityTraits": [
+        "sparkplug"
+      ]
+    }
+  ],
+  "schedule": [],
+  "seasonState": {
+    "season": 3,
+    "currentDay": 97,
+    "standings": [],
+    "playerSeasonStats": [
+      [
+        "11111111-1111-4111-8111-111111111111",
+        {
+          "gamesPlayed": 14,
+          "pa": 58,
+          "ab": 50,
+          "hits": 18,
+          "doubles": 4,
+          "triples": 1,
+          "hr": 2,
+          "rbi": 9,
+          "bb": 7,
+          "k": 12,
+          "runs": 11,
+          "hbp": 0,
+          "sacFlies": 1,
+          "ip": 0,
+          "earnedRuns": 0,
+          "strikeouts": 0,
+          "walks": 0,
+          "hitsAllowed": 0,
+          "homeRunsAllowed": 0,
+          "hitBatters": 0,
+          "flyBallsAllowed": 0,
+          "wins": 0,
+          "saves": 0,
+          "losses": 0
+        }
+      ]
+    ],
+    "gameLog": [],
+    "completed": false
+  },
+  "playoffBracket": null,
+  "injuries": [],
+  "serviceTime": [
+    [
+      "11111111-1111-4111-8111-111111111111",
+      2
+    ]
+  ],
+  "scoutingStaffs": [],
+  "gmPersonalities": [],
+  "offseasonState": null,
+  "rule5Session": null,
+  "rule5Obligations": [],
+  "rule5OfferBackStates": [],
+  "draftClass": null,
+  "freeAgencyMarket": null,
+  "news": [],
+  "rosterStates": [],
+  "coachingStaffs": [],
+  "coachFreeAgentPool": [],
+  "narrative": {
+    "playerMorale": [],
+    "teamChemistry": [],
+    "ownerState": [],
+    "briefingQueue": [],
+    "storyFlags": [],
+    "rivalries": [],
+    "tickerFeed": [],
+    "playerMoments": [
+      [
+        "11111111-1111-4111-8111-111111111111",
+        [
+          {
+            "season": 3,
+            "day": 182,
+            "timestamp": "S3D182",
+            "type": "redemption_arc",
+            "description": "Alex Ramirez authored a rebound season front offices wait around to see.",
+            "impact": 56,
+            "relevance": 0.88,
+            "isPlayoff": false,
+            "isEliminationGame": false,
+            "worldSeriesClincher": false,
+            "round": null
+          }
+        ]
+      ]
+    ],
+    "teamMoments": [
+      [
+        "nym",
+        [
+          {
+            "season": 2,
+            "day": 182,
+            "timestamp": "S2D182",
+            "type": "first_dynasty_peak",
+            "description": "Back-to-back division titles gave the club a real franchise identity.",
+            "impact": 55,
+            "relevance": 0.95,
+            "isPlayoff": false,
+            "isEliminationGame": false,
+            "worldSeriesClincher": false,
+            "round": null
+          },
+          {
+            "season": 3,
+            "day": 182,
+            "timestamp": "S3D182",
+            "type": "rivalry_renewed",
+            "description": "The rivalry roared back when both clubs reached the finish line in contention.",
+            "impact": 58,
+            "relevance": 0.84,
+            "isPlayoff": false,
+            "isEliminationGame": false,
+            "worldSeriesClincher": false,
+            "round": null
+          }
+        ]
+      ]
+    ],
+    "playerNicknames": [],
+    "playerStoryArcs": [],
+    "prospectBonds": [],
+    "gmRelationships": [],
+    "leagueEvents": [],
+    "playerOrigins": [],
+    "debutFlashbacks": [],
+    "awardHistory": [],
+    "hallOfFame": [],
+    "hallOfFameBallot": [],
+    "franchiseTimeline": [],
+    "careerStats": [],
+    "recordBook": [],
+    "recordWatch": [],
+    "seasonArchive": [],
+    "archivedSeasons": [],
+    "historicalPlayers": [],
+    "mentorRelationships": [],
+    "frontOfficeState": [],
+    "whatIfBranches": [],
+    "seasonHistory": [
+      {
+        "season": 2,
+        "championTeamId": "nym",
+        "runnerUpTeamId": "lax",
+        "worldSeriesRecord": "4-2",
+        "summary": "New York finished the job.",
+        "awards": [],
+        "keyMoments": [
+          "Won the World Series in six games."
+        ],
+        "statLeaders": {
+          "hr": [],
+          "rbi": [],
+          "avg": [],
+          "era": [],
+          "k": [],
+          "w": []
+        },
+        "notableRetirements": [],
+        "blockbusterTrades": [],
+        "userSeason": null
+      }
+    ]
+  },
+  "tradeState": {
+    "pendingOffers": [],
+    "tradeHistory": [],
+    "negotiations": [],
+    "multiTeamPendingTrades": []
+  },
+  "internationalScoutingState": {
+    "season": 3,
+    "ifaPool": [],
+    "budgets": [],
+    "scoutingHistory": []
+  },
+  "draftState": {
+    "scoutingReports": [],
+    "signability": [],
+    "qualifyingOffers": [],
+    "compensatoryPicks": [],
+    "pickOwnership": [],
+    "bigBoards": [],
+    "signingDecisions": []
+  },
+  "minorLeagueState": {
+    "serviceTimeLedger": [],
+    "optionUsage": [],
+    "waiverClaims": [],
+    "affiliateStates": [],
+    "affiliateBoxScores": [],
+    "minorLeagueStatHistory": [],
+    "activeDevelopmentSetbacks": [],
+    "processedDevelopmentMonths": [],
+    "developmentLedger": [],
+    "developmentReports": [],
+    "conversionRecommendations": []
+  },
+  "monthlyPulse": {
+    "pendingReport": null,
+    "decisionQueue": []
+  },
+  "franchise": {
+    "gmName": "General Manager",
+    "difficulty": "standard",
+    "playMode": "standard",
+    "createdAt": "S3D97",
+    "teamId": "nym",
+    "teamName": "New York Tycoons",
+    "teamAbbreviation": "NYT",
+    "teamDivision": "AL East",
+    "onboarding": {
+      "welcomeBriefingSeen": true,
+      "firstMonthlyPulseSeen": true
+    },
+    "assistantGMId": "marcus_chen",
+    "gmPhilosophy": {
+      "seasonGoal": "playoff",
+      "developmentStyle": "balanced",
+      "spendingStyle": "balanced",
+      "tradeApproach": "opportunistic",
+      "scoutingFocus": "draft",
+      "mediaTone": "measured"
+    },
+    "scoutingDirector": null,
+    "dayOne": {
+      "experience": "quick",
+      "status": "complete",
+      "currentStep": "complete",
+      "selectedAGMId": "marcus_chen",
+      "seasonGoal": "playoff",
+      "budgetAllocation": null,
+      "developmentStyle": "balanced",
+      "promotionStance": "measured",
+      "openingDayPlan": null,
+      "crisisType": null,
+      "crisisResponseId": null,
+      "quickStartRecapSeen": true
+    }
+  },
+  "ceremony": {
+    "pendingMoments": [],
+    "seenMomentIds": []
+  },
+  "achievements": {
+    "unlocked": [],
+    "progress": [],
+    "counters": [],
+    "ledgers": []
+  },
+  "performanceDiagnostics": {
+    "totalSeasons": 3,
+    "snapshotSizeBytes": 512
+  }
+}
diff --git a/packages/contracts/tests/save.migration.test.ts b/packages/contracts/tests/save.migration.test.ts
index f332bf4..ad293fe 100644
--- a/packages/contracts/tests/save.migration.test.ts
+++ b/packages/contracts/tests/save.migration.test.ts
@@ -327,6 +327,24 @@ describe('save schema migration', () => {
     ]);
   });
 
+  it('parses a current-schema v33 fixture without applying a migration', () => {
+    const fixture = loadFixture('./fixtures/save/v33/core.json');
+
+    const parsed = parseGameSnapshot(fixture);
+
+    expect(parsed.schemaVersion).toBe(CURRENT_GAME_SNAPSHOT_VERSION);
+    expect(fixture.schemaVersion).toBe(CURRENT_GAME_SNAPSHOT_VERSION);
+  });
+
+  it('round-trips a current-schema snapshot through JSON without drift', () => {
+    const fixture = loadFixture('./fixtures/save/v33/core.json');
+
+    const first = parseGameSnapshot(fixture);
+    const second = parseGameSnapshot(JSON.parse(JSON.stringify(first)));
+
+    expect(second).toEqual(first);
+  });
+
   it('rejects malformed legacy fixtures during migration', () => {
     const fixture = loadFixture('./fixtures/save/v18/core.json');
     fixture.players[0].id = 7;

From be852b9cae24490aac25495dd6b0ad03fac92b63 Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:33:54 -0500
Subject: [PATCH 5/7] feat(playtest): add calibration dump script + surface
 playtest at root
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Wires the existing sim-core calibration harness (runSeasonCalibration +
summarizeSeasonCalibration) into a one-command developer workflow:

- packages/sim-core/tests/calibrationDump.generate.ts
  Gated by MBD_PLAYTEST_DUMP=1 (same convention as the existing
  playtestNarrativeDump.generate.ts). Writes a markdown summary of
  league-wide batting line, payroll, win distribution, and per-season
  metrics for the given seed.
- packages/sim-core/package.json adds `playtest:calibrate`.
- Root package.json surfaces three passthroughs:
  - `pnpm playtest`           — full narrative dump
  - `pnpm playtest:sample`    — canonical sample-dynasty dump
  - `pnpm playtest:calibrate` — calibration metrics dump

Env vars accepted by the calibrate script (all optional):
  PLAYTEST_SEED, PLAYTEST_YEARS, PLAYTEST_OUT

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 package.json                                  |  5 +-
 packages/sim-core/package.json                |  1 +
 .../tests/calibrationDump.generate.ts         | 69 +++++++++++++++++++
 3 files changed, 74 insertions(+), 1 deletion(-)
 create mode 100644 packages/sim-core/tests/calibrationDump.generate.ts

diff --git a/package.json b/package.json
index ffa6b74..c2299ef 100644
--- a/package.json
+++ b/package.json
@@ -17,7 +17,10 @@
     "verify:structure": "knip --no-exit-code",
     "verify:cycles": "madge --circular --extensions ts,tsx --ts-config tsconfig.json packages/sim-core/src apps/web/src || true",
     "verify:determinism": "cd packages/sim-core && node ./node_modules/vitest/vitest.mjs run tests/determinism.snapshot.test.ts",
-    "verify:quality": "pnpm run verify:structure && pnpm run verify:cycles && pnpm run verify:determinism"
+    "verify:quality": "pnpm run verify:structure && pnpm run verify:cycles && pnpm run verify:determinism",
+    "playtest": "pnpm --filter @mbd/sim-core run playtest",
+    "playtest:sample": "pnpm --filter @mbd/sim-core run playtest:sample",
+    "playtest:calibrate": "pnpm --filter @mbd/sim-core run playtest:calibrate"
   },
   "devDependencies": {
     "knip": "^6.4.1",
diff --git a/packages/sim-core/package.json b/packages/sim-core/package.json
index 9f806ca..49c3cc4 100644
--- a/packages/sim-core/package.json
+++ b/packages/sim-core/package.json
@@ -13,6 +13,7 @@
     "test": "vitest run",
     "playtest": "MBD_PLAYTEST_DUMP=1 vitest run tests/playtestNarrativeDump.generate.ts",
     "playtest:sample": "PLAYTEST_SEED=2601 PLAYTEST_YEARS=10 PLAYTEST_OUT=playtest-output/sample-dynasty.md MBD_PLAYTEST_DUMP=1 vitest run tests/playtestNarrativeDump.generate.ts",
+    "playtest:calibrate": "MBD_PLAYTEST_DUMP=1 vitest run tests/calibrationDump.generate.ts",
     "build": "tsc -b"
   },
   "dependencies": {
diff --git a/packages/sim-core/tests/calibrationDump.generate.ts b/packages/sim-core/tests/calibrationDump.generate.ts
new file mode 100644
index 0000000..08eb6dc
--- /dev/null
+++ b/packages/sim-core/tests/calibrationDump.generate.ts
@@ -0,0 +1,69 @@
+// @vitest-environment node
+
+import { mkdir, writeFile } from 'node:fs/promises';
+import { dirname, resolve } from 'node:path';
+import { describe, expect, it } from 'vitest';
+import {
+  runSeasonCalibration,
+  summarizeSeasonCalibration,
+} from '../src/index.js';
+
+const DEFAULT_SEED = 44_001;
+const DEFAULT_SEASONS = 1;
+const DEFAULT_OUT = 'playtest-output/calibration.md';
+
+function pickEnv(name: string, fallback: string): string {
+  return process.env[name] ?? fallback;
+}
+
+function formatRow(label: string, value: number | string): string {
+  return `| ${label} | ${typeof value === 'number' ? value.toFixed(3) : value} |`;
+}
+
+function buildMarkdown(seed: number, seasons: number): string {
+  const result = runSeasonCalibration({ seed, seasonCount: seasons });
+  const summary = summarizeSeasonCalibration(result);
+
+  const lines: string[] = [];
+  lines.push(`# Calibration Dump — seed ${seed}, ${seasons} season${seasons === 1 ? '' : 's'}`);
+  lines.push('');
+  lines.push('| Metric | Value |');
+  lines.push('| --- | --- |');
+  lines.push(formatRow('Total games', summary.totalGames));
+  lines.push(formatRow('Avg runs per game', summary.averageRunsPerGame));
+  lines.push(formatRow('Avg team wins', summary.averageTeamWins));
+  lines.push(formatRow('Team win spread', summary.teamWinSpread));
+  lines.push(formatRow('Avg total MLB payroll ($M)', summary.averageTotalMlbPayroll));
+  lines.push(formatRow('Avg MLB salary ($M)', summary.averageMlbSalary));
+  lines.push(formatRow('League batting average', summary.battingAverage));
+  lines.push(formatRow('League OBP', summary.onBasePercentage));
+  lines.push(formatRow('League SLG', summary.sluggingPercentage));
+  lines.push(formatRow('League OPS', summary.ops));
+  lines.push('');
+  lines.push('## Seasons');
+  lines.push('');
+  lines.push('| Season | Games | R/G | Avg Wins | Spread | Payroll ($M) | Avg Salary ($M) |');
+  lines.push('| --- | --- | --- | --- | --- | --- | --- |');
+  for (const season of summary.seasons) {
+    lines.push(`| ${season.season} | ${season.gamesPlayed} | ${season.averageRunsPerGame.toFixed(3)} | ${season.averageTeamWins.toFixed(2)} | ${season.teamWinSpread} | ${season.totalMlbPayroll.toFixed(0)} | ${season.averageMlbSalary.toFixed(2)} |`);
+  }
+  lines.push('');
+
+  return lines.join('\n');
+}
+
+describe('calibration dump', () => {
+  it('writes a calibration summary when MBD_PLAYTEST_DUMP is set', async () => {
+    const seed = Number(pickEnv('PLAYTEST_SEED', String(DEFAULT_SEED)));
+    const seasons = Number(pickEnv('PLAYTEST_YEARS', String(DEFAULT_SEASONS)));
+    const out = pickEnv('PLAYTEST_OUT', DEFAULT_OUT);
+
+    const markdown = buildMarkdown(seed, seasons);
+    const path = resolve(process.cwd(), out);
+    await mkdir(dirname(path), { recursive: true });
+    await writeFile(path, markdown, 'utf8');
+
+    expect(markdown).toContain('Calibration Dump');
+    expect(markdown).toContain('Total games');
+  }, 60_000);
+});

From ff2176facc2aace4885e87d22a76c2e3ecedca28 Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:34:03 -0500
Subject: [PATCH 6/7] docs(bundle): migrate worker-chunk lift journal to
 BUDGETS.md

bundleConfig.ts had accumulated ~80 lines of inline comments
documenting every worker-chunk ceiling lift from 406 KB / 124 KB up to
the current 443 KB / 143 KB. The narrative was valuable but buried the
actual exported constants.

- Move the per-slice lift rationale into apps/web/docs/BUDGETS.md.
- Preserve the lift policy (smallest safe lift, CI vs local terser
  drift, route-before-lift discipline).
- Preserve the 24-entry timeline as a table.
- Replace the in-source journal with a single pointer comment.

bundleConfig.ts: 325 -> 161 lines. No exported constants moved.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 apps/web/docs/BUDGETS.md           |  64 +++++++++++
 apps/web/src/build/bundleConfig.ts | 167 +----------------------------
 2 files changed, 66 insertions(+), 165 deletions(-)
 create mode 100644 apps/web/docs/BUDGETS.md

diff --git a/apps/web/docs/BUDGETS.md b/apps/web/docs/BUDGETS.md
new file mode 100644
index 0000000..bb0cce8
--- /dev/null
+++ b/apps/web/docs/BUDGETS.md
@@ -0,0 +1,64 @@
+# Bundle Budgets — MBD Web App
+
+Source of truth for ceilings lives in [`apps/web/src/build/bundleConfig.ts`](../src/build/bundleConfig.ts). This file documents the *why* behind each lift and the policy.
+
+## Current ceilings
+
+| Chunk class | Raw | Gzip |
+| --- | --- | --- |
+| Main-thread chunk | 304 KB | 81 KB |
+| Worker chunk | 443 KB | 143 KB |
+| Chart vendor (lazy `vendor-charts`) | 430 KB | 120 KB |
+
+The main-thread chunk caps have not moved since launch — `MAIN_THREAD_CHUNK_BUDGET_BYTES` / `MAIN_THREAD_CHUNK_GZIP_BUDGET_BYTES` are deliberately frozen so any new app code that lands on the main thread surfaces as a regression in `bundleBudget.test.ts`.
+
+## Lift policy
+
+1. **Smallest safe lift.** A slice ships with the minimum cap move that restores headroom. No round-number gifting.
+2. **Raw and gzip move independently.** A copy-heavy story slice usually only needs gzip; a wire-only worker slice usually only needs raw.
+3. **Chunk routing first, ceiling lift second.** Before lifting a cap, check whether routing the new module into a different chunk (e.g. moving narrative prose into `game-engine-story` or `game-engine-capstone`) keeps `game-engine-core` lean.
+4. **CI vs. local terser drift.** Local builds typically emit `game-engine-core` ~250–500 bytes smaller than CI. Lifts must include headroom for that drift; otherwise the budget test goes red only in CI.
+5. **Document the rationale in the PR.** This file gets the *why*; the journal below records milestones.
+
+## Worker chunk lift timeline
+
+| Cap (raw / gzip) | Slice | Cause |
+| --- | --- | --- |
+| 406 / 124 KB | (pre-arbitration baseline) | — |
+| 408 / 125 KB | Arbitration broadcast | Arbitration press-conference templates + moment descriptions. Smallest safe gzip lift after copy trim. |
+| 410 / 126 KB | Holdout briefings + trade-deadline press | `generateHoldoutResolutionBriefing` and trade-deadline press copy. Raw-only lift first, gzip moved a tick later when trade-deadline copy crossed the cap by 471 bytes. |
+| 411 / 126 KB | Team-moment store (v22) | `appendTeamMoments` + `teamMoments` map on `FullGameState` + identityMoments seam through `buildTradeBroadcastCoverage`. Wire-only. |
+| 412 / 126 KB | Chase Watch query | `getChaseWatch()` assembling milestone alerts + pace chases. Pure aggregation. |
+| 414 / 126 KB | Pennant-race-heat query | `getPennantRaces` with division race + wildcard bubble. |
+| 417 / 127 KB | Team-moment types (v23) | `detectSeasonIdentityMoments` + `championship_run` / `contention_collapse` enum + description templates. |
+| 420 / 127 KB | Career Retrospective query | `buildCareerRetrospective` unifying titles, beats, story arcs, awards, top rivalry. |
+| 423 / 127 KB | Season Story Reel query | `buildSeasonStoryReel` per-season deep-dive. |
+| 425 / 127 KB | Pennant Race Detail query | `getPennantRaceDetail` all-six-divisions + top-5 wildcard. |
+| 425 / 128 KB | Team-identity wave 2 (v25) | `rebuild_begun` + `breakout_season` + `contention_window_opens` detectors. Gzip-only lift. |
+| 428 / 131 KB | Narrative depth wave 3 (v26) | Additive detector/template expansion. Sprint hard cap. |
+| 428 / 132 KB | CI terser drift recovery | One KB gzip lift to absorb a +534-byte CI vs. local minifier drift on an unchanged commit. |
+| 432 / 134 KB | Narrative depth wave 4 (v27) | Persisted-state fidelity + playoff comeback tracking. |
+| 433 / 134 KB | Career Retrospective season-history | `seasonHistory` derivation. Raw-only. |
+| 434 / 135 KB | Codex narrative-prose reservation | Headroom reserved for parallel `codex/narrative-prose-expansion` branch (deterministic prose variant pools). |
+| 434 / 137 KB | Codex narrative-prose landing | Lift confirmed after rivalry-wave1 (PR #50) stacked with prose pools in `game-engine-core`. |
+| 436 / 137 KB | This Week in History query | `getThisWeekInHistory` over persisted moments maps. Raw-only. |
+| 438 / 137 KB | Player Arcs of the Season query | `getPlayerArcsOfSeason` filtering redemption_arc / late_career_peak / rookie_breakout. Raw-only. |
+| 439 / 139 KB | Narrative depth wave 6 | Dynasty-marker worker wiring + new prose pools. |
+| 439 / 141 KB | Narrative depth wave 7 | Position-group moment detectors (`dominant_rotation` / `bullpen_collapse` / `lineup_of_era`). Gzip-only. |
+| 440 / 143 KB | Narrative depth wave 8 | Player micro-arc worker source plumbing. |
+| 442 / 143 KB | Narrative depth wave 9 | Weekly cadence detectors split into `game-engine-weekly` to protect `game-engine-core`. |
+| 443 / 143 KB | Narrative depth wave 10 (current) | Capstone prose split into `game-engine-capstone`. |
+
+## Notes on routing
+
+Routing changes that have paid off:
+
+- **`game-engine-onboarding`** isolates the Day-1 flow so it never lands in `game-engine-core`.
+- **`game-engine-story`** absorbs holdout coverage and worker-only narrative payload, leaving the deterministic core lean.
+- **`game-engine-capstone`** (Wave 10) splits award / HOF / retirement / stable prose variant pools from the core.
+- **`game-engine-weekly`** (Wave 9) splits weekly cadence detectors + prose.
+- **`game-engine-shell`** holds only the Comlink entry point and the sim-core root barrel, preventing circular chunk edges between `game-engine-core` and `game-engine-onboarding`.
+
+Routing changes that did *not* pay off:
+
+- Routing `tradeDeadlinePressConferences.ts` into `game-engine-story` pushed story over its own cap (421,762 raw / 125,530 gzip). The smaller ceiling lift on core was the safer fix.
diff --git a/apps/web/src/build/bundleConfig.ts b/apps/web/src/build/bundleConfig.ts
index 6fb3e97..ac04f9c 100644
--- a/apps/web/src/build/bundleConfig.ts
+++ b/apps/web/src/build/bundleConfig.ts
@@ -1,170 +1,7 @@
 export const MAIN_THREAD_CHUNK_BUDGET_BYTES = 304 * 1024;
 export const MAIN_THREAD_CHUNK_GZIP_BUDGET_BYTES = 81 * 1024;
-// WORKER raw: bumped 406 -> 408 KB to cover the arbitration payload carried across
-// the arbitration schema/broadcast slices.
-// WORKER raw: bumped 408 -> 410 KB for the holdout resolution news slice. Adds
-// generateHoldoutResolutionBriefing + worker wire-in alongside the existing
-// opening-beat briefings in game-engine-story. Copy was trimmed aggressively but
-// the function signature + constants still landed ~1.3 KB over the prior raw
-// ceiling. Gzip stayed at ~125 KB (well under budget), so the actual wire cost
-// is unchanged — this is a raw-ceiling-only concession for the new helper.
-// WORKER gzip: bumped 124 -> 125 KB for the arbitration broadcast slice. The
-// arbitration press-conference templates + moment descriptions compressed less
-// than projected (actual ~+0.4 KB over prior ceiling), so lift the gzip roof by
-// one KB to restore headroom. Holdout briefings already live in the story chunk.
-// WORKER gzip: bumped 125 -> 126 KB for the trade deadline broadcast slice after
-// the new trade press-conference copy left game-engine-core 471 bytes over the
-// prior gzip cap. Attempted routing tradeDeadlinePressConferences.ts into
-// game-engine-story first, but that pushed story far higher overall (421,762
-// raw / 125,530 gzip), so the smallest ceiling lift was the safer fix. Raw
-// ceiling already at 410 KB from the holdout briefing slice accommodates the
-// trade deadline worker growth (+613 bytes over the 408 baseline).
-// WORKER raw: bumped 410 -> 411 KB for the team-moment store slice (v22). Adds
-// appendTeamMoments, the teamMoments Map on FullGameState, the identityMoments
-// seam through buildTradeBroadcastCoverage, and snapshot serialization of
-// teamMoments. Story chunk landed ~206 bytes over the 410 KB ceiling after the
-// wiring; gzip held well under cap (~125 KB actual vs 126 KB ceiling) so only
-// raw moves. No new template copy — just wire-in code.
-// WORKER raw: bumped 411 -> 412 KB for the Chase Watch query slice. Adds
-// getChaseWatch() to sim.worker.queries.ts — a league-wide view assembling
-// career milestone alerts (via existing buildMilestoneAlertsForPlayers) and
-// pace chases (via existing projectSeasonStats + findNotableProjections) into
-// a single dashboard payload. Pure wiring of existing helpers, no new sim
-// logic. Story chunk landed 547 bytes over the 411 KB ceiling; gzip held
-// under cap (~125 KB actual vs 126 KB ceiling) so only raw moves.
-// WORKER raw: bumped 412 -> 414 KB for the pennant-race-heat query slice.
-// Adds getPennantRaces with division race + wildcard bubble computations
-// plus inline DivisionRace/WildcardRace types. Story chunk landed ~1 KB
-// over the 413 KB stack when combined with Chase Watch growth; gzip held
-// well under cap (~126 KB actual) — wire cost unchanged, raw ceiling only.
-// No new sim-core changes.
-// WORKER raw: award race boards slice — adds getAwardRaceBoards
-// (league-split + sample-size-filtered enrichment around the existing
-// calculateAwardRaces scorer) into the story chunk. Absorbed within the
-// current 414 KB ceiling from the pennant-race stack; gzip held well under
-// cap (~126 KB actual vs 126 KB ceiling) — no new sim-core changes.
-// WORKER raw: bumped 414 -> 417 KB for the team-moment types slice (v23).
-// Adds detectSeasonIdentityMoments + championship_run / contention_collapse
-// enum values + MOMENT_TYPE_ORDER and description template entries. When
-// stacked on top of the dashboard query slices (chase/pennant/award), the
-// story chunk landed ~1.6 KB over the 414 KB ceiling — raw lift with a
-// small headroom buffer. Gzip also bumped 126 -> 127 KB; copy compressed
-// ~296 bytes over the prior cap.
-// WORKER raw: bumped 417 -> 420 KB for the Career Retrospective query slice.
-// Adds buildCareerRetrospective + getCareerRetrospective to sim.worker.queries
-// — unifies titles (WS/pennants/division/playoffs derived from seasonArchive +
-// archivedSeasons), team-moment beats, completed story arcs, awards-shelf
-// counts, and top rivalry into one dashboard payload. Story chunk landed
-// ~2.5 KB over the 417 KB ceiling; gzip held under cap (~125 KB actual vs
-// 127 KB ceiling).
-// WORKER raw: bumped 420 -> 423 KB for the Season Story Reel query slice.
-// Adds buildSeasonStoryReel + getSeasonStoryReel — per-season deep-dive
-// assembling record/rank, playoff path, storylines, timeline events, signature
-// beats filtered by season, key transactions, awards, and stat-leader
-// highlights from seasonArchive + archivedSeasons. Story chunk landed ~2.2 KB
-// over the 420 KB ceiling; gzip held under cap (~125.8 KB actual vs 127 KB
-// ceiling). Raw-only lift.
-// WORKER raw: bumped 423 -> 425 KB for the Pennant Race Detail query slice.
-// Adds getPennantRaceDetail — all-six-divisions full standings + top-5
-// wildcard picture with projectedWins via winning-percentage pace. Story
-// chunk landed ~1.5 KB over the 423 KB ceiling; gzip held under cap
-// (~126.4 KB actual vs 127 KB ceiling). Raw-only lift.
-// WORKER gzip: bumped 127 -> 128 KB for team-identity expansion wave 2 (v25).
-// Adds rebuild_begun + breakout_season + contention_window_opens detectors with
-// their MOMENT_TYPE_ORDER entries and description templates. game-engine-core
-// landed at 130,174 gzip bytes vs the prior 130,048 cap (+126 bytes), so the
-// smallest safe lift is one KB. Raw ceiling already at 425 KB from PR #44's
-// Pennant Race detail query absorbs the wave-2 detector code with headroom.
-// WORKER raw/gzip: bumped 425 -> 428 KB raw and 128 -> 131 KB gzip for
-// narrative depth wave 3 (v26). The additive detector/template expansion kept
-// game-engine-core raw under the existing ceiling (~399 KB) but pushed gzip to
-// 133,864 bytes; game-engine-story stayed under gzip but landed at 437,490 raw
-// bytes. This is the maximum sprint-allowed lift (+3 KB raw / +3 KB gzip),
-// preserving the hard stop at 430 KB raw / 131 KB gzip.
-// WORKER gzip: bumped 131 -> 132 KB for CI/local terser-output drift. Local
-// verify showed game-engine-core at 133,864 gzip bytes; CI minifier emitted
-// 134,398 bytes for the identical commit (+534 byte environmental drift),
-// which tripped the 131 KB cap (134,144) by 254 bytes. One KB lift restores
-// headroom for the already-landed wave-3 payload without touching any code.
-// WORKER raw/gzip: bumped 428 -> 432 KB raw and 132 -> 134 KB gzip for
-// narrative depth wave 4 (v27). The persisted-state fidelity sprint added
-// worker-side snapshot/state plumbing plus playoff comeback tracking, pushing
-// the measured worker chunks to 415,354 raw / 136,054 gzip for
-// game-engine-core and 442,235 raw / 131,714 gzip for game-engine-story.
-// This lands exactly at the sprint hard cap and restores bundleBudget headroom
-// without exceeding the approved +4 KB raw / +2 KB gzip ceiling.
-// WORKER raw: bumped 432 -> 433 KB for the Career Retrospective season-history
-// slice. Extends buildCareerRetrospective with seasonHistory derivation (user
-// team per-season win% from seasonArchive + archivedSeasons, deduped by
-// season). Story chunk landed 442,727 raw bytes (+359 over the 432 KB cap);
-// gzip held at 131,941 (well under the 134 KB ceiling) so only raw moves.
-// Pure aggregation of existing persisted state — no sim-core changes.
-// WORKER raw/gzip: bumped 433 -> 434 KB raw and 134 -> 135 KB gzip to reserve
-// headroom for the parallel codex/narrative-prose-expansion branch landing
-// alongside this branch. That branch adds deterministic prose variant pools
-// to holdoutCoverage / consequences / narrativeState / storyArcs with no
-// threshold/ID/schema changes (+4 sim-core tests, determinism sweep clean).
-// Measured combined story chunk (Claude season-history + Codex prose) at
-// 443,379 raw / 131,595 gzip local; CI-buffered gzip measurement via zlib
-// gzipSync lands at 137,334 (+118 over the prior 134 KB cap, matches the
-// known +250-500 byte game-engine-core terser drift pattern in patterns.md).
-// Smallest safe simultaneous lift: +1 KB raw / +1 KB gzip, giving ~1 KB
-// headroom on both ceilings for either-or-both-branch merge paths. If the
-// Codex branch is not ultimately merged, this reservation becomes slack but
-// is bounded to one KB on each axis.
-// WORKER gzip: bumped 135 -> 137 KB for the codex/narrative-prose-expansion
-// landing after codex/rivalry-narrative-wave1 already merged its rivalry
-// prose pools into game-engine-core (PR #50, commit 2806d37). The original
-// 135 reservation was measured against rivalry-wave1 NOT being on main; once
-// that landed, rivalry prose + narrative-prose-expansion's owner/consequences/
-// storyArcs pools stacked in the same chunk. Post-rebase measurement on this
-// branch: game-engine-core gzip 138,815 (+575 over 135 KB cap). +2 KB lift
-// covers the stack plus the established +250-500 byte CI terser drift. Raw
-// stayed comfortably under: game-engine-core raw 423,076 vs 444,416 cap.
-// WORKER raw: bumped 434 -> 436 KB for the This Week in History query slice.
-// Adds getThisWeekInHistory to sim.worker.queries — computes yearsAgo and
-// strict-prior-season ±dayWindow filtering over persisted playerMoments /
-// teamMoments Maps for the dashboard tile. Pure read wiring, no sim-core
-// touch. Story chunk landed 445,537 raw bytes (+1,121 over the 434 KB cap);
-// gzip held well under cap (132,609 actual vs 140,288 ceiling). +2 KB raw
-// lift gives ~900 bytes headroom against the established +250-500 byte
-// CI terser drift. Raw-only; no gzip ceiling move needed.
-// WORKER raw: bumped 436 -> 438 KB for the Player Arcs of the Season query
-// slice. Adds getPlayerArcsOfSeason to sim.worker.queries — filters persisted
-// playerMoments for redemption_arc / late_career_peak / rookie_breakout and
-// surfaces the most recent season's arcs for the dashboard tile. Pure read
-// wiring of existing player-arc moment state (PR #55), no sim-core touch.
-// Story chunk landed 446,889 raw bytes (+425 over the 436 KB cap); gzip held
-// well under cap (132,865 actual vs 140,288 ceiling). +2 KB raw lift gives
-// ~1,599 bytes headroom for CI terser drift. Raw-only; no gzip move needed.
-// WORKER raw/gzip: bumped 438 -> 439 KB raw and 137 -> 139 KB gzip for
-// Narrative Depth Wave 6. The dynasty-marker worker wiring moved enough
-// season-summary/detector orchestration into game-engine-story to leave the
-// chunk 66 bytes over the prior raw ceiling (448,578 vs 448,512), while the
-// new prose pools and detector exports expand the worker-compressed footprint.
-// Smallest safe lift: +1 KB raw / +2 KB gzip, preserving sub-1 KB local
-// headroom on story while leaving the broader worker budget effectively flat.
-// WORKER gzip: bumped 139 -> 141 KB for Narrative Depth Wave 7. Position-group
-// moment detectors add team aggregate helpers plus deterministic prose pools
-// for dominant_rotation / bullpen_collapse / lineup_of_era. Local budget test
-// measured game-engine-core at 142,927 gzip bytes, 591 bytes over the 139 KB
-// cap. Raw stayed under the existing 439 KB ceiling (440,242 vs 449,536), so
-// only the pre-authorized +2 KB gzip lift is applied.
-// WORKER raw/gzip: bumped 439 -> 440 KB raw and 141 -> 143 KB gzip for
-// Narrative Depth Wave 8. Player micro-arc worker source plumbing was trimmed
-// before lifting the cap; local build lands game-engine-story just under the
-// 440 KB raw ceiling and game-engine-core at 145,118 gzip bytes, covered by
-// the pre-authorized +2 KB gzip headroom.
-// WORKER raw: bumped 440 -> 442 KB for Narrative Depth Wave 9. Weekly cadence
-// detector/prose modules are split into game-engine-weekly to protect
-// game-engine-core; the remaining worker checkpoint wiring leaves
-// game-engine-story ~0.6 KB over the Wave 8 raw cap. +2 KB raw stays within
-// the pre-authorized Wave 9 lift and leaves modest minifier-drift headroom.
-// WORKER raw: bumped 442 -> 443 KB for Narrative Depth Wave 10. The capstone
-// prose variant pools are split into game-engine-capstone to keep
-// game-engine-core under budget; the remaining award/HOF/retirement worker
-// context wiring leaves game-engine-story at 452,887 raw bytes (+279 over the
-// Wave 9 cap). Gzip stayed under the existing 143 KB ceiling (134,439 bytes).
+
+// Worker ceilings: see apps/web/docs/BUDGETS.md for the lift policy and per-slice rationale.
 export const WORKER_CHUNK_BUDGET_BYTES = 443 * 1024;
 export const WORKER_CHUNK_GZIP_BUDGET_BYTES = 143 * 1024;
 

From 77e4769bb76594644d6e3d3dabf9d47d2e88038d Mon Sep 17 00:00:00 2001
From: Claude Code <noreply@anthropic.com>
Date: Thu, 14 May 2026 16:34:12 -0500
Subject: [PATCH 7/7] chore(deps): refresh pnpm-lock.yaml after test-utils
 removal

Drops the test-utils workspace entry from the lockfile. No package
versions change.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 pnpm-lock.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 20554b5..ffc35b2 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -147,12 +147,6 @@ importers:
         specifier: ^3.0.0
         version: 3.2.4(jiti@2.6.1)(jsdom@29.0.1)(terser@5.46.1)(yaml@2.8.3)
 
-  packages/test-utils:
-    devDependencies:
-      typescript:
-        specifier: ^5.7.0
-        version: 5.9.3
-
   packages/ui:
     dependencies:
       '@mbd/design-tokens':