Skip to content

Allow disabling the video_book filter #2

@MChartier

Description

@MChartier

Summary

lg fetch and lg sync always send video_book=true because the CLI only exposes a --video-book flag with a default of true. There is no matching --no-video-book, so disabling the filter is impossible.

Steps to Reproduce

  1. Run node lg.mjs fetch --enrollment fake --no-video-book.
  2. Commander throws error: unknown option '--no-video-book'.

Expected Result

Users should be able to opt out of the video book filter, e.g. with --no-video-book.

Actual Result

The command exits before running, so there is no way to request reports without video book content.

Additional Context

The option is defined in lg.mjs (lines ~88 and ~142). Commander only generates the negative form if we register it explicitly. Adding .option("--no-video-book", "skip adding video_book=true") (and handling the boolean in the action) would unblock the scenario.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions