Skip to content

Question about the BIC of Defects4J Math-74b #3

@agb94

Description

@agb94

Hello :)

First, thanks for providing this dataset publicly.
While I was looking into the defects4j bug inducing commits,
I found that the code lines changed by the identified bug inducing commit of Math-74 (commit hash: c95eb0b)
are not executed by the failure triggering test case of the fault (org.apache.commons.math.ode.nonstiff.AdamsMoultonIntegratorTest:polynomial).

Below are the changes introduced by c95eb0b.

root@9235a03db7d7:/tmp/Math-74b# git diff c95eb0b4feac3d85645ce327d54011c8712e0fd4^1 c95eb0b4feac3d85645ce327d54011c8712e0fd4
diff --git a/src/java/org/apache/commons/math/ode/nonstiff/AdaptiveStepsizeIntegrator.java b/src/java/org/apache/commons/math/ode/nonstiff/AdaptiveStepsizeIntegrator.java
index cd2ad01..b49c56d 100644
--- a/src/java/org/apache/commons/math/ode/nonstiff/AdaptiveStepsizeIntegrator.java
+++ b/src/java/org/apache/commons/math/ode/nonstiff/AdaptiveStepsizeIntegrator.java
@@ -108,8 +108,8 @@ public abstract class AdaptiveStepsizeIntegrator
 
     this.scalAbsoluteTolerance = 0;
     this.scalRelativeTolerance = 0;
-    this.vecAbsoluteTolerance  = vecAbsoluteTolerance;
-    this.vecRelativeTolerance  = vecRelativeTolerance;
+    this.vecAbsoluteTolerance  = vecAbsoluteTolerance.clone();
+    this.vecRelativeTolerance  = vecRelativeTolerance.clone();
 
     resetInternalState();

, and this is the line coverage of the failing test case (file: src/main/java/org/apache/commons/math/ode/nonstiff/AdaptiveStepsizeIntegrator.java) measured by Cobertura:

<method name="&lt;init&gt;" signature="(Ljava/lang/String;DD[D[D)V" line-rate="0.0" branch-rate="1.0">
        <lines>
                <line number="123" hits="0" branch="false"/>
                <line number="125" hits="0" branch="false"/>
                <line number="126" hits="0" branch="false"/>
                <line number="127" hits="0" branch="false"/>
                <line number="129" hits="0" branch="false"/> (this.vecAbsoluteTolerance  = vecAbsoluteTolerance.clone();)
                <line number="130" hits="0" branch="false"/> (this.vecRelativeTolerance  = vecRelativeTolerance.clone();)
                <line number="131" hits="0" branch="false"/>
                <line number="132" hits="0" branch="false"/>
                <line number="134" hits="0" branch="false"/>
                <line number="136" hits="0" branch="false"/>
        </lines>
</method>

I believe that changes introduced by BIC should affect the test failure.
Could you please check this issue?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions