Fix orphaned intrusive holders when a RegistryCondition skips an entry#98
Merged
Conversation
When RegistrationDispatcher.register() returned early because a RegistryCondition evaluated to false, the early return skipped the registerAdditional() call but did not clean up any intrusive holder that the entry's constructor may have already allocated via MappedRegistry.createIntrusiveHolder(). The holder was left in MappedRegistry.unregisteredIntrusiveHolders but never bound, so when the registry froze at world load, Minecraft threw "Some intrusive holders were not registered".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When RegistrationDispatcher.register() returned early because a RegistryCondition evaluated to false, the early return skipped the registerAdditional() call but did not clean up any intrusive holder that the entry's constructor may have already allocated via MappedRegistry.createIntrusiveHolder(). The holder was left in MappedRegistry.unregisteredIntrusiveHolders but never bound, so when the registry froze at world load, Minecraft threw "Some intrusive holders were not registered".