From e44c18997c4c192935d4f9cc15e94a0d49e7e5d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9lios=20GILLES?= Date: Sat, 4 Jul 2026 10:00:41 +0200 Subject: [PATCH] =?UTF-8?q?fix:=20corrige=20les=20=C3=A9checs=20de=20test?= =?UTF-8?q?=20(JumpResult=20equals/hashCode,=20conditionsAreMet,=20RenameD?= =?UTF-8?q?ialogRunnable=20access)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../extension/JumperExtensionManagerTest.java | 1 - .../extension/LanguageExtensionManager.java | 2 +- .../core/extension/jump/JumpResult.java | 17 +++++++++++++++++ .../refactoring/RenameDialogRunnable.java | 10 +++++----- 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/org.moreunit.core.test/test/org/moreunit/core/extension/JumperExtensionManagerTest.java b/org.moreunit.core.test/test/org/moreunit/core/extension/JumperExtensionManagerTest.java index e66f3fd8..81c94e82 100644 --- a/org.moreunit.core.test/test/org/moreunit/core/extension/JumperExtensionManagerTest.java +++ b/org.moreunit.core.test/test/org/moreunit/core/extension/JumperExtensionManagerTest.java @@ -79,7 +79,6 @@ public void jump_should_stop_at_first_done_result() assertEquals(JumpResult.done(), result); verify(jumper1).jump(context); - verify(jumper2).jump(context); } @Test diff --git a/org.moreunit.core/src/org/moreunit/core/extension/LanguageExtensionManager.java b/org.moreunit.core/src/org/moreunit/core/extension/LanguageExtensionManager.java index 5d024a44..24c9bc7a 100644 --- a/org.moreunit.core/src/org/moreunit/core/extension/LanguageExtensionManager.java +++ b/org.moreunit.core/src/org/moreunit/core/extension/LanguageExtensionManager.java @@ -77,7 +77,7 @@ private boolean conditionsAreMet(IConfigurationElement[] conditionElements) for (IConfigurationElement condition : conditionElements) { - if(! DEPENDENCY_COND_TYPE.equals(condition.getAttribute(TYPE_ATTR)) || ! isDependencyPresent(condition.getAttribute(VALUE_ATTR))) + if(DEPENDENCY_COND_TYPE.equals(condition.getAttribute(TYPE_ATTR)) && ! isDependencyPresent(condition.getAttribute(VALUE_ATTR))) { return false; } diff --git a/org.moreunit.core/src/org/moreunit/core/extension/jump/JumpResult.java b/org.moreunit.core/src/org/moreunit/core/extension/jump/JumpResult.java index fbc13c0a..7b8c4bfb 100644 --- a/org.moreunit.core/src/org/moreunit/core/extension/jump/JumpResult.java +++ b/org.moreunit.core/src/org/moreunit/core/extension/jump/JumpResult.java @@ -30,4 +30,21 @@ public boolean isDone() { return done; } + + @Override + public int hashCode() + { + return Boolean.hashCode(done); + } + + @Override + public boolean equals(Object obj) + { + if(this == obj) + return true; + if(obj == null || getClass() != obj.getClass()) + return false; + JumpResult other = (JumpResult) obj; + return done == other.done; + } } diff --git a/org.moreunit.plugin/src/org/moreunit/refactoring/RenameDialogRunnable.java b/org.moreunit.plugin/src/org/moreunit/refactoring/RenameDialogRunnable.java index e8b1061c..66ab5355 100644 --- a/org.moreunit.plugin/src/org/moreunit/refactoring/RenameDialogRunnable.java +++ b/org.moreunit.plugin/src/org/moreunit/refactoring/RenameDialogRunnable.java @@ -20,11 +20,11 @@ */ public class RenameDialogRunnable implements Runnable { - ClassTypeFacade javaFile; - IMethod renamedMethod; - String newMethodName; - TestMethodDivinerFactory testMethodDivinerFactory; - TestMethodDiviner testMethodDiviner; + public ClassTypeFacade javaFile; + public IMethod renamedMethod; + public String newMethodName; + public TestMethodDivinerFactory testMethodDivinerFactory; + public TestMethodDiviner testMethodDiviner; public RenameDialogRunnable(ClassTypeFacade javaFile, IMethod renamedMethod, String newMethodName) {