Click won't work

[matze-berg]

When i parse google.com (f.e.) and fill the form with test and hit submit, the url will be wrong.
So there is a url-check needed. For example:

if (filter_var($action, FILTER_VALIDATE_URL) === false) {
$action = $this->current_url().'/'.ltrim($action, '/');
}

Same for the Href-Attribute.
This should be added in all Drivers and then it will work how it should work. :)

[hkdobrev]

@matnex Could you clarify this? From what I gather I think the problem here is that Spiderling does not handle well forms which have relative action URLs.

[matze-berg]

Thats right, you can try it with google.com

[$crawler is my crawling class]
$crawler->response()->fill_in('q', 'Test');
$crawler->response()->find('input.lsb')->click()->end();

So when i execute the click on input.lsb, it won't work, because google will use /search.... as relative URL.

So i changed your function to this and it works:

    /**
     * Click on a Node with id, triggering a link or form submit
     *
     * @param  string $id
     * @throws Exception_Driver If not a clickable element
     */
    public function click($id)
    {
        $node = $this->dom($id);

        if ($node->hasAttribute('href')) {
            /**
             *  URL-Fix by MX-Progress
             */
            //$this->get($node->getAttribute('href'));
            $action = $node->getAttribute('href');
            if (filter_var($action, FILTER_VALIDATE_URL) === false) {
                $action = $this->current_url().'/'.ltrim($action, '/');
            }
            $this->get($action);
        } elseif (($node->tagName == 'input' AND $node->getAttribute('type') == 'submit') OR $node->tagName == 'button') {
            $form = $this->xpath()->find('./ancestor::form', $node);

            $action = $form->hasAttribute('action') ? $form->getAttribute('action') : $this->request->uri();

            $method = $form->hasAttribute('method') ? strtoupper($form->getAttribute('method')) : 'GET';

            $post = $this->forms()->serialize_form($form);

            $files = $this->forms()->serialize_files($form);

            if (in_array($node->tagName, ['button', 'input']) AND $node->hasAttribute('name')) {
                $post = $post.'&'.$node->getAttribute('name').'='.$node->getAttribute('value');
            }
            parse_str($post, $post);
            parse_str($files, $files);

            /**
             *  URL-Fix by MX-Progress
             */
            if (filter_var($action, FILTER_VALIDATE_URL) === false) {
                $action = $this->current_url().'/'.ltrim($action, '/');
            }

            if ($method == 'GET') {
                $this->get($action, $post);
            } else {
                $this->post($action, [], $post, $files);
            }
        } else {
            throw new Exception_Driver('The html tag :tag cannot be clicked', [':tag' => $node->tagName]);
        }
    }

[hkdobrev]

@matnex Could you clarify this? Adding code to an issue which is unclear to me just adds up to the confusion. Could you for example provide the smallest possible HTML reproducing your issue? Could you provide a sample code using Spiderling, what's your expectation and what actually happens? Thanks!

[matze-berg]

Sorry, but what should i post?

Just ty to get https://google.com
After this, insert a word in the form and try to submit it.
That won't work, because the form doesn't point to 'https://google.com/search...'
It just points to '/search...'

Because of this i added the Filter to the code. This checks the action/url/href and if it is invalid, the current url will be inserted before the url. So a complete URL will be called an the script will work.

So this code will change '/search.../ to 'http://.../search...'

        /**
         *  URL-Fix by MX-Progress
         */
        if (filter_var($action, FILTER_VALIDATE_URL) === false) {
            $action = $this->current_url().'/'.ltrim($action, '/');
        }

[halfer]

This looks like it was unclear, and can be closed? I wonder if general support issues should be on Stack Overflow (etc), where they will get wider exposure.