fix: correct React output import paths for minification

- Add post-build step to fix import paths in React output files
- Replace './react/out/MODULE/index.js' with '../MODULE/index.js'
- Replace '../react/out/MODULE/index.js' with '../../MODULE/index.js'
- Fixes 'Could not resolve' errors during minify-vscode step
- React outputs are in sibling directories, so paths need to be relative to each other
- Keep React outputs in external array for tsup resolution, but fix paths after build

Author: Tajudeen

src/vs/workbench/contrib/cortexide/browser/react/build.js

@@ -190,6 +190,52 @@ if (isWatch) {
 	// DTS generation requires significantly more memory (12GB recommended)
 	execSync(`node --max-old-space-size=12288 ${tsupPath}`, { stdio: 'inherit' });
 
+	// Post-build fix: Remove incorrect import statements from React output files
+	// When React outputs are marked as external, tsup preserves import statements
+	// But these imports use paths like './react/out/...' which don't resolve during minification
+	// Since they're external, we need to remove these imports (they'll be loaded at runtime)
+	// allow-any-unicode-next-line
+	console.log('🔧 Fixing React output import paths...');
+	const outDir = path.join(__dirname, 'out');
+	const reactOutputModules = [
+		'void-editor-widgets-tsx',
+		'void-settings-tsx',
+		'sidebar-tsx',
+		'void-tooltip',
+		'void-onboarding',
+		'quick-edit-tsx',
+		'diff'
+	];
+
+	for (const module of reactOutputModules) {
+		const indexPath = path.join(outDir, module, 'index.js');
+		if (fs.existsSync(indexPath)) {
+			let content = fs.readFileSync(indexPath, 'utf8');
+			// Fix import paths: React outputs are in sibling directories under out/
+			// Replace './react/out/MODULE/index.js' with '../MODULE/index.js'
+			// Replace '../react/out/MODULE/index.js' with '../../MODULE/index.js'
+			// This fixes the paths so they resolve correctly during minification
+			content = content.replace(
+				/from\s+['"]\.\/react\/out\/([^/'"]+)\/index\.js['"]/g,
+				"from '../$1/index.js'"
+			);
+			content = content.replace(
+				/from\s+['"]\.\.\/react\/out\/([^/'"]+)\/index\.js['"]/g,
+				"from '../../$1/index.js'"
+			);
+			// Fix dynamic imports: import('./react/out/MODULE/index.js') -> import('../MODULE/index.js')
+			content = content.replace(
+				/import\s*\(\s*['"]\.\/react\/out\/([^/'"]+)\/index\.js['"]\s*\)/g,
+				"import('../$1/index.js')"
+			);
+			content = content.replace(
+				/import\s*\(\s*['"]\.\.\/react\/out\/([^/'"]+)\/index\.js['"]\s*\)/g,
+				"import('../../$1/index.js')"
+			);
+			fs.writeFileSync(indexPath, content, 'utf8');
+		}
+	}
+
 	// allow-any-unicode-next-line
 	console.log('✅ Build complete!');
 }

src/vs/workbench/contrib/cortexide/browser/react/tsup.config.js

@@ -27,15 +27,32 @@ const externalVSCodePlugin = {
 	}
 }
 
-// Plugin to mark React output imports as external during DTS generation
-// This prevents tsup from trying to resolve imports to files that don't exist yet during the build
+// Plugin to mark React output imports as external ONLY during tsup's initial resolution
+// This prevents tsup from trying to resolve imports to files that don't exist yet
+// BUT we need to be careful: if these are marked external, they won't be bundled
+// The key is that this plugin only runs during esbuild's resolution, and we want
+// React outputs to be bundled together (not external) for minification
+// 
+// Actually, the real issue is that files outside React dir import from ./react/out/...
+// When tsup builds, it shouldn't follow those imports. We need to prevent tsup
+// from following imports from files outside the entry points.
 const externalReactOutputsPlugin = {
 	name: 'external-react-outputs',
 	setup(build) {
+		// Only mark as external if the import is coming from outside the React source directory
+		// This prevents tsup from trying to resolve imports from files like cortexideSettingsPane.ts
+		// But allows React components to import each other normally (which should be bundled)
 		build.onResolve({ filter: /^\.\/react\/out\/|^\.\.\/react\/out\// }, (args) => {
-			// Mark React output imports as external during build (they'll be available at runtime)
-			// This prevents DTS generation from failing when these files don't exist yet
-			return { path: args.path, external: true }
+			// Check if the importer is outside the React source directory
+			// If so, mark as external (these are runtime imports)
+			// If not, let it be bundled (these are internal React component imports)
+			if (args.importer && !args.importer.includes('/react/src') && !args.importer.includes('/react/src2')) {
+				// This import is from outside React source, mark as external
+				// This prevents tsup from trying to resolve it during build
+				return { path: args.path, external: true }
+			}
+			// This is an internal import, let it be bundled
+			return undefined
 		})
 	}
 }
@@ -64,18 +81,13 @@ export default defineConfig({
 	outExtension: () => ({ js: '.js' }),
 	treeshake: true,
 	// Mark Node.js built-ins and React output imports as external
-	// React outputs MUST be in the external array (not just plugin) because:
-	// 1. tsup does its own import resolution BEFORE esbuild
-	// 2. When tsup encounters imports from files outside React dir (e.g., cortexideSettingsPane.ts),
-	//    it tries to resolve them during tsup's resolution phase
-	// 3. The external array is checked during tsup's phase, plugins only run during esbuild phase
-	// 4. If not in external array, tsup tries to resolve files that don't exist yet → fails
+	// CRITICAL: React outputs MUST be in external array for tsup's resolution phase
+	// BUT: The plugin will handle them during esbuild phase to allow bundling
+	// The external array prevents tsup from trying to resolve imports from files outside React dir
 	external: [
 		'url', 'module', 'fs', 'path', 'os', 'crypto', 'stream', 'util', 'events', 'buffer', 'process',
 		// React output imports - MUST be external at tsup level to prevent resolution errors
-		// tsup checks external array during its own resolution phase (before esbuild)
-		// If not listed here, tsup tries to resolve files that don't exist yet → fails
-		// These are the exact paths used in imports from files outside React directory
+		// These prevent tsup from trying to resolve imports from files like cortexideSettingsPane.ts
 		'./react/out/void-editor-widgets-tsx/index.js',
 		'./react/out/void-settings-tsx/index.js',
 		'./react/out/sidebar-tsx/index.js',