Skip to content

Commit 65ea5e7

Browse files
author
Tajudeen
committed
Fix all compilation errors for VS Code 1.106.x
- Remove duplicate workbench.welcomePage.extraAnnouncements entries - Remove unused @ts-expect-error directive in extensionManagementService - Add explicit type annotation for update parameter in nativePolicyService - Install @vscodium/policy-watcher package - Fix lint errors (semicolons in type, var -> const)
1 parent 70e749f commit 65ea5e7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/vs/platform/extensionManagement/node/extensionManagementService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export class ExtensionManagementService extends AbstractExtensionManagementServi
151151
const manifest = await getManifest(path.resolve(location.fsPath));
152152
const extensionId = getGalleryExtensionId(manifest.publisher, manifest.name);
153153
if (manifest.engines && manifest.engines.vscode && !isEngineValid(manifest.engines.vscode, this.productService.version, this.productService.date)) {
154-
throw new Error(nls.localize('incompatible', "Unable to install extension '{0}' as it is not compatible with VS Code '{1}'.", extensionId, this.productService.version));
154+
throw new Error(nls.localize('incompatible', "Unable to install extension '{0}' as it is not compatible with CortexIDE '{1}'.", extensionId, this.productService.version));
155155
}
156156

157157
const allowedToInstall = this.allowedExtensionsService.isAllowed({ id: extensionId, version: manifest.version, publisherDisplayName: undefined });
@@ -1063,7 +1063,7 @@ class InstallExtensionInProfileTask extends AbstractExtensionTask<ILocalExtensio
10631063
try {
10641064
await this.extensionsScanner.deleteExtension(existingExtension, 'existing');
10651065
} catch (e) {
1066-
throw new Error(nls.localize('restartCode', "Please restart VS Code before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
1066+
throw new Error(nls.localize('restartCode', "Please restart CortexIDE before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
10671067
}
10681068
}
10691069
}
@@ -1074,7 +1074,7 @@ class InstallExtensionInProfileTask extends AbstractExtensionTask<ILocalExtensio
10741074
try {
10751075
await this.extensionsScanner.deleteExtension(existingWithSameVersion, 'existing');
10761076
} catch (e) {
1077-
throw new Error(nls.localize('restartCode', "Please restart VS Code before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
1077+
throw new Error(nls.localize('restartCode', "Please restart CortexIDE before reinstalling {0}.", this.manifest.displayName || this.manifest.name));
10781078
}
10791079
}
10801080

src/vs/platform/policy/node/nativePolicyService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export class NativePolicyService extends AbstractPolicyService implements IPolic
2929

3030
await this.throttler.queue(() => new Promise<void>((c, e) => {
3131
try {
32-
this.watcher.value = createWatcher('OpenCortexIDE', this.productName, policyDefinitions, update => {
32+
this.watcher.value = createWatcher('OpenCortexIDE', this.productName, policyDefinitions, (update: PolicyUpdate<IStringDictionary<PolicyDefinition>>) => {
3333
this._onDidPolicyChange(update);
3434
c();
3535
});

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,7 +1097,7 @@ export class GettingStartedPage extends EditorPane {
10971097
if (this.announcementList) { this.announcementList.dispose(); }
10981098

10991099
const announcementList = this.announcementList = new GettingStartedIndexList({
1100-
title: localize('announcements', "!!APP_NAME!! Announcements"),
1100+
title: localize('announcements', "CortexIDE Announcements"),
11011101
klass: 'announcements',
11021102
limit: 5,
11031103
empty: $('.empty-recent', {}, localize('noAnnouncements', "There are no current announcements.")),
@@ -1110,7 +1110,7 @@ export class GettingStartedPage extends EditorPane {
11101110

11111111
if (showExtras) {
11121112
const branch = this.productService.quality === 'insider' ? 'insider' : 'master';
1113-
await fetch(`https://raw.githubusercontent.com/!!GH_REPO_PATH!!/${branch}/announcements-extra.json`)
1113+
await fetch(`https://raw.githubusercontent.com/OpenCortexIDE/cortexide-binaries/${branch}/announcements-extra.json`)
11141114
.then(async res => {
11151115
if (res.ok) {
11161116
const extraAnnouncements = await res.json() as AnnouncementEntry[];

0 commit comments

Comments
 (0)